From: Rob Herring <robherring2@gmail.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Arnd Bergmann <arnd.bergmann@linaro.org>,
Nishanth Menon <nm@ti.com>, Mark Brown <broonie@kernel.org>,
Mike Turquette <mike.turquette@linaro.org>,
Stephen Boyd <sboyd@codeaurora.org>,
Grant Likely <grant.likely@linaro.org>,
Olof Johansson <olof@lixom.net>,
Sudeep Holla <Sudeep.Holla@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Viswanath Puttagunta <viswanath.puttagunta@linaro.org>,
Lucas Stach <l.stach@pengutronix.de>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Thomas Abraham <ta.omasab@gmail.com>,
Abhilash Kesavan <kesavan.abhilash@gmail.com>,
Kevin Hilman <khilman@linaro.org>,
Santosh
Subject: Re: [PATCH V7 3/3] OPP: Add binding for 'opp-suspend'
Date: Mon, 15 Jun 2015 18:35:22 -0500 [thread overview]
Message-ID: <CAL_JsqJb4P2Z2esgm5ffjWV37MU2KUF4gBdUpwSV8+21iTD1Bg@mail.gmail.com> (raw)
In-Reply-To: <dedf8c02fdd9dbf169f43de74ead4c1434d89b45.1433434659.git.viresh.kumar@linaro.org>
On Thu, Jun 4, 2015 at 11:20 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On few platforms, for power efficiency, we want the device to be
> configured for a specific OPP while we put the device in suspend state.
>
> Add an optional property in operating-points-v2 bindings for that.
>
> Acked-by: Nishanth Menon <nm@ti.com>
> Suggested-by: Nishanth Menon <nm@ti.com>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> Documentation/devicetree/bindings/power/opp.txt | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/power/opp.txt b/Documentation/devicetree/bindings/power/opp.txt
> index 2938c52dbf84..6c245d87dd50 100644
> --- a/Documentation/devicetree/bindings/power/opp.txt
> +++ b/Documentation/devicetree/bindings/power/opp.txt
> @@ -74,6 +74,8 @@ This describes the OPPs belonging to a device. This node can have following
> Missing property means devices have independent clock/voltage/current lines,
> but they share OPP tables.
>
> +- opp-suspend: Phandle of the OPP to set while device is suspended.
> +
I would just do a bool property in the OPP you want.
Rob
>
> * OPP Node
>
> @@ -145,9 +147,10 @@ Example 1: Single cluster Dual-core ARM cortex A9, switch DVFS states together.
>
> cpu0_opp_table: opp_table0 {
> compatible = "operating-points-v2";
> + opp-suspend = <&suspend_opp>;
> opp-shared;
>
> - opp00 {
> + suspend-opp: opp00 {
> opp-hz = <1000000000>;
> opp-microvolt = <970000 975000 985000>;
> opp-microamp = <70000>;
> @@ -219,13 +222,14 @@ independently.
>
> cpu_opp_table: opp_table {
> compatible = "operating-points-v2";
> + opp-suspend = <&suspend_opp>;
>
> /*
> * Missing opp-shared property means CPUs switch DVFS states
> * independently.
> */
>
> - opp00 {
> + suspend-opp: opp00 {
> opp-hz = <1000000000>;
> opp-microvolt = <970000 975000 985000>;
> opp-microamp = <70000>;
> @@ -298,9 +302,10 @@ DVFS state together.
>
> cluster0_opp: opp_table0 {
> compatible = "operating-points-v2";
> + opp-suspend = <&suspend_opp0>;
> opp-shared;
>
> - opp00 {
> + suspend-opp: opp00 {
> opp-hz = <1000000000>;
> opp-microvolt = <970000 975000 985000>;
> opp-microamp = <70000>;
> @@ -323,9 +328,10 @@ DVFS state together.
>
> cluster1_opp: opp_table1 {
> compatible = "operating-points-v2";
> + opp-suspend = <&suspend_opp1>;
> opp-shared;
>
> - opp10 {
> + suspend-opp: opp10 {
> opp-hz = <1300000000>;
> opp-microvolt = <1045000 1050000 1055000>;
> opp-microamp = <95000>;
> --
> 2.4.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V7 3/3] OPP: Add binding for 'opp-suspend'
Date: Mon, 15 Jun 2015 18:35:22 -0500 [thread overview]
Message-ID: <CAL_JsqJb4P2Z2esgm5ffjWV37MU2KUF4gBdUpwSV8+21iTD1Bg@mail.gmail.com> (raw)
In-Reply-To: <dedf8c02fdd9dbf169f43de74ead4c1434d89b45.1433434659.git.viresh.kumar@linaro.org>
On Thu, Jun 4, 2015 at 11:20 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On few platforms, for power efficiency, we want the device to be
> configured for a specific OPP while we put the device in suspend state.
>
> Add an optional property in operating-points-v2 bindings for that.
>
> Acked-by: Nishanth Menon <nm@ti.com>
> Suggested-by: Nishanth Menon <nm@ti.com>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> Documentation/devicetree/bindings/power/opp.txt | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/power/opp.txt b/Documentation/devicetree/bindings/power/opp.txt
> index 2938c52dbf84..6c245d87dd50 100644
> --- a/Documentation/devicetree/bindings/power/opp.txt
> +++ b/Documentation/devicetree/bindings/power/opp.txt
> @@ -74,6 +74,8 @@ This describes the OPPs belonging to a device. This node can have following
> Missing property means devices have independent clock/voltage/current lines,
> but they share OPP tables.
>
> +- opp-suspend: Phandle of the OPP to set while device is suspended.
> +
I would just do a bool property in the OPP you want.
Rob
>
> * OPP Node
>
> @@ -145,9 +147,10 @@ Example 1: Single cluster Dual-core ARM cortex A9, switch DVFS states together.
>
> cpu0_opp_table: opp_table0 {
> compatible = "operating-points-v2";
> + opp-suspend = <&suspend_opp>;
> opp-shared;
>
> - opp00 {
> + suspend-opp: opp00 {
> opp-hz = <1000000000>;
> opp-microvolt = <970000 975000 985000>;
> opp-microamp = <70000>;
> @@ -219,13 +222,14 @@ independently.
>
> cpu_opp_table: opp_table {
> compatible = "operating-points-v2";
> + opp-suspend = <&suspend_opp>;
>
> /*
> * Missing opp-shared property means CPUs switch DVFS states
> * independently.
> */
>
> - opp00 {
> + suspend-opp: opp00 {
> opp-hz = <1000000000>;
> opp-microvolt = <970000 975000 985000>;
> opp-microamp = <70000>;
> @@ -298,9 +302,10 @@ DVFS state together.
>
> cluster0_opp: opp_table0 {
> compatible = "operating-points-v2";
> + opp-suspend = <&suspend_opp0>;
> opp-shared;
>
> - opp00 {
> + suspend-opp: opp00 {
> opp-hz = <1000000000>;
> opp-microvolt = <970000 975000 985000>;
> opp-microamp = <70000>;
> @@ -323,9 +328,10 @@ DVFS state together.
>
> cluster1_opp: opp_table1 {
> compatible = "operating-points-v2";
> + opp-suspend = <&suspend_opp1>;
> opp-shared;
>
> - opp10 {
> + suspend-opp: opp10 {
> opp-hz = <1300000000>;
> opp-microvolt = <1045000 1050000 1055000>;
> opp-microamp = <95000>;
> --
> 2.4.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-06-15 23:35 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-04 16:20 [PATCH V7 0/3] OPP: Introduce OPP (V2) bindings Viresh Kumar
2015-06-04 16:20 ` Viresh Kumar
[not found] ` <cover.1433434659.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-06-04 16:20 ` [PATCH V7 1/3] OPP: Add new bindings to address shortcomings of existing bindings Viresh Kumar
2015-06-04 16:20 ` Viresh Kumar
2015-06-04 18:37 ` Stephen Boyd
2015-06-04 18:37 ` Stephen Boyd
2015-06-05 2:41 ` Viresh Kumar
2015-06-05 2:41 ` Viresh Kumar
2015-06-16 13:34 ` Nishanth Menon
2015-06-16 13:34 ` Nishanth Menon
2015-06-04 16:20 ` [PATCH V7 2/3] OPP: Allow multiple OPP tables to be passed via DT Viresh Kumar
2015-06-04 16:20 ` Viresh Kumar
2015-06-17 13:23 ` Rob Herring
2015-06-17 13:23 ` Rob Herring
2015-06-17 13:33 ` Viresh Kumar
2015-06-17 13:33 ` Viresh Kumar
2015-06-17 13:47 ` Rob Herring
2015-06-17 13:47 ` Rob Herring
2015-06-17 14:42 ` Viresh Kumar
2015-06-17 14:42 ` Viresh Kumar
2015-06-18 1:30 ` Stephen Boyd
2015-06-18 1:30 ` Stephen Boyd
2015-06-18 2:25 ` Viresh Kumar
2015-06-18 2:25 ` Viresh Kumar
2015-06-18 2:50 ` Viresh Kumar
2015-06-18 2:50 ` Viresh Kumar
2015-06-19 18:47 ` Stephen Boyd
2015-06-19 18:47 ` Stephen Boyd
[not found] ` <20150619184747.GD22132-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-06-19 18:52 ` Rob Herring
2015-06-19 18:52 ` Rob Herring
[not found] ` <CAL_JsqJfWDO4r_FP6xHSxRkMM-pSnbEUB=d9Gj6mhvPY+ouLxA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-20 2:24 ` Viresh Kumar
2015-06-20 2:24 ` Viresh Kumar
2015-06-19 18:44 ` Stephen Boyd
2015-06-19 18:44 ` Stephen Boyd
2015-06-20 2:18 ` Viresh Kumar
2015-06-20 2:18 ` Viresh Kumar
2015-06-04 16:20 ` [PATCH V7 3/3] OPP: Add binding for 'opp-suspend' Viresh Kumar
2015-06-04 16:20 ` Viresh Kumar
2015-06-13 8:40 ` Viresh Kumar
2015-06-13 8:40 ` Viresh Kumar
2015-06-15 22:30 ` Rafael J. Wysocki
2015-06-15 22:30 ` Rafael J. Wysocki
2015-06-15 23:35 ` Rob Herring [this message]
2015-06-15 23:35 ` Rob Herring
[not found] ` <CAL_JsqJb4P2Z2esgm5ffjWV37MU2KUF4gBdUpwSV8+21iTD1Bg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-16 0:31 ` Viresh Kumar
2015-06-16 0:31 ` Viresh Kumar
2015-06-16 2:54 ` Viresh Kumar
2015-06-16 2:54 ` Viresh Kumar
2015-06-16 19:23 ` Rob Herring
2015-06-16 19:23 ` Rob Herring
2015-06-16 21:21 ` Rafael J. Wysocki
2015-06-16 21:21 ` Rafael J. Wysocki
2015-06-17 2:38 ` Viresh Kumar
2015-06-17 2:38 ` Viresh Kumar
2015-06-17 9:38 ` Rafael J. Wysocki
2015-06-17 9:38 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqJb4P2Z2esgm5ffjWV37MU2KUF4gBdUpwSV8+21iTD1Bg@mail.gmail.com \
--to=robherring2@gmail.com \
--cc=Sudeep.Holla@arm.com \
--cc=arnd.bergmann@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=kesavan.abhilash@gmail.com \
--cc=khilman@linaro.org \
--cc=l.stach@pengutronix.de \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=mike.turquette@linaro.org \
--cc=nm@ti.com \
--cc=olof@lixom.net \
--cc=rjw@rjwysocki.net \
--cc=sboyd@codeaurora.org \
--cc=ta.omasab@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=viresh.kumar@linaro.org \
--cc=viswanath.puttagunta@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.