All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Rafael Wysocki <rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org>,
	"linaro-kernel-cunTk1MwBs8s++Sfvej+rw@public.gmane.org"
	<linaro-kernel-cunTk1MwBs8s++Sfvej+rw@public.gmane.org>,
	"linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Arnd Bergmann
	<arnd.bergmann-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>,
	Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Mike Turquette
	<mike.turquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	Grant Likely
	<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
	Sudeep Holla <Sudeep.Holla-5wv7dgnIgG8@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Viswanath Puttagunta
	<viswanath.puttagunta-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	Thomas Petazzoni
	<thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	Thomas Abraham
	<ta.omasab-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Abhilash Kesavan
	<kesavan.abhilash-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Kevin Hilman <khilman-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Santosh
Subject: Re: [PATCH V7 3/3] OPP: Add binding for 'opp-suspend'
Date: Tue, 16 Jun 2015 06:01:58 +0530	[thread overview]
Message-ID: <CAKohpomTT6i0dbboK901eguCbQiBdCT6gvLvTY24ajDdY__2fg@mail.gmail.com> (raw)
In-Reply-To: <CAL_JsqJb4P2Z2esgm5ffjWV37MU2KUF4gBdUpwSV8+21iTD1Bg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On 16 June 2015 at 05:05, Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> +- opp-suspend: Phandle of the OPP to set while device is suspended.
>> +
>
> I would just do a bool property in the OPP you want.

I will do that if you want, no big deal.

But I would like to explain why I did it this way. Nishanth asked the same
thing earlier and now he looks convinced :)

There can only be one OPP that can be selected during suspend. Allowing
more than one OPP to select this property doesn't look like the right thing
to me. In that case we have to make a rule that the first OPP in the table
will be selected or error out in that case.

And I thought that this is property of the table, instead of each OPP. For
example, in code this will waste lots of space if we choose such a field
in individual OPPs, and we will always keep it in the OPP-table thing..

But then this is DT :)

I will wait for your reply Rob on this, and then will send an update. Thanks.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V7 3/3] OPP: Add binding for 'opp-suspend'
Date: Tue, 16 Jun 2015 06:01:58 +0530	[thread overview]
Message-ID: <CAKohpomTT6i0dbboK901eguCbQiBdCT6gvLvTY24ajDdY__2fg@mail.gmail.com> (raw)
In-Reply-To: <CAL_JsqJb4P2Z2esgm5ffjWV37MU2KUF4gBdUpwSV8+21iTD1Bg@mail.gmail.com>

On 16 June 2015 at 05:05, Rob Herring <robherring2@gmail.com> wrote:
>> +- opp-suspend: Phandle of the OPP to set while device is suspended.
>> +
>
> I would just do a bool property in the OPP you want.

I will do that if you want, no big deal.

But I would like to explain why I did it this way. Nishanth asked the same
thing earlier and now he looks convinced :)

There can only be one OPP that can be selected during suspend. Allowing
more than one OPP to select this property doesn't look like the right thing
to me. In that case we have to make a rule that the first OPP in the table
will be selected or error out in that case.

And I thought that this is property of the table, instead of each OPP. For
example, in code this will waste lots of space if we choose such a field
in individual OPPs, and we will always keep it in the OPP-table thing..

But then this is DT :)

I will wait for your reply Rob on this, and then will send an update. Thanks.

  parent reply	other threads:[~2015-06-16  0:31 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-04 16:20 [PATCH V7 0/3] OPP: Introduce OPP (V2) bindings Viresh Kumar
2015-06-04 16:20 ` Viresh Kumar
     [not found] ` <cover.1433434659.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-06-04 16:20   ` [PATCH V7 1/3] OPP: Add new bindings to address shortcomings of existing bindings Viresh Kumar
2015-06-04 16:20     ` Viresh Kumar
2015-06-04 18:37     ` Stephen Boyd
2015-06-04 18:37       ` Stephen Boyd
2015-06-05  2:41       ` Viresh Kumar
2015-06-05  2:41         ` Viresh Kumar
2015-06-16 13:34     ` Nishanth Menon
2015-06-16 13:34       ` Nishanth Menon
2015-06-04 16:20 ` [PATCH V7 2/3] OPP: Allow multiple OPP tables to be passed via DT Viresh Kumar
2015-06-04 16:20   ` Viresh Kumar
2015-06-17 13:23   ` Rob Herring
2015-06-17 13:23     ` Rob Herring
2015-06-17 13:33     ` Viresh Kumar
2015-06-17 13:33       ` Viresh Kumar
2015-06-17 13:47       ` Rob Herring
2015-06-17 13:47         ` Rob Herring
2015-06-17 14:42         ` Viresh Kumar
2015-06-17 14:42           ` Viresh Kumar
2015-06-18  1:30         ` Stephen Boyd
2015-06-18  1:30           ` Stephen Boyd
2015-06-18  2:25           ` Viresh Kumar
2015-06-18  2:25             ` Viresh Kumar
2015-06-18  2:50             ` Viresh Kumar
2015-06-18  2:50               ` Viresh Kumar
2015-06-19 18:47               ` Stephen Boyd
2015-06-19 18:47                 ` Stephen Boyd
     [not found]                 ` <20150619184747.GD22132-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-06-19 18:52                   ` Rob Herring
2015-06-19 18:52                     ` Rob Herring
     [not found]                     ` <CAL_JsqJfWDO4r_FP6xHSxRkMM-pSnbEUB=d9Gj6mhvPY+ouLxA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-20  2:24                       ` Viresh Kumar
2015-06-20  2:24                         ` Viresh Kumar
2015-06-19 18:44             ` Stephen Boyd
2015-06-19 18:44               ` Stephen Boyd
2015-06-20  2:18               ` Viresh Kumar
2015-06-20  2:18                 ` Viresh Kumar
2015-06-04 16:20 ` [PATCH V7 3/3] OPP: Add binding for 'opp-suspend' Viresh Kumar
2015-06-04 16:20   ` Viresh Kumar
2015-06-13  8:40   ` Viresh Kumar
2015-06-13  8:40     ` Viresh Kumar
2015-06-15 22:30     ` Rafael J. Wysocki
2015-06-15 22:30       ` Rafael J. Wysocki
2015-06-15 23:35   ` Rob Herring
2015-06-15 23:35     ` Rob Herring
     [not found]     ` <CAL_JsqJb4P2Z2esgm5ffjWV37MU2KUF4gBdUpwSV8+21iTD1Bg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-16  0:31       ` Viresh Kumar [this message]
2015-06-16  0:31         ` Viresh Kumar
2015-06-16  2:54         ` Viresh Kumar
2015-06-16  2:54           ` Viresh Kumar
2015-06-16 19:23           ` Rob Herring
2015-06-16 19:23             ` Rob Herring
2015-06-16 21:21             ` Rafael J. Wysocki
2015-06-16 21:21               ` Rafael J. Wysocki
2015-06-17  2:38               ` Viresh Kumar
2015-06-17  2:38                 ` Viresh Kumar
2015-06-17  9:38                 ` Rafael J. Wysocki
2015-06-17  9:38                   ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKohpomTT6i0dbboK901eguCbQiBdCT6gvLvTY24ajDdY__2fg@mail.gmail.com \
    --to=viresh.kumar-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
    --cc=Sudeep.Holla-5wv7dgnIgG8@public.gmane.org \
    --cc=arnd.bergmann-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=kesavan.abhilash-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=khilman-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    --cc=linaro-kernel-cunTk1MwBs8s++Sfvej+rw@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mike.turquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=nm-l0cyMroinI0@public.gmane.org \
    --cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
    --cc=rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org \
    --cc=robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=ta.omasab-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
    --cc=viswanath.puttagunta-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.