From: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Cc: Viresh Kumar
<viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Rafael Wysocki <rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org>,
"linaro-kernel-cunTk1MwBs8s++Sfvej+rw@public.gmane.org"
<linaro-kernel-cunTk1MwBs8s++Sfvej+rw@public.gmane.org>,
"linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Arnd Bergmann
<arnd.bergmann-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>,
Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mike Turquette
<mike.turquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Grant Likely
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
Sudeep Holla <Sudeep.Holla-5wv7dgnIgG8@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Viswanath Puttagunta
<viswanath.puttagunta-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Thomas Petazzoni
<thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
Thomas Abraham
<ta.omasab-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Abhilash Kesavan
<kesavan.abhilash-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Kevin Hilman <khilman-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Santosh
Subject: Re: [PATCH V7 2/3] OPP: Allow multiple OPP tables to be passed via DT
Date: Fri, 19 Jun 2015 13:52:10 -0500 [thread overview]
Message-ID: <CAL_JsqJfWDO4r_FP6xHSxRkMM-pSnbEUB=d9Gj6mhvPY+ouLxA@mail.gmail.com> (raw)
In-Reply-To: <20150619184747.GD22132-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
On Fri, Jun 19, 2015 at 1:47 PM, Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> wrote:
> On 06/18, Viresh Kumar wrote:
>> On 18-06-15, 07:55, Viresh Kumar wrote:
>> > Why do you think so? For me the operating-points-v2-names property
>> > will be present in CPU node (as there is no OPP node which can have
>> > it) and so every CPU is free to choose what it wants to.
>>
>> So, I had something like this in mind:
>>
>> From: Viresh Kumar <viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>> Date: Thu, 30 Apr 2015 17:38:00 +0530
>> Subject: [PATCH] OPP: Allow multiple OPP tables to be passed via DT
>>
>> On some platforms (Like Qualcomm's SoCs), it is not decided until
>> runtime on what OPPs to use. The OPP tables can be fixed at compile
>> time, but which table to use is found out only after reading some efuses
>> (sort of an prom) and knowing characteristics of the SoC.
>>
>> To support such platform we need to pass multiple OPP tables per device
>> and hardware should be able to choose one and only one table out of
>> those.
>>
>> Update operating-points-v2 bindings to support that.
>>
>> Signed-off-by: Viresh Kumar <viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>
> Looks mostly ok..
>
>> ---
>> Documentation/devicetree/bindings/power/opp.txt | 63 +++++++++++++++++++++++++
>> 1 file changed, 63 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/power/opp.txt b/Documentation/devicetree/bindings/power/opp.txt
>> index 259bf00edf7d..72ccacaac9c9 100644
>> --- a/Documentation/devicetree/bindings/power/opp.txt
>> +++ b/Documentation/devicetree/bindings/power/opp.txt
>> @@ -45,10 +45,21 @@ Devices supporting OPPs must set their "operating-points-v2" property with
>> phandle to a OPP table in their DT node. The OPP core will use this phandle to
>> find the operating points for the device.
>>
>> +Devices may want to choose OPP tables at runtime and so can provide a list of
>> +phandles here. But only *one* of them should be chosen at runtime. This must be
>> +accompanied by a corresponding "operating-points-v2-names" property, to uniquely
>> +identify the OPP tables.
>> +
>> If required, this can be extended for SoC vendor specfic bindings. Such bindings
>> should be documented as Documentation/devicetree/bindings/power/<vendor>-opp.txt
>> and should have a compatible description like: "operating-points-v2-<vendor>".
>>
>> +Optional properties:
>> +- operating-points-v2-names: Names of OPP tables (required if multiple OPP
Let's drop v2. We know it only applies to v2.
>> + tables are present), to uniquely identify them. The same list must be present
>> + for all the CPUs which are sharing clock/voltage rails and hence the OPP
>> + tables.
>> +
>> * OPP Table Node
>>
>> This describes the OPPs belonging to a device. This node can have following
>> @@ -63,11 +74,16 @@ This describes the OPPs belonging to a device. This node can have following
>> reference an OPP.
>>
>> Optional properties:
>> +- opp-name: Name of the OPP table, to uniquely identify it if more than one OPP
>> + table is supplied in "operating-points-v2" property of device.
>> +
>
> But isn't this being removed? If it is removed, feel free to add
>
> Reviewed-by: Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Same question here.
Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
WARNING: multiple messages have this Message-ID (diff)
From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V7 2/3] OPP: Allow multiple OPP tables to be passed via DT
Date: Fri, 19 Jun 2015 13:52:10 -0500 [thread overview]
Message-ID: <CAL_JsqJfWDO4r_FP6xHSxRkMM-pSnbEUB=d9Gj6mhvPY+ouLxA@mail.gmail.com> (raw)
In-Reply-To: <20150619184747.GD22132@codeaurora.org>
On Fri, Jun 19, 2015 at 1:47 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> On 06/18, Viresh Kumar wrote:
>> On 18-06-15, 07:55, Viresh Kumar wrote:
>> > Why do you think so? For me the operating-points-v2-names property
>> > will be present in CPU node (as there is no OPP node which can have
>> > it) and so every CPU is free to choose what it wants to.
>>
>> So, I had something like this in mind:
>>
>> From: Viresh Kumar <viresh.kumar@linaro.org>
>> Date: Thu, 30 Apr 2015 17:38:00 +0530
>> Subject: [PATCH] OPP: Allow multiple OPP tables to be passed via DT
>>
>> On some platforms (Like Qualcomm's SoCs), it is not decided until
>> runtime on what OPPs to use. The OPP tables can be fixed at compile
>> time, but which table to use is found out only after reading some efuses
>> (sort of an prom) and knowing characteristics of the SoC.
>>
>> To support such platform we need to pass multiple OPP tables per device
>> and hardware should be able to choose one and only one table out of
>> those.
>>
>> Update operating-points-v2 bindings to support that.
>>
>> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
>
> Looks mostly ok..
>
>> ---
>> Documentation/devicetree/bindings/power/opp.txt | 63 +++++++++++++++++++++++++
>> 1 file changed, 63 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/power/opp.txt b/Documentation/devicetree/bindings/power/opp.txt
>> index 259bf00edf7d..72ccacaac9c9 100644
>> --- a/Documentation/devicetree/bindings/power/opp.txt
>> +++ b/Documentation/devicetree/bindings/power/opp.txt
>> @@ -45,10 +45,21 @@ Devices supporting OPPs must set their "operating-points-v2" property with
>> phandle to a OPP table in their DT node. The OPP core will use this phandle to
>> find the operating points for the device.
>>
>> +Devices may want to choose OPP tables at runtime and so can provide a list of
>> +phandles here. But only *one* of them should be chosen at runtime. This must be
>> +accompanied by a corresponding "operating-points-v2-names" property, to uniquely
>> +identify the OPP tables.
>> +
>> If required, this can be extended for SoC vendor specfic bindings. Such bindings
>> should be documented as Documentation/devicetree/bindings/power/<vendor>-opp.txt
>> and should have a compatible description like: "operating-points-v2-<vendor>".
>>
>> +Optional properties:
>> +- operating-points-v2-names: Names of OPP tables (required if multiple OPP
Let's drop v2. We know it only applies to v2.
>> + tables are present), to uniquely identify them. The same list must be present
>> + for all the CPUs which are sharing clock/voltage rails and hence the OPP
>> + tables.
>> +
>> * OPP Table Node
>>
>> This describes the OPPs belonging to a device. This node can have following
>> @@ -63,11 +74,16 @@ This describes the OPPs belonging to a device. This node can have following
>> reference an OPP.
>>
>> Optional properties:
>> +- opp-name: Name of the OPP table, to uniquely identify it if more than one OPP
>> + table is supplied in "operating-points-v2" property of device.
>> +
>
> But isn't this being removed? If it is removed, feel free to add
>
> Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
Same question here.
Acked-by: Rob Herring <robh@kernel.org>
Rob
next prev parent reply other threads:[~2015-06-19 18:52 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-04 16:20 [PATCH V7 0/3] OPP: Introduce OPP (V2) bindings Viresh Kumar
2015-06-04 16:20 ` Viresh Kumar
[not found] ` <cover.1433434659.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-06-04 16:20 ` [PATCH V7 1/3] OPP: Add new bindings to address shortcomings of existing bindings Viresh Kumar
2015-06-04 16:20 ` Viresh Kumar
2015-06-04 18:37 ` Stephen Boyd
2015-06-04 18:37 ` Stephen Boyd
2015-06-05 2:41 ` Viresh Kumar
2015-06-05 2:41 ` Viresh Kumar
2015-06-16 13:34 ` Nishanth Menon
2015-06-16 13:34 ` Nishanth Menon
2015-06-04 16:20 ` [PATCH V7 2/3] OPP: Allow multiple OPP tables to be passed via DT Viresh Kumar
2015-06-04 16:20 ` Viresh Kumar
2015-06-17 13:23 ` Rob Herring
2015-06-17 13:23 ` Rob Herring
2015-06-17 13:33 ` Viresh Kumar
2015-06-17 13:33 ` Viresh Kumar
2015-06-17 13:47 ` Rob Herring
2015-06-17 13:47 ` Rob Herring
2015-06-17 14:42 ` Viresh Kumar
2015-06-17 14:42 ` Viresh Kumar
2015-06-18 1:30 ` Stephen Boyd
2015-06-18 1:30 ` Stephen Boyd
2015-06-18 2:25 ` Viresh Kumar
2015-06-18 2:25 ` Viresh Kumar
2015-06-18 2:50 ` Viresh Kumar
2015-06-18 2:50 ` Viresh Kumar
2015-06-19 18:47 ` Stephen Boyd
2015-06-19 18:47 ` Stephen Boyd
[not found] ` <20150619184747.GD22132-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-06-19 18:52 ` Rob Herring [this message]
2015-06-19 18:52 ` Rob Herring
[not found] ` <CAL_JsqJfWDO4r_FP6xHSxRkMM-pSnbEUB=d9Gj6mhvPY+ouLxA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-20 2:24 ` Viresh Kumar
2015-06-20 2:24 ` Viresh Kumar
2015-06-19 18:44 ` Stephen Boyd
2015-06-19 18:44 ` Stephen Boyd
2015-06-20 2:18 ` Viresh Kumar
2015-06-20 2:18 ` Viresh Kumar
2015-06-04 16:20 ` [PATCH V7 3/3] OPP: Add binding for 'opp-suspend' Viresh Kumar
2015-06-04 16:20 ` Viresh Kumar
2015-06-13 8:40 ` Viresh Kumar
2015-06-13 8:40 ` Viresh Kumar
2015-06-15 22:30 ` Rafael J. Wysocki
2015-06-15 22:30 ` Rafael J. Wysocki
2015-06-15 23:35 ` Rob Herring
2015-06-15 23:35 ` Rob Herring
[not found] ` <CAL_JsqJb4P2Z2esgm5ffjWV37MU2KUF4gBdUpwSV8+21iTD1Bg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-16 0:31 ` Viresh Kumar
2015-06-16 0:31 ` Viresh Kumar
2015-06-16 2:54 ` Viresh Kumar
2015-06-16 2:54 ` Viresh Kumar
2015-06-16 19:23 ` Rob Herring
2015-06-16 19:23 ` Rob Herring
2015-06-16 21:21 ` Rafael J. Wysocki
2015-06-16 21:21 ` Rafael J. Wysocki
2015-06-17 2:38 ` Viresh Kumar
2015-06-17 2:38 ` Viresh Kumar
2015-06-17 9:38 ` Rafael J. Wysocki
2015-06-17 9:38 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqJfWDO4r_FP6xHSxRkMM-pSnbEUB=d9Gj6mhvPY+ouLxA@mail.gmail.com' \
--to=robherring2-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=Sudeep.Holla-5wv7dgnIgG8@public.gmane.org \
--cc=arnd.bergmann-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=kesavan.abhilash-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=khilman-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=linaro-kernel-cunTk1MwBs8s++Sfvej+rw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mike.turquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=nm-l0cyMroinI0@public.gmane.org \
--cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
--cc=rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org \
--cc=sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=ta.omasab-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=viswanath.puttagunta-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.