* [PATCH] agp/uninorth: fix a memleak in create_gatt_table
@ 2015-06-12 6:57 Denis Kirjanov
2015-06-18 14:34 ` Denis Kirjanov
2015-10-12 11:17 ` Michael Ellerman
0 siblings, 2 replies; 9+ messages in thread
From: Denis Kirjanov @ 2015-06-12 6:57 UTC (permalink / raw)
To: benh, mpe; +Cc: linuxppc-dev, Denis Kirjanov
Fix the memory leak in create_gatt_table:
we've lost a kfree on the exit path for the pages array allocated
in uninorth_create_gatt_table
Signed-off-by: Denis Kirjanov <kda@linux-powerpc.org>
---
drivers/char/agp/uninorth-agp.c | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/char/agp/uninorth-agp.c b/drivers/char/agp/uninorth-agp.c
index a56ee9b..0575544 100644
--- a/drivers/char/agp/uninorth-agp.c
+++ b/drivers/char/agp/uninorth-agp.c
@@ -361,6 +361,10 @@ static int agp_uninorth_resume(struct pci_dev *pdev)
}
#endif /* CONFIG_PM */
+static struct {
+ struct page **pages_arr;
+} uninorth_priv;
+
static int uninorth_create_gatt_table(struct agp_bridge_data *bridge)
{
char *table;
@@ -371,7 +375,6 @@ static int uninorth_create_gatt_table(struct agp_bridge_data *bridge)
int i;
void *temp;
struct page *page;
- struct page **pages;
/* We can't handle 2 level gatt's */
if (bridge->driver->size_type == LVL2_APER_SIZE)
@@ -400,8 +403,8 @@ static int uninorth_create_gatt_table(struct agp_bridge_data *bridge)
if (table == NULL)
return -ENOMEM;
- pages = kmalloc((1 << page_order) * sizeof(struct page*), GFP_KERNEL);
- if (pages == NULL)
+ uninorth_priv.pages_arr = kmalloc((1 << page_order) * sizeof(struct page*), GFP_KERNEL);
+ if (uninorth_priv.pages_arr == NULL)
goto enomem;
table_end = table + ((PAGE_SIZE * (1 << page_order)) - 1);
@@ -409,14 +412,14 @@ static int uninorth_create_gatt_table(struct agp_bridge_data *bridge)
for (page = virt_to_page(table), i = 0; page <= virt_to_page(table_end);
page++, i++) {
SetPageReserved(page);
- pages[i] = page;
+ uninorth_priv.pages_arr[i] = page;
}
bridge->gatt_table_real = (u32 *) table;
/* Need to clear out any dirty data still sitting in caches */
flush_dcache_range((unsigned long)table,
(unsigned long)table_end + 1);
- bridge->gatt_table = vmap(pages, (1 << page_order), 0, PAGE_KERNEL_NCG);
+ bridge->gatt_table = vmap(uninorth_priv.pages_arr, (1 << page_order), 0, PAGE_KERNEL_NCG);
if (bridge->gatt_table == NULL)
goto enomem;
@@ -434,7 +437,7 @@ static int uninorth_create_gatt_table(struct agp_bridge_data *bridge)
return 0;
enomem:
- kfree(pages);
+ kfree(uninorth_priv.pages_arr);
if (table)
free_pages((unsigned long)table, page_order);
return -ENOMEM;
@@ -456,6 +459,7 @@ static int uninorth_free_gatt_table(struct agp_bridge_data *bridge)
*/
vunmap(bridge->gatt_table);
+ kfree(uninorth_priv.pages_arr);
table = (char *) bridge->gatt_table_real;
table_end = table + ((PAGE_SIZE * (1 << page_order)) - 1);
--
2.4.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] agp/uninorth: fix a memleak in create_gatt_table
2015-06-12 6:57 [PATCH] agp/uninorth: fix a memleak in create_gatt_table Denis Kirjanov
@ 2015-06-18 14:34 ` Denis Kirjanov
2015-06-19 1:08 ` Benjamin Herrenschmidt
2015-10-12 11:17 ` Michael Ellerman
1 sibling, 1 reply; 9+ messages in thread
From: Denis Kirjanov @ 2015-06-18 14:34 UTC (permalink / raw)
To: benh, mpe; +Cc: linuxppc-dev, Denis Kirjanov, airlied
On 6/12/15, Denis Kirjanov <kda@linux-powerpc.org> wrote:
> Fix the memory leak in create_gatt_table:
> we've lost a kfree on the exit path for the pages array allocated
> in uninorth_create_gatt_table
>
> Signed-off-by: Denis Kirjanov <kda@linux-powerpc.org>
Hi Ben, Michael
Will you take the patch through your trees or do I need to send it to
Dave Airlie?
Thanks
> ---
> drivers/char/agp/uninorth-agp.c | 16 ++++++++++------
> 1 file changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/char/agp/uninorth-agp.c
> b/drivers/char/agp/uninorth-agp.c
> index a56ee9b..0575544 100644
> --- a/drivers/char/agp/uninorth-agp.c
> +++ b/drivers/char/agp/uninorth-agp.c
> @@ -361,6 +361,10 @@ static int agp_uninorth_resume(struct pci_dev *pdev)
> }
> #endif /* CONFIG_PM */
>
> +static struct {
> + struct page **pages_arr;
> +} uninorth_priv;
> +
> static int uninorth_create_gatt_table(struct agp_bridge_data *bridge)
> {
> char *table;
> @@ -371,7 +375,6 @@ static int uninorth_create_gatt_table(struct
> agp_bridge_data *bridge)
> int i;
> void *temp;
> struct page *page;
> - struct page **pages;
>
> /* We can't handle 2 level gatt's */
> if (bridge->driver->size_type == LVL2_APER_SIZE)
> @@ -400,8 +403,8 @@ static int uninorth_create_gatt_table(struct
> agp_bridge_data *bridge)
> if (table == NULL)
> return -ENOMEM;
>
> - pages = kmalloc((1 << page_order) * sizeof(struct page*), GFP_KERNEL);
> - if (pages == NULL)
> + uninorth_priv.pages_arr = kmalloc((1 << page_order) * sizeof(struct
> page*), GFP_KERNEL);
> + if (uninorth_priv.pages_arr == NULL)
> goto enomem;
>
> table_end = table + ((PAGE_SIZE * (1 << page_order)) - 1);
> @@ -409,14 +412,14 @@ static int uninorth_create_gatt_table(struct
> agp_bridge_data *bridge)
> for (page = virt_to_page(table), i = 0; page <= virt_to_page(table_end);
> page++, i++) {
> SetPageReserved(page);
> - pages[i] = page;
> + uninorth_priv.pages_arr[i] = page;
> }
>
> bridge->gatt_table_real = (u32 *) table;
> /* Need to clear out any dirty data still sitting in caches */
> flush_dcache_range((unsigned long)table,
> (unsigned long)table_end + 1);
> - bridge->gatt_table = vmap(pages, (1 << page_order), 0, PAGE_KERNEL_NCG);
> + bridge->gatt_table = vmap(uninorth_priv.pages_arr, (1 << page_order), 0,
> PAGE_KERNEL_NCG);
>
> if (bridge->gatt_table == NULL)
> goto enomem;
> @@ -434,7 +437,7 @@ static int uninorth_create_gatt_table(struct
> agp_bridge_data *bridge)
> return 0;
>
> enomem:
> - kfree(pages);
> + kfree(uninorth_priv.pages_arr);
> if (table)
> free_pages((unsigned long)table, page_order);
> return -ENOMEM;
> @@ -456,6 +459,7 @@ static int uninorth_free_gatt_table(struct
> agp_bridge_data *bridge)
> */
>
> vunmap(bridge->gatt_table);
> + kfree(uninorth_priv.pages_arr);
> table = (char *) bridge->gatt_table_real;
> table_end = table + ((PAGE_SIZE * (1 << page_order)) - 1);
>
> --
> 2.4.0
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] agp/uninorth: fix a memleak in create_gatt_table
2015-06-18 14:34 ` Denis Kirjanov
@ 2015-06-19 1:08 ` Benjamin Herrenschmidt
2015-09-07 7:30 ` Denis Kirjanov
0 siblings, 1 reply; 9+ messages in thread
From: Benjamin Herrenschmidt @ 2015-06-19 1:08 UTC (permalink / raw)
To: Denis Kirjanov; +Cc: mpe, linuxppc-dev, airlied
On Thu, 2015-06-18 at 17:34 +0300, Denis Kirjanov wrote:
> On 6/12/15, Denis Kirjanov <kda@linux-powerpc.org> wrote:
> > Fix the memory leak in create_gatt_table:
> > we've lost a kfree on the exit path for the pages array allocated
> > in uninorth_create_gatt_table
> >
> > Signed-off-by: Denis Kirjanov <kda@linux-powerpc.org>
>
> Hi Ben, Michael
>
> Will you take the patch through your trees or do I need to send it to
> Dave Airlie?
I haven't had a chance to review yet...
Ben.
> Thanks
> > ---
> > drivers/char/agp/uninorth-agp.c | 16 ++++++++++------
> > 1 file changed, 10 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/char/agp/uninorth-agp.c
> > b/drivers/char/agp/uninorth-agp.c
> > index a56ee9b..0575544 100644
> > --- a/drivers/char/agp/uninorth-agp.c
> > +++ b/drivers/char/agp/uninorth-agp.c
> > @@ -361,6 +361,10 @@ static int agp_uninorth_resume(struct pci_dev *pdev)
> > }
> > #endif /* CONFIG_PM */
> >
> > +static struct {
> > + struct page **pages_arr;
> > +} uninorth_priv;
> > +
> > static int uninorth_create_gatt_table(struct agp_bridge_data *bridge)
> > {
> > char *table;
> > @@ -371,7 +375,6 @@ static int uninorth_create_gatt_table(struct
> > agp_bridge_data *bridge)
> > int i;
> > void *temp;
> > struct page *page;
> > - struct page **pages;
> >
> > /* We can't handle 2 level gatt's */
> > if (bridge->driver->size_type == LVL2_APER_SIZE)
> > @@ -400,8 +403,8 @@ static int uninorth_create_gatt_table(struct
> > agp_bridge_data *bridge)
> > if (table == NULL)
> > return -ENOMEM;
> >
> > - pages = kmalloc((1 << page_order) * sizeof(struct page*), GFP_KERNEL);
> > - if (pages == NULL)
> > + uninorth_priv.pages_arr = kmalloc((1 << page_order) * sizeof(struct
> > page*), GFP_KERNEL);
> > + if (uninorth_priv.pages_arr == NULL)
> > goto enomem;
> >
> > table_end = table + ((PAGE_SIZE * (1 << page_order)) - 1);
> > @@ -409,14 +412,14 @@ static int uninorth_create_gatt_table(struct
> > agp_bridge_data *bridge)
> > for (page = virt_to_page(table), i = 0; page <= virt_to_page(table_end);
> > page++, i++) {
> > SetPageReserved(page);
> > - pages[i] = page;
> > + uninorth_priv.pages_arr[i] = page;
> > }
> >
> > bridge->gatt_table_real = (u32 *) table;
> > /* Need to clear out any dirty data still sitting in caches */
> > flush_dcache_range((unsigned long)table,
> > (unsigned long)table_end + 1);
> > - bridge->gatt_table = vmap(pages, (1 << page_order), 0, PAGE_KERNEL_NCG);
> > + bridge->gatt_table = vmap(uninorth_priv.pages_arr, (1 << page_order), 0,
> > PAGE_KERNEL_NCG);
> >
> > if (bridge->gatt_table == NULL)
> > goto enomem;
> > @@ -434,7 +437,7 @@ static int uninorth_create_gatt_table(struct
> > agp_bridge_data *bridge)
> > return 0;
> >
> > enomem:
> > - kfree(pages);
> > + kfree(uninorth_priv.pages_arr);
> > if (table)
> > free_pages((unsigned long)table, page_order);
> > return -ENOMEM;
> > @@ -456,6 +459,7 @@ static int uninorth_free_gatt_table(struct
> > agp_bridge_data *bridge)
> > */
> >
> > vunmap(bridge->gatt_table);
> > + kfree(uninorth_priv.pages_arr);
> > table = (char *) bridge->gatt_table_real;
> > table_end = table + ((PAGE_SIZE * (1 << page_order)) - 1);
> >
> > --
> > 2.4.0
> >
> >
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] agp/uninorth: fix a memleak in create_gatt_table
2015-06-19 1:08 ` Benjamin Herrenschmidt
@ 2015-09-07 7:30 ` Denis Kirjanov
2015-09-07 10:28 ` Michael Ellerman
0 siblings, 1 reply; 9+ messages in thread
From: Denis Kirjanov @ 2015-09-07 7:30 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: mpe, linuxppc-dev, airlied
On 6/19/15, Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> On Thu, 2015-06-18 at 17:34 +0300, Denis Kirjanov wrote:
>> On 6/12/15, Denis Kirjanov <kda@linux-powerpc.org> wrote:
>> > Fix the memory leak in create_gatt_table:
>> > we've lost a kfree on the exit path for the pages array allocated
>> > in uninorth_create_gatt_table
>> >
>> > Signed-off-by: Denis Kirjanov <kda@linux-powerpc.org>
>>
>> Hi Ben, Michael
>>
>> Will you take the patch through your trees or do I need to send it to
>> Dave Airlie?
>
> I haven't had a chance to review yet...
Ping...
>
> Ben.
>
>> Thanks
>> > ---
>> > drivers/char/agp/uninorth-agp.c | 16 ++++++++++------
>> > 1 file changed, 10 insertions(+), 6 deletions(-)
>> >
>> > diff --git a/drivers/char/agp/uninorth-agp.c
>> > b/drivers/char/agp/uninorth-agp.c
>> > index a56ee9b..0575544 100644
>> > --- a/drivers/char/agp/uninorth-agp.c
>> > +++ b/drivers/char/agp/uninorth-agp.c
>> > @@ -361,6 +361,10 @@ static int agp_uninorth_resume(struct pci_dev
>> > *pdev)
>> > }
>> > #endif /* CONFIG_PM */
>> >
>> > +static struct {
>> > + struct page **pages_arr;
>> > +} uninorth_priv;
>> > +
>> > static int uninorth_create_gatt_table(struct agp_bridge_data *bridge)
>> > {
>> > char *table;
>> > @@ -371,7 +375,6 @@ static int uninorth_create_gatt_table(struct
>> > agp_bridge_data *bridge)
>> > int i;
>> > void *temp;
>> > struct page *page;
>> > - struct page **pages;
>> >
>> > /* We can't handle 2 level gatt's */
>> > if (bridge->driver->size_type == LVL2_APER_SIZE)
>> > @@ -400,8 +403,8 @@ static int uninorth_create_gatt_table(struct
>> > agp_bridge_data *bridge)
>> > if (table == NULL)
>> > return -ENOMEM;
>> >
>> > - pages = kmalloc((1 << page_order) * sizeof(struct page*),
>> > GFP_KERNEL);
>> > - if (pages == NULL)
>> > + uninorth_priv.pages_arr = kmalloc((1 << page_order) * sizeof(struct
>> > page*), GFP_KERNEL);
>> > + if (uninorth_priv.pages_arr == NULL)
>> > goto enomem;
>> >
>> > table_end = table + ((PAGE_SIZE * (1 << page_order)) - 1);
>> > @@ -409,14 +412,14 @@ static int uninorth_create_gatt_table(struct
>> > agp_bridge_data *bridge)
>> > for (page = virt_to_page(table), i = 0; page <=
>> > virt_to_page(table_end);
>> > page++, i++) {
>> > SetPageReserved(page);
>> > - pages[i] = page;
>> > + uninorth_priv.pages_arr[i] = page;
>> > }
>> >
>> > bridge->gatt_table_real = (u32 *) table;
>> > /* Need to clear out any dirty data still sitting in caches */
>> > flush_dcache_range((unsigned long)table,
>> > (unsigned long)table_end + 1);
>> > - bridge->gatt_table = vmap(pages, (1 << page_order), 0,
>> > PAGE_KERNEL_NCG);
>> > + bridge->gatt_table = vmap(uninorth_priv.pages_arr, (1 << page_order),
>> > 0,
>> > PAGE_KERNEL_NCG);
>> >
>> > if (bridge->gatt_table == NULL)
>> > goto enomem;
>> > @@ -434,7 +437,7 @@ static int uninorth_create_gatt_table(struct
>> > agp_bridge_data *bridge)
>> > return 0;
>> >
>> > enomem:
>> > - kfree(pages);
>> > + kfree(uninorth_priv.pages_arr);
>> > if (table)
>> > free_pages((unsigned long)table, page_order);
>> > return -ENOMEM;
>> > @@ -456,6 +459,7 @@ static int uninorth_free_gatt_table(struct
>> > agp_bridge_data *bridge)
>> > */
>> >
>> > vunmap(bridge->gatt_table);
>> > + kfree(uninorth_priv.pages_arr);
>> > table = (char *) bridge->gatt_table_real;
>> > table_end = table + ((PAGE_SIZE * (1 << page_order)) - 1);
>> >
>> > --
>> > 2.4.0
>> >
>> >
>
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] agp/uninorth: fix a memleak in create_gatt_table
2015-09-07 7:30 ` Denis Kirjanov
@ 2015-09-07 10:28 ` Michael Ellerman
2015-09-07 10:39 ` Denis Kirjanov
0 siblings, 1 reply; 9+ messages in thread
From: Michael Ellerman @ 2015-09-07 10:28 UTC (permalink / raw)
To: Denis Kirjanov; +Cc: Benjamin Herrenschmidt, linuxppc-dev, airlied
On Mon, 2015-09-07 at 10:30 +0300, Denis Kirjanov wrote:
> On 6/19/15, Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> > On Thu, 2015-06-18 at 17:34 +0300, Denis Kirjanov wrote:
> >> On 6/12/15, Denis Kirjanov <kda@linux-powerpc.org> wrote:
> >> > Fix the memory leak in create_gatt_table:
> >> > we've lost a kfree on the exit path for the pages array allocated
> >> > in uninorth_create_gatt_table
> >> >
> >> > Signed-off-by: Denis Kirjanov <kda@linux-powerpc.org>
> >>
> >> Hi Ben, Michael
> >>
> >> Will you take the patch through your trees or do I need to send it to
> >> Dave Airlie?
> >
> > I haven't had a chance to review yet...
>
> Ping...
Hi Denis,
Have you built and/or boot tested this?
cheers
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] agp/uninorth: fix a memleak in create_gatt_table
2015-09-07 10:28 ` Michael Ellerman
@ 2015-09-07 10:39 ` Denis Kirjanov
2015-09-08 3:51 ` Michael Ellerman
0 siblings, 1 reply; 9+ messages in thread
From: Denis Kirjanov @ 2015-09-07 10:39 UTC (permalink / raw)
To: Michael Ellerman; +Cc: Benjamin Herrenschmidt, linuxppc-dev, airlied
On 9/7/15, Michael Ellerman <mpe@ellerman.id.au> wrote:
> On Mon, 2015-09-07 at 10:30 +0300, Denis Kirjanov wrote:
>> On 6/19/15, Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>> > On Thu, 2015-06-18 at 17:34 +0300, Denis Kirjanov wrote:
>> >> On 6/12/15, Denis Kirjanov <kda@linux-powerpc.org> wrote:
>> >> > Fix the memory leak in create_gatt_table:
>> >> > we've lost a kfree on the exit path for the pages array allocated
>> >> > in uninorth_create_gatt_table
>> >> >
>> >> > Signed-off-by: Denis Kirjanov <kda@linux-powerpc.org>
>> >>
>> >> Hi Ben, Michael
>> >>
>> >> Will you take the patch through your trees or do I need to send it to
>> >> Dave Airlie?
>> >
>> > I haven't had a chance to review yet...
>>
>> Ping...
>
> Hi Denis,
>
> Have you built and/or boot tested this?
>
Hi,
yes, sure. Actually I've spotted this through the kmemleak. With the
patch applied scanner is happy :)
> cheers
>
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] agp/uninorth: fix a memleak in create_gatt_table
2015-09-07 10:39 ` Denis Kirjanov
@ 2015-09-08 3:51 ` Michael Ellerman
2015-10-02 8:48 ` Denis Kirjanov
0 siblings, 1 reply; 9+ messages in thread
From: Michael Ellerman @ 2015-09-08 3:51 UTC (permalink / raw)
To: Denis Kirjanov; +Cc: Benjamin Herrenschmidt, linuxppc-dev, airlied
On Mon, 2015-09-07 at 13:39 +0300, Denis Kirjanov wrote:
> On 9/7/15, Michael Ellerman <mpe@ellerman.id.au> wrote:
> > On Mon, 2015-09-07 at 10:30 +0300, Denis Kirjanov wrote:
> >> On 6/19/15, Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> >> > On Thu, 2015-06-18 at 17:34 +0300, Denis Kirjanov wrote:
> >> >> On 6/12/15, Denis Kirjanov <kda@linux-powerpc.org> wrote:
> >> >> > Fix the memory leak in create_gatt_table:
> >> >> > we've lost a kfree on the exit path for the pages array allocated
> >> >> > in uninorth_create_gatt_table
> >> >> >
> >> >> > Signed-off-by: Denis Kirjanov <kda@linux-powerpc.org>
> >> >>
> >> >> Hi Ben, Michael
> >> >>
> >> >> Will you take the patch through your trees or do I need to send it to
> >> >> Dave Airlie?
> >> >
> >> > I haven't had a chance to review yet...
> >>
> >> Ping...
> >
> > Hi Denis,
> >
> > Have you built and/or boot tested this?
>
> Hi,
>
> yes, sure. Actually I've spotted this through the kmemleak. With the
> patch applied scanner is happy :)
OK thanks. I'll merge it then, and if Ben ever reviews it and dislikes your
changes he can send patches to fix it :)
cheers
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] agp/uninorth: fix a memleak in create_gatt_table
2015-09-08 3:51 ` Michael Ellerman
@ 2015-10-02 8:48 ` Denis Kirjanov
0 siblings, 0 replies; 9+ messages in thread
From: Denis Kirjanov @ 2015-10-02 8:48 UTC (permalink / raw)
To: Michael Ellerman; +Cc: Benjamin Herrenschmidt, linuxppc-dev, airlied
On 9/8/15, Michael Ellerman <mpe@ellerman.id.au> wrote:
> On Mon, 2015-09-07 at 13:39 +0300, Denis Kirjanov wrote:
>> On 9/7/15, Michael Ellerman <mpe@ellerman.id.au> wrote:
>> > On Mon, 2015-09-07 at 10:30 +0300, Denis Kirjanov wrote:
>> >> On 6/19/15, Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>> >> > On Thu, 2015-06-18 at 17:34 +0300, Denis Kirjanov wrote:
>> >> >> On 6/12/15, Denis Kirjanov <kda@linux-powerpc.org> wrote:
>> >> >> > Fix the memory leak in create_gatt_table:
>> >> >> > we've lost a kfree on the exit path for the pages array allocated
>> >> >> > in uninorth_create_gatt_table
>> >> >> >
>> >> >> > Signed-off-by: Denis Kirjanov <kda@linux-powerpc.org>
>> >> >>
>> >> >> Hi Ben, Michael
>> >> >>
>> >> >> Will you take the patch through your trees or do I need to send it
>> >> >> to
>> >> >> Dave Airlie?
>> >> >
>> >> > I haven't had a chance to review yet...
>> >>
>> >> Ping...
>> >
>> > Hi Denis,
>> >
>> > Have you built and/or boot tested this?
>>
>> Hi,
>>
>> yes, sure. Actually I've spotted this through the kmemleak. With the
>> patch applied scanner is happy :)
>
> OK thanks. I'll merge it then, and if Ben ever reviews it and dislikes your
> changes he can send patches to fix it :)
Hi Michael,
could you please apply the patch to fixes branch?
Thanks!
>
> cheers
>
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: agp/uninorth: fix a memleak in create_gatt_table
2015-06-12 6:57 [PATCH] agp/uninorth: fix a memleak in create_gatt_table Denis Kirjanov
2015-06-18 14:34 ` Denis Kirjanov
@ 2015-10-12 11:17 ` Michael Ellerman
1 sibling, 0 replies; 9+ messages in thread
From: Michael Ellerman @ 2015-10-12 11:17 UTC (permalink / raw)
To: Denis Kirjanov, benh; +Cc: Denis Kirjanov, linuxppc-dev
On Fri, 2015-12-06 at 06:57:11 UTC, Denis Kirjanov wrote:
> Fix the memory leak in create_gatt_table:
> we've lost a kfree on the exit path for the pages array allocated
> in uninorth_create_gatt_table
>
> Signed-off-by: Denis Kirjanov <kda@linux-powerpc.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/5ada62b1070a57562664713b
cheers
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2015-10-12 11:17 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-12 6:57 [PATCH] agp/uninorth: fix a memleak in create_gatt_table Denis Kirjanov
2015-06-18 14:34 ` Denis Kirjanov
2015-06-19 1:08 ` Benjamin Herrenschmidt
2015-09-07 7:30 ` Denis Kirjanov
2015-09-07 10:28 ` Michael Ellerman
2015-09-07 10:39 ` Denis Kirjanov
2015-09-08 3:51 ` Michael Ellerman
2015-10-02 8:48 ` Denis Kirjanov
2015-10-12 11:17 ` Michael Ellerman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.