From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: outreachy-kernel@googlegroups.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Matthew Wilcox <willy@infradead.org>,
Julia Lawall <julia.lawall@inria.fr>
Subject: Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: Remove useless led_blink_hdl()
Date: Wed, 14 Apr 2021 17:36:54 +0200 [thread overview]
Message-ID: <4318909.BRL0aILv4p@linux.local> (raw)
In-Reply-To: <20210414132414.GE6048@kadam>
On Wednesday, April 14, 2021 3:24:14 PM CEST Dan Carpenter wrote:
> On Wed, Apr 14, 2021 at 01:52:43PM +0200, Fabio M. De Francesco wrote:
> > Removed the led_blink_hdl() function (declaration and definition).
> > Declared dummy_function() in include/rtw_mlme_ext.h and defined it in
> > core/rtw_cmd.c. Changed the second parameter of GEN_MLME_EXT_HANDLER
> > macro to make use of dummy_function().
> >
> > Reported-by: Julia Lawall <julia.lawall@inria.fr>
> > Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > ---
> >
> > drivers/staging/rtl8723bs/core/rtw_cmd.c | 4 +++-
> > drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 9 ---------
> > drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 3 ++-
> > 3 files changed, 5 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> > b/drivers/staging/rtl8723bs/core/rtw_cmd.c index
> > 0297fbad7bce..7b6102a2bb2c 100644
> > --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> > +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> > @@ -87,6 +87,8 @@ static struct _cmd_callback rtw_cmd_callback[] = {
> >
> > {GEN_CMD_CODE(_RunInThreadCMD), NULL},/*64*/
> >
> > };
> >
> > +u8 dummy_functioni(struct adapter *var0, u8 *var1) { return 0; }
> > +
> >
> > static struct cmd_hdl wlancmds[] = {
> >
> > GEN_DRV_CMD_HANDLER(0, NULL) /*0*/
> > GEN_DRV_CMD_HANDLER(0, NULL)
> >
> > @@ -150,7 +152,7 @@ static struct cmd_hdl wlancmds[] = {
> >
> > GEN_MLME_EXT_HANDLER(0, h2c_msg_hdl) /*58*/
> > GEN_MLME_EXT_HANDLER(sizeof(struct SetChannelPlan_param),
> > set_chplan_hdl) /*59*/>
> > - GEN_MLME_EXT_HANDLER(sizeof(struct LedBlink_param),
led_blink_hdl)
> > /*60*/ + GEN_MLME_EXT_HANDLER(sizeof(struct LedBlink_param),
> > dummy_function) /*60*/
> No, no. Don't create a dummy function. Do it like so:
>
> GEN_DRV_CMD_HANDLER(0, NULL) /* 60 */
>
> regards,
> dan carpenter
>
I'm replying late because I didn't want to blindly use that solution; I
mean that I wanted to understand why I can simply put 0 and NULL into that
macro. I had seen it made in other lines that initialize wlancmds[]
elements, but I wasn't sure if it could work for the specific slot where
the pointer to led_blinck_hdl was supposed to be placed.
Now I think that it is why, in this case, cmd_hdl would be set to NULL by
the call to wlancmds[pcmd->cmdcode].h2cfuns and the cmd_hdl() function
wouldn't be called because cmd_hdl is tested within an "if" statement.
Therefore a simple GEN_DRV_CMD_HANDLER(0, NULL) at slot number would be the
simplest and most obvious solution.
Is the above argument sound?
Thanks for your kind help,
Fabio
next prev parent reply other threads:[~2021-04-14 15:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 11:52 [Outreachy kernel] [PATCH] staging: rtl8723bs: Remove useless led_blink_hdl() Fabio M. De Francesco
2021-04-14 12:00 ` Fabio Aiuto
2021-04-14 12:18 ` Greg Kroah-Hartman
2021-04-14 13:27 ` Fabio M. De Francesco
2021-04-14 13:24 ` Dan Carpenter
2021-04-14 15:36 ` Fabio M. De Francesco [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-04-13 15:59 [Outreachy kernel] [PATCH] :staging: " Fabio M. De Francesco
2021-04-13 16:04 ` Julia Lawall
2021-04-13 16:19 ` Fabio M. De Francesco
2021-04-13 16:27 ` Julia Lawall
2021-04-13 16:47 ` Fabio M. De Francesco
2021-04-13 18:20 ` Dan Carpenter
2021-04-13 18:30 ` Fabio M. De Francesco
2021-04-13 18:57 ` Julia Lawall
2021-04-13 19:16 ` Fabio M. De Francesco
2021-04-13 19:25 ` Julia Lawall
2021-04-13 19:45 ` Fabio M. De Francesco
2021-04-13 19:48 ` Matthew Wilcox
2021-04-13 20:08 ` Fabio M. De Francesco
2021-04-14 5:21 ` Dan Carpenter
2021-04-14 6:33 ` Fabio M. De Francesco
2021-04-14 7:00 ` Dan Carpenter
2021-04-14 7:59 ` Fabio M. De Francesco
2021-04-14 8:06 ` Dan Carpenter
2021-04-14 7:40 ` Fabio Aiuto
2021-04-14 7:47 ` Dan Carpenter
2021-04-13 16:06 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4318909.BRL0aILv4p@linux.local \
--to=fmdefrancesco@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy-kernel@googlegroups.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).