From: Julia Lawall <julia.lawall@inria.fr>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
outreachy-kernel@googlegroups.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [Outreachy kernel] [PATCH] :staging: rtl8723bs: Remove useless led_blink_hdl()
Date: Tue, 13 Apr 2021 20:57:20 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2104132056470.14108@hadrien> (raw)
In-Reply-To: <4666345.5ezhEZ0rgB@linux.local>
On Tue, 13 Apr 2021, Fabio M. De Francesco wrote:
> On Tuesday, April 13, 2021 8:20:50 PM CEST Dan Carpenter wrote:
> > On Tue, Apr 13, 2021 at 06:47:06PM +0200, Fabio M. De Francesco wrote:
> > > On Tuesday, April 13, 2021 6:27:17 PM CEST Julia Lawall wrote:
> > > > On Tue, 13 Apr 2021, Fabio M. De Francesco wrote:
> > > > > On Tuesday, April 13, 2021 6:04:16 PM CEST Julia Lawall wrote:
> > > > > > On Tue, 13 Apr 2021, Fabio M. De Francesco wrote:
> > > > > > > Removed the led_blink_hdl() function (declaration, definition,
> > > > > > > and
> > > > > > > caller code) because it's useless. It only seems to check
> > > > > > > whether
> > > > > > > or
> > > > > > > not a given pointer is NULL. There are other (simpler) means
> > > > > > > for
> > > > > > > that
> > > > > > > purpose.
> > > > > > >
> > > > > > > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > > > > > > ---
> > > > > > >
> > > > > > > drivers/staging/rtl8723bs/core/rtw_cmd.c | 1 -
> > > > > > > drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 9 ---------
> > > > > > > drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 1 -
> > > > > > > 3 files changed, 11 deletions(-)
> > > > > > >
> > > > > > > diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> > > > > > > b/drivers/staging/rtl8723bs/core/rtw_cmd.c index
> > > > > > > 0297fbad7bce..4c44dfd21514 100644
> > > > > > > --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> > > > > > > +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> > > > > > > @@ -150,7 +150,6 @@ static struct cmd_hdl wlancmds[] = {
> > > > > > >
> > > > > > > GEN_MLME_EXT_HANDLER(0, h2c_msg_hdl) /*58*/
> > > > > > > GEN_MLME_EXT_HANDLER(sizeof(struct SetChannelPlan_param),
> > > > > > > set_chplan_hdl) /*59*/>
> > > > > > >
> > > > > > > - GEN_MLME_EXT_HANDLER(sizeof(struct LedBlink_param),
> > > > >
> > > > > led_blink_hdl)
> > > > >
> > > > > > > /*60*/
> > > > > >
> > > > > > This is worrisome. Doyou fully understand the impact of this?
> > > > > > If
> > > > > > not,
> > > > > > the change is probably not a good idea.
> > > > >
> > > > > This is that macro definition:
> > > > >
> > > > > #define GEN_MLME_EXT_HANDLER(size, cmd) {size, cmd},
> > > > >
> > > > > struct C2HEvent_Header {
> > > > >
> > > > > #ifdef __LITTLE_ENDIAN
> > > > >
> > > > > unsigned int len:16;
> > > > > unsigned int ID:8;
> > > > > unsigned int seq:8;
> > > > >
> > > > > #else
> > > > >
> > > > > unsigned int seq:8;
> > > > > unsigned int ID:8;
> > > > > unsigned int len:16;
> > > > >
> > > > > #endif
> > > > >
> > > > > unsigned int rsvd;
> > > > >
> > > > > };
> > > > >
> > > > > It's a bit convoluted with regard to my experience. Probably I
> > > > > don't
> > > > > understand it fully, but it seems to me to not having effects to
> > > > > the
> > > > > code where I removed its use within core/rtw_cmd.c.
> > > > >
> > > > > What am I missing?
> > > >
> > > > It seems that the function is being put into an array. Probably
> > > > someone
> > > > expects to find it there. Probably you have shifted all of the
> > > > functions that come afterwards back one slot so that they are all in
> > > > the wrong places.
> > > >
> > > > julia
> > >
> > > Thanks for your explanation. Obviously this implies that the function
> > > cannot be removed, unless one fill the slot that is deleted by to not
> > > calling this macro at the right moment.
> > >
> > > I also suppose that providing a function pointer with a NULL value
> > > wouldn't work either.
> >
> > It would work. That array is full of NULL function pointers.
> >
> Interesting, thanks.
>
> I'm going to remove that function and replace its name in the macro with a
> NULL function pointer.
>
> I couldn't believe it would work when I wrote about that.
Have you checked that a value of NULL in that place is going to have the
same effect as the function?
julia
next prev parent reply other threads:[~2021-04-13 18:57 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 15:59 [Outreachy kernel] [PATCH] :staging: rtl8723bs: Remove useless led_blink_hdl() Fabio M. De Francesco
2021-04-13 16:04 ` Julia Lawall
2021-04-13 16:19 ` Fabio M. De Francesco
2021-04-13 16:27 ` Julia Lawall
2021-04-13 16:47 ` Fabio M. De Francesco
2021-04-13 18:20 ` Dan Carpenter
2021-04-13 18:30 ` Fabio M. De Francesco
2021-04-13 18:57 ` Julia Lawall [this message]
2021-04-13 19:16 ` Fabio M. De Francesco
2021-04-13 19:25 ` Julia Lawall
2021-04-13 19:45 ` Fabio M. De Francesco
2021-04-13 19:48 ` Matthew Wilcox
2021-04-13 20:08 ` Fabio M. De Francesco
2021-04-14 5:21 ` Dan Carpenter
2021-04-14 6:33 ` Fabio M. De Francesco
2021-04-14 7:00 ` Dan Carpenter
2021-04-14 7:59 ` Fabio M. De Francesco
2021-04-14 8:06 ` Dan Carpenter
2021-04-14 7:40 ` Fabio Aiuto
2021-04-14 7:47 ` Dan Carpenter
2021-04-13 16:06 ` Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2021-04-14 11:52 [Outreachy kernel] [PATCH] staging: " Fabio M. De Francesco
2021-04-14 12:00 ` Fabio Aiuto
2021-04-14 12:18 ` Greg Kroah-Hartman
2021-04-14 13:27 ` Fabio M. De Francesco
2021-04-14 13:24 ` Dan Carpenter
2021-04-14 15:36 ` Fabio M. De Francesco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2104132056470.14108@hadrien \
--to=julia.lawall@inria.fr \
--cc=dan.carpenter@oracle.com \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).