From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: outreachy-kernel@googlegroups.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
Matthew Wilcox <willy@infradead.org>,
Julia Lawall <julia.lawall@inria.fr>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: Remove useless led_blink_hdl()
Date: Wed, 14 Apr 2021 14:18:13 +0200 [thread overview]
Message-ID: <YHbdhT8z11rd6okI@kroah.com> (raw)
In-Reply-To: <20210414115243.32716-1-fmdefrancesco@gmail.com>
On Wed, Apr 14, 2021 at 01:52:43PM +0200, Fabio M. De Francesco wrote:
> Removed the led_blink_hdl() function (declaration and definition).
> Declared dummy_function() in include/rtw_mlme_ext.h and defined it in
> core/rtw_cmd.c. Changed the second parameter of GEN_MLME_EXT_HANDLER
> macro to make use of dummy_function().
No no no.
If you want to remove is function declaration and use, then do it
properly.
The code is crazy, I agree, but it should not be difficult to just
remove this correctly instead of papering over this mess.
Also note that no one actually calls this function if you look at the
logic here. It might take some good knowledge of C to unwind this crud,
but once done, you should be able to "prove" it's not called and how to
remove it correctly.
And no, I'm not going to say how to do it, that's an exercise best left
for the reader. But I will hint that this was done in the past, in
2014, in another driver in the tree with a codebase much like this one,
so it shouldn't be hard to find an example of it. Only took me a few
minutes...
good luck!
greg k-h
next prev parent reply other threads:[~2021-04-14 12:18 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 11:52 [Outreachy kernel] [PATCH] staging: rtl8723bs: Remove useless led_blink_hdl() Fabio M. De Francesco
2021-04-14 12:00 ` Fabio Aiuto
2021-04-14 12:18 ` Greg Kroah-Hartman [this message]
2021-04-14 13:27 ` Fabio M. De Francesco
2021-04-14 13:24 ` Dan Carpenter
2021-04-14 15:36 ` Fabio M. De Francesco
-- strict thread matches above, loose matches on Subject: below --
2021-04-13 15:59 [Outreachy kernel] [PATCH] :staging: " Fabio M. De Francesco
2021-04-13 16:04 ` Julia Lawall
2021-04-13 16:19 ` Fabio M. De Francesco
2021-04-13 16:27 ` Julia Lawall
2021-04-13 16:47 ` Fabio M. De Francesco
2021-04-13 18:20 ` Dan Carpenter
2021-04-13 18:30 ` Fabio M. De Francesco
2021-04-13 18:57 ` Julia Lawall
2021-04-13 19:16 ` Fabio M. De Francesco
2021-04-13 19:25 ` Julia Lawall
2021-04-13 19:45 ` Fabio M. De Francesco
2021-04-13 19:48 ` Matthew Wilcox
2021-04-13 20:08 ` Fabio M. De Francesco
2021-04-14 5:21 ` Dan Carpenter
2021-04-14 6:33 ` Fabio M. De Francesco
2021-04-14 7:00 ` Dan Carpenter
2021-04-14 7:59 ` Fabio M. De Francesco
2021-04-14 8:06 ` Dan Carpenter
2021-04-14 7:40 ` Fabio Aiuto
2021-04-14 7:47 ` Dan Carpenter
2021-04-13 16:06 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHbdhT8z11rd6okI@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@oracle.com \
--cc=fmdefrancesco@gmail.com \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy-kernel@googlegroups.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).