* [PATCH v10 0/2] mfd: act8945a: add Active-semi ACT8945A PMIC MFD driver
@ 2016-02-05 3:36 Wenyou Yang
2016-02-05 3:36 ` [PATCH v10 1/2] " Wenyou Yang
2016-02-05 3:36 ` [PATCH v10 2/2] mfd: add documentation for ACT8945A DT bindings Wenyou Yang
0 siblings, 2 replies; 5+ messages in thread
From: Wenyou Yang @ 2016-02-05 3:36 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Pawel Moll, Mark Brown, Ian Campbell,
Kumar Gala
Cc: Javier Martinez Canillas, Krzysztof Kozlowski, Peter Korsgaard,
Nicolas Ferre, linux-arm-kernel, linux-kernel, devicetree,
Wenyou Yang
This patch set adds support for the Active-semi ACT8945A PMIC
MFD driver. It is a Multi Function Device with the following
subdevices:
- Regulator
- Charger
It is interfaced to the host controller using I2C interface,
ACT8945A is a child device of the I2C.
Changes in v10:
- remove the mfd cell .of_compatible.
- update the example, due to the subdevices are not regarded as
a child node.
Changes in v9:
- remove unneeded struct act8945a_dev structure.
- collect Acked from Lee.
- collect Acked from Peter.
Changes in v8:
- change the subdevice's name "act8945a-pmic" to "act8945a-regulator".
Changes in v7:
- remove struct act8945a_dev to .c file.
- remove unused .h file.
- collect Acked-by from Lee Jones
Changes in v6:
- change MFD_ACT8945A type from bool to tristate.
- revert depends on to 'I2C'.
- change the regulator name.
Changes in v5:
- change depends on to 'I2C=y'.
Changes in v4:
- add a space before .compatible.
- collect Reviewed-by from Krzysztof Kozlowski.
Changes in v3:
- fix the tabbing errors in Example.
- use "pmic@5b" label, not "act8945a@5b" in Example.
- collect Acked-by from Rob.
Changes in v2:
- add more help information in Kconfig.
- update the file header with short version license and author line.
- remove unused structure members (dev, i2c_client) of stuct act8945a_dev.
- use define "PLATFORM_DEVID_NONE" for mfd_add_devices(), instead of '-1'.
- use more explicit info to indicate the failure to add sub devices.
- remove the unnecessary print out.
- substitute MODULE_LICENSE("GPL") for MODULE_LICENSE("GPL v2").
- use more specific label in Example.
- add pmic and charger nodes in Example.
Wenyou Yang (2):
mfd: act8945a: add Active-semi ACT8945A PMIC MFD driver
mfd: add documentation for ACT8945A DT bindings
Documentation/devicetree/bindings/mfd/act8945a.txt | 76 +++++++++++++++
drivers/mfd/Kconfig | 11 +++
drivers/mfd/Makefile | 1 +
drivers/mfd/act8945a.c | 102 ++++++++++++++++++++
4 files changed, 190 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mfd/act8945a.txt
create mode 100644 drivers/mfd/act8945a.c
--
1.7.9.5
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v10 1/2] mfd: act8945a: add Active-semi ACT8945A PMIC MFD driver
2016-02-05 3:36 [PATCH v10 0/2] mfd: act8945a: add Active-semi ACT8945A PMIC MFD driver Wenyou Yang
@ 2016-02-05 3:36 ` Wenyou Yang
2016-02-10 16:55 ` Lee Jones
2016-02-05 3:36 ` [PATCH v10 2/2] mfd: add documentation for ACT8945A DT bindings Wenyou Yang
1 sibling, 1 reply; 5+ messages in thread
From: Wenyou Yang @ 2016-02-05 3:36 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Pawel Moll, Mark Brown, Ian Campbell,
Kumar Gala
Cc: Javier Martinez Canillas, Krzysztof Kozlowski, Peter Korsgaard,
Nicolas Ferre, linux-arm-kernel, linux-kernel, devicetree,
Wenyou Yang
This patch adds support for the Active-semi ACT8945A PMIC.
It is a Multi Function Device with the following subdevices:
- Regulator
- Charger
It is interfaced to the host controller using I2C interface,
ACT8945A is a child device of the I2C.
Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Acked-by: Lee Jones <lee.jones@linaro.org>
Acked-by: Peter Korsgaard <peter@korsgaard.com>
---
Changes in v10:
- remove the mfd cell .of_compatible.
Changes in v9:
- remove unneeded struct act8945a_dev structure.
- collect Acked from Lee.
- collect Acked from Peter.
Changes in v8:
- change the subdevice's name "act8945a-pmic" to "act8945a-regulator".
Changes in v7:
- remove struct act8945a_dev to .c file.
- remove unused .h file.
Changes in v6:
- change MFD_ACT8945A type from bool to tristate.
- revert depends on to 'I2C'.
Changes in v5:
- change depends on to 'I2C=y'.
Changes in v4:
- add a space before .compatible.
- collect Reviewed-by from Krzysztof Kozlowski.
Changes in v3: None
Changes in v2:
- add more help information in Kconfig.
- update the file header with short version license and author line.
- remove unused structure members (dev, i2c_client) of stuct act8945a_dev.
- use define "PLATFORM_DEVID_NONE" for mfd_add_devices(), instead of '-1'.
- use more explicit info to indicate the failure to add sub devices.
- remove the unnecessary print out.
- substitute MODULE_LICENSE("GPL") for MODULE_LICENSE("GPL v2").
drivers/mfd/Kconfig | 11 ++++++
drivers/mfd/Makefile | 1 +
drivers/mfd/act8945a.c | 102 ++++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 114 insertions(+)
create mode 100644 drivers/mfd/act8945a.c
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 6c4ebd9..38994bb 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -18,6 +18,17 @@ config MFD_CS5535
This is the core driver for CS5535/CS5536 MFD functions. This is
necessary for using the board's GPIO and MFGPT functionality.
+config MFD_ACT8945A
+ tristate "Active-semi ACT8945A"
+ select MFD_CORE
+ select REGMAP_I2C
+ depends on I2C && OF
+ help
+ Support for the ACT8945A PMIC from Active-semi. This device
+ features three step-down DC/DC converters and four low-dropout
+ linear regulators, along with a complete ActivePath battery
+ charger.
+
config MFD_AS3711
bool "AMS AS3711"
select MFD_CORE
diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
index 0f230a6..2f1ca82 100644
--- a/drivers/mfd/Makefile
+++ b/drivers/mfd/Makefile
@@ -6,6 +6,7 @@
obj-$(CONFIG_MFD_88PM860X) += 88pm860x.o
obj-$(CONFIG_MFD_88PM800) += 88pm800.o 88pm80x.o
obj-$(CONFIG_MFD_88PM805) += 88pm805.o 88pm80x.o
+obj-$(CONFIG_MFD_ACT8945A) += act8945a.o
obj-$(CONFIG_MFD_SM501) += sm501.o
obj-$(CONFIG_MFD_ASIC3) += asic3.o tmio_core.o
obj-$(CONFIG_MFD_BCM590XX) += bcm590xx.o
diff --git a/drivers/mfd/act8945a.c b/drivers/mfd/act8945a.c
new file mode 100644
index 0000000..525b546
--- /dev/null
+++ b/drivers/mfd/act8945a.c
@@ -0,0 +1,102 @@
+/*
+ * MFD driver for Active-semi ACT8945a PMIC
+ *
+ * Copyright (C) 2015 Atmel Corporation.
+ *
+ * Author: Wenyou Yang <wenyou.yang@atmel.com>
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License as published by the
+ * Free Software Foundation; either version 2 of the License, or (at your
+ * option) any later version.
+ */
+
+#include <linux/i2c.h>
+#include <linux/mfd/core.h>
+#include <linux/module.h>
+#include <linux/of_device.h>
+#include <linux/regmap.h>
+
+static const struct mfd_cell act8945a_devs[] = {
+ {
+ .name = "act8945a-regulator",
+ },
+ {
+ .name = "act8945a-charger",
+ },
+};
+
+static const struct regmap_config act8945a_regmap_config = {
+ .reg_bits = 8,
+ .val_bits = 8,
+};
+
+static int act8945a_i2c_probe(struct i2c_client *i2c,
+ const struct i2c_device_id *id)
+{
+ int ret;
+ struct regmap *regmap;
+
+ regmap = devm_regmap_init_i2c(i2c, &act8945a_regmap_config);
+ if (IS_ERR(regmap)) {
+ ret = PTR_ERR(regmap);
+ dev_err(&i2c->dev, "regmap init failed: %d\n", ret);
+ return ret;
+ }
+
+ i2c_set_clientdata(i2c, regmap);
+
+ ret = mfd_add_devices(&i2c->dev, PLATFORM_DEVID_NONE, act8945a_devs,
+ ARRAY_SIZE(act8945a_devs), NULL, 0, NULL);
+ if (ret) {
+ dev_err(&i2c->dev, "Failed to add sub devices\n");
+ return ret;
+ }
+
+ return 0;
+}
+
+static int act8945a_i2c_remove(struct i2c_client *i2c)
+{
+ mfd_remove_devices(&i2c->dev);
+
+ return 0;
+}
+
+static const struct i2c_device_id act8945a_i2c_id[] = {
+ { "act8945a", 0 },
+ {}
+};
+MODULE_DEVICE_TABLE(i2c, act8945a_i2c_id);
+
+static const struct of_device_id act8945a_of_match[] = {
+ { .compatible = "active-semi,act8945a", },
+ {},
+};
+MODULE_DEVICE_TABLE(of, act8945a_of_match);
+
+static struct i2c_driver act8945a_i2c_driver = {
+ .driver = {
+ .name = "act8945a",
+ .of_match_table = of_match_ptr(act8945a_of_match),
+ },
+ .probe = act8945a_i2c_probe,
+ .remove = act8945a_i2c_remove,
+ .id_table = act8945a_i2c_id,
+};
+
+static int __init act8945a_i2c_init(void)
+{
+ return i2c_add_driver(&act8945a_i2c_driver);
+}
+subsys_initcall(act8945a_i2c_init);
+
+static void __exit act8945a_i2c_exit(void)
+{
+ i2c_del_driver(&act8945a_i2c_driver);
+}
+module_exit(act8945a_i2c_exit);
+
+MODULE_DESCRIPTION("ACT8945A PMIC multi-function driver");
+MODULE_AUTHOR("Wenyou Yang <wenyou.yang@atmel.com>");
+MODULE_LICENSE("GPL");
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v10 2/2] mfd: add documentation for ACT8945A DT bindings
2016-02-05 3:36 [PATCH v10 0/2] mfd: act8945a: add Active-semi ACT8945A PMIC MFD driver Wenyou Yang
2016-02-05 3:36 ` [PATCH v10 1/2] " Wenyou Yang
@ 2016-02-05 3:36 ` Wenyou Yang
2016-02-10 16:55 ` Lee Jones
1 sibling, 1 reply; 5+ messages in thread
From: Wenyou Yang @ 2016-02-05 3:36 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Pawel Moll, Mark Brown, Ian Campbell,
Kumar Gala
Cc: Javier Martinez Canillas, Krzysztof Kozlowski, Peter Korsgaard,
Nicolas Ferre, linux-arm-kernel, linux-kernel, devicetree,
Wenyou Yang
The Active-semi ACT8945A PMIC is a Multi-Function Device, it has
two subdevices:
- Regulator
- Charger
This patch adds documentation for ACT8945A DT bindings.
Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
Acked-by: Rob Herring <robh@kernel.org>
Acked-by: Lee Jones <lee.jones@linaro.org>
---
Changes in v10:
- update the example, due to the subdevices are not regarded as
a child node.
Changes in v9: None
Changes in v8: None
Changes in v7:
- collect Acked-by from Lee Jones
Changes in v6:
- change the regulator name.
Changes in v5: None
Changes in v4: None
Changes in v3:
- fix the tabbing errors in Example.
- use "pmic@5b" label, not "act8945a@5b" in Example.
- collect Acked-by from Rob.
Changes in v2:
- use more specific label in Example.
- add pmic and charger nodes in Example.
Documentation/devicetree/bindings/mfd/act8945a.txt | 76 ++++++++++++++++++++
1 file changed, 76 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mfd/act8945a.txt
diff --git a/Documentation/devicetree/bindings/mfd/act8945a.txt b/Documentation/devicetree/bindings/mfd/act8945a.txt
new file mode 100644
index 0000000..f712830
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/act8945a.txt
@@ -0,0 +1,76 @@
+Device-Tree bindings for Active-semi ACT8945A MFD driver
+
+Required properties:
+ - compatible: "active-semi,act8945a".
+ - reg: the I2C slave address for the ACT8945A chip
+
+The chip exposes two subdevices:
+ - a regulators: see ../regulator/act8945a-regulator.txt
+ - a charger: see ../power/act8945a-charger.txt
+
+Example:
+ pmic@5b {
+ compatible = "active-semi,act8945a";
+ reg = <0x5b>;
+ status = "okay";
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_charger_chglev>;
+ active-semi,chglev-gpio = <&pioA 12 GPIO_ACTIVE_HIGH>;
+ active-semi,input-voltage-threshold-microvolt = <6600>;
+ active-semi,precondition-timeout = <40>;
+ active-semi,total-timeout = <3>;
+
+ active-semi,vsel-high;
+
+ regulators {
+ vdd_1v35_reg: REG_DCDC1 {
+ regulator-name = "VDD_1V35";
+ regulator-min-microvolt = <1350000>;
+ regulator-max-microvolt = <1350000>;
+ regulator-always-on;
+ };
+
+ vdd_1v2_reg: REG_DCDC2 {
+ regulator-name = "VDD_1V2";
+ regulator-min-microvolt = <1100000>;
+ regulator-max-microvolt = <1300000>;
+ regulator-always-on;
+ };
+
+ vdd_3v3_reg: REG_DCDC3 {
+ regulator-name = "VDD_3V3";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-always-on;
+ };
+
+ vdd_fuse_reg: REG_LDO1 {
+ regulator-name = "VDD_FUSE";
+ regulator-min-microvolt = <2500000>;
+ regulator-max-microvolt = <2500000>;
+ regulator-always-on;
+ };
+
+ vdd_3v3_lp_reg: REG_LDO2 {
+ regulator-name = "VDD_3V3_LP";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-always-on;
+ };
+
+ vdd_led_reg: REG_LDO3 {
+ regulator-name = "VDD_LED";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-always-on;
+ };
+
+ vdd_sdhc_1v8_reg: REG_LDO4 {
+ regulator-name = "VDD_SDHC_1V8";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ };
+ };
+ };
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v10 1/2] mfd: act8945a: add Active-semi ACT8945A PMIC MFD driver
2016-02-05 3:36 ` [PATCH v10 1/2] " Wenyou Yang
@ 2016-02-10 16:55 ` Lee Jones
0 siblings, 0 replies; 5+ messages in thread
From: Lee Jones @ 2016-02-10 16:55 UTC (permalink / raw)
To: Wenyou Yang
Cc: Rob Herring, Pawel Moll, Mark Brown, Ian Campbell, Kumar Gala,
Javier Martinez Canillas, Krzysztof Kozlowski, Peter Korsgaard,
Nicolas Ferre, linux-arm-kernel, linux-kernel, devicetree
On Fri, 05 Feb 2016, Wenyou Yang wrote:
> This patch adds support for the Active-semi ACT8945A PMIC.
> It is a Multi Function Device with the following subdevices:
> - Regulator
> - Charger
>
> It is interfaced to the host controller using I2C interface,
> ACT8945A is a child device of the I2C.
>
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Acked-by: Lee Jones <lee.jones@linaro.org>
> Acked-by: Peter Korsgaard <peter@korsgaard.com>
> ---
>
> Changes in v10:
> - remove the mfd cell .of_compatible.
v9 unapplied, v10 applied.
> Changes in v9:
> - remove unneeded struct act8945a_dev structure.
> - collect Acked from Lee.
> - collect Acked from Peter.
>
> Changes in v8:
> - change the subdevice's name "act8945a-pmic" to "act8945a-regulator".
>
> Changes in v7:
> - remove struct act8945a_dev to .c file.
> - remove unused .h file.
>
> Changes in v6:
> - change MFD_ACT8945A type from bool to tristate.
> - revert depends on to 'I2C'.
>
> Changes in v5:
> - change depends on to 'I2C=y'.
>
> Changes in v4:
> - add a space before .compatible.
> - collect Reviewed-by from Krzysztof Kozlowski.
>
> Changes in v3: None
> Changes in v2:
> - add more help information in Kconfig.
> - update the file header with short version license and author line.
> - remove unused structure members (dev, i2c_client) of stuct act8945a_dev.
> - use define "PLATFORM_DEVID_NONE" for mfd_add_devices(), instead of '-1'.
> - use more explicit info to indicate the failure to add sub devices.
> - remove the unnecessary print out.
> - substitute MODULE_LICENSE("GPL") for MODULE_LICENSE("GPL v2").
>
> drivers/mfd/Kconfig | 11 ++++++
> drivers/mfd/Makefile | 1 +
> drivers/mfd/act8945a.c | 102 ++++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 114 insertions(+)
> create mode 100644 drivers/mfd/act8945a.c
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 6c4ebd9..38994bb 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -18,6 +18,17 @@ config MFD_CS5535
> This is the core driver for CS5535/CS5536 MFD functions. This is
> necessary for using the board's GPIO and MFGPT functionality.
>
> +config MFD_ACT8945A
> + tristate "Active-semi ACT8945A"
> + select MFD_CORE
> + select REGMAP_I2C
> + depends on I2C && OF
> + help
> + Support for the ACT8945A PMIC from Active-semi. This device
> + features three step-down DC/DC converters and four low-dropout
> + linear regulators, along with a complete ActivePath battery
> + charger.
> +
> config MFD_AS3711
> bool "AMS AS3711"
> select MFD_CORE
> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
> index 0f230a6..2f1ca82 100644
> --- a/drivers/mfd/Makefile
> +++ b/drivers/mfd/Makefile
> @@ -6,6 +6,7 @@
> obj-$(CONFIG_MFD_88PM860X) += 88pm860x.o
> obj-$(CONFIG_MFD_88PM800) += 88pm800.o 88pm80x.o
> obj-$(CONFIG_MFD_88PM805) += 88pm805.o 88pm80x.o
> +obj-$(CONFIG_MFD_ACT8945A) += act8945a.o
> obj-$(CONFIG_MFD_SM501) += sm501.o
> obj-$(CONFIG_MFD_ASIC3) += asic3.o tmio_core.o
> obj-$(CONFIG_MFD_BCM590XX) += bcm590xx.o
> diff --git a/drivers/mfd/act8945a.c b/drivers/mfd/act8945a.c
> new file mode 100644
> index 0000000..525b546
> --- /dev/null
> +++ b/drivers/mfd/act8945a.c
> @@ -0,0 +1,102 @@
> +/*
> + * MFD driver for Active-semi ACT8945a PMIC
> + *
> + * Copyright (C) 2015 Atmel Corporation.
> + *
> + * Author: Wenyou Yang <wenyou.yang@atmel.com>
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License as published by the
> + * Free Software Foundation; either version 2 of the License, or (at your
> + * option) any later version.
> + */
> +
> +#include <linux/i2c.h>
> +#include <linux/mfd/core.h>
> +#include <linux/module.h>
> +#include <linux/of_device.h>
> +#include <linux/regmap.h>
> +
> +static const struct mfd_cell act8945a_devs[] = {
> + {
> + .name = "act8945a-regulator",
> + },
> + {
> + .name = "act8945a-charger",
> + },
> +};
> +
> +static const struct regmap_config act8945a_regmap_config = {
> + .reg_bits = 8,
> + .val_bits = 8,
> +};
> +
> +static int act8945a_i2c_probe(struct i2c_client *i2c,
> + const struct i2c_device_id *id)
> +{
> + int ret;
> + struct regmap *regmap;
> +
> + regmap = devm_regmap_init_i2c(i2c, &act8945a_regmap_config);
> + if (IS_ERR(regmap)) {
> + ret = PTR_ERR(regmap);
> + dev_err(&i2c->dev, "regmap init failed: %d\n", ret);
> + return ret;
> + }
> +
> + i2c_set_clientdata(i2c, regmap);
> +
> + ret = mfd_add_devices(&i2c->dev, PLATFORM_DEVID_NONE, act8945a_devs,
> + ARRAY_SIZE(act8945a_devs), NULL, 0, NULL);
> + if (ret) {
> + dev_err(&i2c->dev, "Failed to add sub devices\n");
> + return ret;
> + }
> +
> + return 0;
> +}
> +
> +static int act8945a_i2c_remove(struct i2c_client *i2c)
> +{
> + mfd_remove_devices(&i2c->dev);
> +
> + return 0;
> +}
> +
> +static const struct i2c_device_id act8945a_i2c_id[] = {
> + { "act8945a", 0 },
> + {}
> +};
> +MODULE_DEVICE_TABLE(i2c, act8945a_i2c_id);
> +
> +static const struct of_device_id act8945a_of_match[] = {
> + { .compatible = "active-semi,act8945a", },
> + {},
> +};
> +MODULE_DEVICE_TABLE(of, act8945a_of_match);
> +
> +static struct i2c_driver act8945a_i2c_driver = {
> + .driver = {
> + .name = "act8945a",
> + .of_match_table = of_match_ptr(act8945a_of_match),
> + },
> + .probe = act8945a_i2c_probe,
> + .remove = act8945a_i2c_remove,
> + .id_table = act8945a_i2c_id,
> +};
> +
> +static int __init act8945a_i2c_init(void)
> +{
> + return i2c_add_driver(&act8945a_i2c_driver);
> +}
> +subsys_initcall(act8945a_i2c_init);
> +
> +static void __exit act8945a_i2c_exit(void)
> +{
> + i2c_del_driver(&act8945a_i2c_driver);
> +}
> +module_exit(act8945a_i2c_exit);
> +
> +MODULE_DESCRIPTION("ACT8945A PMIC multi-function driver");
> +MODULE_AUTHOR("Wenyou Yang <wenyou.yang@atmel.com>");
> +MODULE_LICENSE("GPL");
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v10 2/2] mfd: add documentation for ACT8945A DT bindings
2016-02-05 3:36 ` [PATCH v10 2/2] mfd: add documentation for ACT8945A DT bindings Wenyou Yang
@ 2016-02-10 16:55 ` Lee Jones
0 siblings, 0 replies; 5+ messages in thread
From: Lee Jones @ 2016-02-10 16:55 UTC (permalink / raw)
To: Wenyou Yang
Cc: Rob Herring, Pawel Moll, Mark Brown, Ian Campbell, Kumar Gala,
Javier Martinez Canillas, Krzysztof Kozlowski, Peter Korsgaard,
Nicolas Ferre, linux-arm-kernel, linux-kernel, devicetree
On Fri, 05 Feb 2016, Wenyou Yang wrote:
> The Active-semi ACT8945A PMIC is a Multi-Function Device, it has
> two subdevices:
> - Regulator
> - Charger
>
> This patch adds documentation for ACT8945A DT bindings.
>
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> Acked-by: Rob Herring <robh@kernel.org>
> Acked-by: Lee Jones <lee.jones@linaro.org>
> ---
>
> Changes in v10:
> - update the example, due to the subdevices are not regarded as
> a child node.
v9 unapplied, v10 applied.
> Changes in v9: None
> Changes in v8: None
> Changes in v7:
> - collect Acked-by from Lee Jones
>
> Changes in v6:
> - change the regulator name.
>
> Changes in v5: None
> Changes in v4: None
> Changes in v3:
> - fix the tabbing errors in Example.
> - use "pmic@5b" label, not "act8945a@5b" in Example.
> - collect Acked-by from Rob.
>
> Changes in v2:
> - use more specific label in Example.
> - add pmic and charger nodes in Example.
>
> Documentation/devicetree/bindings/mfd/act8945a.txt | 76 ++++++++++++++++++++
> 1 file changed, 76 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/act8945a.txt
>
> diff --git a/Documentation/devicetree/bindings/mfd/act8945a.txt b/Documentation/devicetree/bindings/mfd/act8945a.txt
> new file mode 100644
> index 0000000..f712830
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/act8945a.txt
> @@ -0,0 +1,76 @@
> +Device-Tree bindings for Active-semi ACT8945A MFD driver
> +
> +Required properties:
> + - compatible: "active-semi,act8945a".
> + - reg: the I2C slave address for the ACT8945A chip
> +
> +The chip exposes two subdevices:
> + - a regulators: see ../regulator/act8945a-regulator.txt
> + - a charger: see ../power/act8945a-charger.txt
> +
> +Example:
> + pmic@5b {
> + compatible = "active-semi,act8945a";
> + reg = <0x5b>;
> + status = "okay";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_charger_chglev>;
> + active-semi,chglev-gpio = <&pioA 12 GPIO_ACTIVE_HIGH>;
> + active-semi,input-voltage-threshold-microvolt = <6600>;
> + active-semi,precondition-timeout = <40>;
> + active-semi,total-timeout = <3>;
> +
> + active-semi,vsel-high;
> +
> + regulators {
> + vdd_1v35_reg: REG_DCDC1 {
> + regulator-name = "VDD_1V35";
> + regulator-min-microvolt = <1350000>;
> + regulator-max-microvolt = <1350000>;
> + regulator-always-on;
> + };
> +
> + vdd_1v2_reg: REG_DCDC2 {
> + regulator-name = "VDD_1V2";
> + regulator-min-microvolt = <1100000>;
> + regulator-max-microvolt = <1300000>;
> + regulator-always-on;
> + };
> +
> + vdd_3v3_reg: REG_DCDC3 {
> + regulator-name = "VDD_3V3";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + };
> +
> + vdd_fuse_reg: REG_LDO1 {
> + regulator-name = "VDD_FUSE";
> + regulator-min-microvolt = <2500000>;
> + regulator-max-microvolt = <2500000>;
> + regulator-always-on;
> + };
> +
> + vdd_3v3_lp_reg: REG_LDO2 {
> + regulator-name = "VDD_3V3_LP";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + };
> +
> + vdd_led_reg: REG_LDO3 {
> + regulator-name = "VDD_LED";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + };
> +
> + vdd_sdhc_1v8_reg: REG_LDO4 {
> + regulator-name = "VDD_SDHC_1V8";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + };
> + };
> + };
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-02-10 16:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-05 3:36 [PATCH v10 0/2] mfd: act8945a: add Active-semi ACT8945A PMIC MFD driver Wenyou Yang
2016-02-05 3:36 ` [PATCH v10 1/2] " Wenyou Yang
2016-02-10 16:55 ` Lee Jones
2016-02-05 3:36 ` [PATCH v10 2/2] mfd: add documentation for ACT8945A DT bindings Wenyou Yang
2016-02-10 16:55 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).