* [PATCH] drm: etnaviv: Replace of_platform.h with explicit includes
@ 2023-04-10 23:26 Rob Herring
2023-06-09 20:17 ` Rob Herring
0 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2023-04-10 23:26 UTC (permalink / raw)
To: Lucas Stach, Russell King, Christian Gmeiner, David Airlie,
Daniel Vetter
Cc: etnaviv, dri-devel, linux-kernel
Etnaviv doesn't use anything from of_platform.h, but depends on
of.h, of_device.h, and platform_device.h which are all implicitly
included, but that is going to be removed soon.
Signed-off-by: Rob Herring <robh@kernel.org>
---
drivers/gpu/drm/etnaviv/etnaviv_drv.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
index 44ca803237a5..c68e83ed5a23 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
@@ -6,7 +6,9 @@
#include <linux/component.h>
#include <linux/dma-mapping.h>
#include <linux/module.h>
-#include <linux/of_platform.h>
+#include <linux/of.h>
+#include <linux/of_device.h>
+#include <linux/platform_device.h>
#include <linux/uaccess.h>
#include <drm/drm_debugfs.h>
--
2.39.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: etnaviv: Replace of_platform.h with explicit includes
2023-04-10 23:26 [PATCH] drm: etnaviv: Replace of_platform.h with explicit includes Rob Herring
@ 2023-06-09 20:17 ` Rob Herring
2023-06-11 6:49 ` Sui Jingfeng
2023-06-21 13:20 ` Lucas Stach
0 siblings, 2 replies; 6+ messages in thread
From: Rob Herring @ 2023-06-09 20:17 UTC (permalink / raw)
To: Lucas Stach, Russell King, Christian Gmeiner, David Airlie,
Daniel Vetter
Cc: etnaviv, dri-devel, linux-kernel
On Mon, Apr 10, 2023 at 5:26 PM Rob Herring <robh@kernel.org> wrote:
>
> Etnaviv doesn't use anything from of_platform.h, but depends on
> of.h, of_device.h, and platform_device.h which are all implicitly
> included, but that is going to be removed soon.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> drivers/gpu/drm/etnaviv/etnaviv_drv.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Ping!
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
> index 44ca803237a5..c68e83ed5a23 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
> @@ -6,7 +6,9 @@
> #include <linux/component.h>
> #include <linux/dma-mapping.h>
> #include <linux/module.h>
> -#include <linux/of_platform.h>
> +#include <linux/of.h>
> +#include <linux/of_device.h>
> +#include <linux/platform_device.h>
> #include <linux/uaccess.h>
>
> #include <drm/drm_debugfs.h>
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: etnaviv: Replace of_platform.h with explicit includes
2023-06-09 20:17 ` Rob Herring
@ 2023-06-11 6:49 ` Sui Jingfeng
2023-06-12 18:15 ` Rob Herring
2023-06-21 13:20 ` Lucas Stach
1 sibling, 1 reply; 6+ messages in thread
From: Sui Jingfeng @ 2023-06-11 6:49 UTC (permalink / raw)
To: Rob Herring, Lucas Stach, Russell King, Christian Gmeiner,
David Airlie, Daniel Vetter
Cc: etnaviv, dri-devel, linux-kernel
Reviewed-by: Sui Jingfeng <suijingfeng@loongson.cn>
On 2023/6/10 04:17, Rob Herring wrote:
> On Mon, Apr 10, 2023 at 5:26 PM Rob Herring <robh@kernel.org> wrote:
>> Etnaviv doesn't use anything from of_platform.h, but depends on
>> of.h, of_device.h, and platform_device.h which are all implicitly
>> included, but that is going to be removed soon.
>>
>> Signed-off-by: Rob Herring <robh@kernel.org>
>> ---
>> drivers/gpu/drm/etnaviv/etnaviv_drv.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
> Ping!
of_device.h already has 'linux/of.h' and 'linux/platform_device.h' included,
Would it be sufficient by simply including linux/of_device.h ?
I'm fine with the above question explained.
```
#include <linux/platform_device.h>
#include <linux/of_platform.h> /* temporary until merge */
#include <linux/of.h>
```
>> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
>> index 44ca803237a5..c68e83ed5a23 100644
>> --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
>> +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
>> @@ -6,7 +6,9 @@
>> #include <linux/component.h>
>> #include <linux/dma-mapping.h>
>> #include <linux/module.h>
>> -#include <linux/of_platform.h>
>> +#include <linux/of.h>
>> +#include <linux/of_device.h>
>> +#include <linux/platform_device.h>
>> #include <linux/uaccess.h>
>>
>> #include <drm/drm_debugfs.h>
>> --
>> 2.39.2
>>
--
Jingfeng
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: etnaviv: Replace of_platform.h with explicit includes
2023-06-11 6:49 ` Sui Jingfeng
@ 2023-06-12 18:15 ` Rob Herring
2023-06-12 18:20 ` Sui Jingfeng
0 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2023-06-12 18:15 UTC (permalink / raw)
To: Sui Jingfeng
Cc: Lucas Stach, Russell King, Christian Gmeiner, David Airlie,
Daniel Vetter, etnaviv, dri-devel, linux-kernel
On Sun, Jun 11, 2023 at 12:49 AM Sui Jingfeng <suijingfeng@loongson.cn> wrote:
>
> Reviewed-by: Sui Jingfeng <suijingfeng@loongson.cn>
>
>
> On 2023/6/10 04:17, Rob Herring wrote:
> > On Mon, Apr 10, 2023 at 5:26 PM Rob Herring <robh@kernel.org> wrote:
> >> Etnaviv doesn't use anything from of_platform.h, but depends on
> >> of.h, of_device.h, and platform_device.h which are all implicitly
> >> included, but that is going to be removed soon.
> >>
> >> Signed-off-by: Rob Herring <robh@kernel.org>
> >> ---
> >> drivers/gpu/drm/etnaviv/etnaviv_drv.c | 4 +++-
> >> 1 file changed, 3 insertions(+), 1 deletion(-)
> > Ping!
>
>
> of_device.h already has 'linux/of.h' and 'linux/platform_device.h' included,
>
> Would it be sufficient by simply including linux/of_device.h ?
That's part of what I'm trying to remove. Standard practice is to not
rely on implicit includes.
Rob
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: etnaviv: Replace of_platform.h with explicit includes
2023-06-12 18:15 ` Rob Herring
@ 2023-06-12 18:20 ` Sui Jingfeng
0 siblings, 0 replies; 6+ messages in thread
From: Sui Jingfeng @ 2023-06-12 18:20 UTC (permalink / raw)
To: Rob Herring
Cc: Lucas Stach, Russell King, Christian Gmeiner, David Airlie,
Daniel Vetter, etnaviv, dri-devel, linux-kernel
On 2023/6/13 02:15, Rob Herring wrote:
> On Sun, Jun 11, 2023 at 12:49 AM Sui Jingfeng <suijingfeng@loongson.cn> wrote:
>> Reviewed-by: Sui Jingfeng <suijingfeng@loongson.cn>
>>
>>
>> On 2023/6/10 04:17, Rob Herring wrote:
>>> On Mon, Apr 10, 2023 at 5:26 PM Rob Herring <robh@kernel.org> wrote:
>>>> Etnaviv doesn't use anything from of_platform.h, but depends on
>>>> of.h, of_device.h, and platform_device.h which are all implicitly
>>>> included, but that is going to be removed soon.
>>>>
>>>> Signed-off-by: Rob Herring <robh@kernel.org>
>>>> ---
>>>> drivers/gpu/drm/etnaviv/etnaviv_drv.c | 4 +++-
>>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>> Ping!
>>
>> of_device.h already has 'linux/of.h' and 'linux/platform_device.h' included,
>>
>> Would it be sufficient by simply including linux/of_device.h ?
> That's part of what I'm trying to remove. Standard practice is to not
> rely on implicit includes.
Ok, that's fine then.
Tested-by: Sui Jingfeng <suijingfeng@loongson.cn>
> Rob
--
Jingfeng
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: etnaviv: Replace of_platform.h with explicit includes
2023-06-09 20:17 ` Rob Herring
2023-06-11 6:49 ` Sui Jingfeng
@ 2023-06-21 13:20 ` Lucas Stach
1 sibling, 0 replies; 6+ messages in thread
From: Lucas Stach @ 2023-06-21 13:20 UTC (permalink / raw)
To: Rob Herring, Russell King, Christian Gmeiner, David Airlie,
Daniel Vetter
Cc: etnaviv, dri-devel, linux-kernel
Am Freitag, dem 09.06.2023 um 14:17 -0600 schrieb Rob Herring:
> On Mon, Apr 10, 2023 at 5:26 PM Rob Herring <robh@kernel.org> wrote:
> >
> > Etnaviv doesn't use anything from of_platform.h, but depends on
> > of.h, of_device.h, and platform_device.h which are all implicitly
> > included, but that is going to be removed soon.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> > drivers/gpu/drm/etnaviv/etnaviv_drv.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
>
> Ping!
Thanks, applied to etnaviv/next.
Regards,
Lucas
>
> >
> > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
> > index 44ca803237a5..c68e83ed5a23 100644
> > --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
> > +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
> > @@ -6,7 +6,9 @@
> > #include <linux/component.h>
> > #include <linux/dma-mapping.h>
> > #include <linux/module.h>
> > -#include <linux/of_platform.h>
> > +#include <linux/of.h>
> > +#include <linux/of_device.h>
> > +#include <linux/platform_device.h>
> > #include <linux/uaccess.h>
> >
> > #include <drm/drm_debugfs.h>
> > --
> > 2.39.2
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-06-21 13:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-10 23:26 [PATCH] drm: etnaviv: Replace of_platform.h with explicit includes Rob Herring
2023-06-09 20:17 ` Rob Herring
2023-06-11 6:49 ` Sui Jingfeng
2023-06-12 18:15 ` Rob Herring
2023-06-12 18:20 ` Sui Jingfeng
2023-06-21 13:20 ` Lucas Stach
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).