From: Eric Wong <normalperson-rMlxZR9MS24@public.gmane.org>
To: mongrel-development-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org
Cc: puppet-dev-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: Mongrel doesn't set close-on-exec on its listen socket
Date: Mon, 18 Aug 2008 14:59:21 -0700 [thread overview]
Message-ID: <20080818215844.GA1441@yp-box.dyndns.org> (raw)
In-Reply-To: <20080722163104.GA82787-/yjMewivvDbpLr52UxKYZsM6rOWSkUom@public.gmane.org>
Jos Backus <jos-ER9Rz4keOotBDgjK7y7TUQ@public.gmane.org> wrote:
> Mongrel, at least in 1.1.4, doesn't set the close-on-exec flag on the listen
> socket. This leads to trouble in programs that use Mongrel and fork other
> programs (like puppetmasterd, part of Puppet). For an example, see
> http://groups.google.com/group/puppet-dev/browse_thread/thread/463f0f8cfc80cc43
>
> Please consider applying something like the following patch:
>
> --- lib/mongrel.rb.orig 2008-07-17 17:44:42.000000000 -0400
> +++ lib/mongrel.rb 2008-07-17 17:44:53.000000000 -0400
> @@ -92,7 +92,9 @@
>
> tries = 0
> @socket = TCPServer.new(host, port)
> + @socket.fcntl(Fcntl::F_SETFD, Fcntl::FD_CLOEXEC)
> +
> @classifier = URIClassifier.new
> @host = host
> @port = port
>
> If somebody can show me what the Mongrel way of making this (POSIX)
> platform-specific, that would be appreciated.
This probably works:
diff --git a/lib/mongrel.rb b/lib/mongrel.rb
index 8b5dfe2..027bfdb 100644
--- a/lib/mongrel.rb
+++ b/lib/mongrel.rb
@@ -91,6 +91,9 @@ module Mongrel
tries = 0
@socket = TCPServer.new(host, port)
+ if defined?(Fcntl::FD_CLOEXEC)
+ @socket.fcntl(Fcntl::F_SETFD, Fcntl::FD_CLOEXEC)
+ end
@classifier = URIClassifier.new
@host = host
--
Eric Wong
next prev parent reply other threads:[~2008-08-18 22:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-22 16:31 Mongrel doesn't set close-on-exec on its listen socket Jos Backus
[not found] ` <20080722163104.GA82787-/yjMewivvDbpLr52UxKYZsM6rOWSkUom@public.gmane.org>
2008-08-18 21:59 ` Eric Wong [this message]
2008-08-19 3:08 ` [Mongrel-development] " Jos Backus
[not found] ` <20080819030844.GA53303-/yjMewivvDbpLr52UxKYZsM6rOWSkUom@public.gmane.org>
2008-08-20 8:27 ` Eric Wong
[not found] ` <20080820082737.GA2403-G9TX8C5UF5wdbCeoMzGj59i2O/JbrIOy@public.gmane.org>
2008-11-04 20:41 ` Jos Backus
[not found] ` <20081104204159.GA48584-/yjMewivvDbpLr52UxKYZsM6rOWSkUom@public.gmane.org>
2008-11-08 2:15 ` Eric Wong
replies disabled, historical list
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).