unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: "Petteri Räty" <betelgeuse@gentoo.org>
To: mongrel-unicorn@rubyforge.org
Subject: Re: Issues with PID file renaming
Date: Tue, 10 Dec 2013 14:46:30 +0200	[thread overview]
Message-ID: <52A70D26.7020105@gentoo.org> (raw)
In-Reply-To: <20131126012036.GA5868@dcvr.yhbt.net>

On 26.11.2013 3.20, Eric Wong wrote:

>>
>> I think the way 4.6.2 worked is better. There should be a pid file for
>> the new master process the moment it's created.
> 
>> What do you think?
> 
> How about having the old process create a hard link to .oldbin,
> and having the new one override the pid if Process.ppid == pid file?
> The check is still racy, but that's what pid files are :<
> 

Isn't it possible to always keep a valid pid file by using the fact that
mv is atomic? Basically the new process writes the pid first to a temp
file and then moves it over the old pid file after having hard linked
the file to .oldbin?

$ echo "1" > foo.pid
$ ln foo.pid foo.oldpid
$ echo "2" > tmp
$ mv tmp foo.pid
$ cat *pid
1
2

Regards,
Petteri

_______________________________________________
Unicorn mailing list - mongrel-unicorn@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying

  parent reply	other threads:[~2013-12-10 12:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-26  1:00 Issues with PID file renaming Jimmy Soho
2013-11-26  1:20 ` Eric Wong
2013-11-26  1:40   ` Michael Fischer
2013-11-26  2:07     ` Eric Wong
2013-12-10 12:46   ` Petteri Räty [this message]
2013-12-10 19:52     ` Eric Wong
2013-12-10 22:44       ` Petteri Räty
2013-12-11 13:54         ` Michael Fischer
2013-12-12 19:15           ` Petteri Räty
2013-12-12 20:51             ` Eric Wong
2013-11-26  1:42 ` Michael Fischer
2013-11-26  4:55   ` Jimmy Soho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/unicorn/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52A70D26.7020105@gentoo.org \
    --to=betelgeuse@gentoo.org \
    --cc=mongrel-unicorn@rubyforge.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/unicorn.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).