From: Michael Fischer <mfischer@zendesk.com>
To: unicorn list <mongrel-unicorn@rubyforge.org>
Subject: Re: Issues with PID file renaming
Date: Mon, 25 Nov 2013 17:40:48 -0800 [thread overview]
Message-ID: <CABHxtY5PuY_CvgdEqRSsKo2V0n9gEL=MgTf6NQYsyz5-qv6XsA@mail.gmail.com> (raw)
In-Reply-To: <20131126012036.GA5868@dcvr.yhbt.net>
On Mon, Nov 25, 2013 at 5:20 PM, Eric Wong <normalperson@yhbt.net> wrote:
>> What I notice is the following: when upgrading with 4.6.2 the file
>> unicorn.pid is copied to unicorn.pid.oldbin and the unicorn.pid file
>> is updated (the (new) master process). After a while the worker pid
>> files are updated and the unicorn.pid.oldbin file disappears, and all
>> is fine.
>
> Ugh. This is what I feared... Slow startup time of most Ruby web apps
> doesn't help.
Why doesn't the new master write its pid file immediately upon
forking? It shouldn't have to wait for everything else to load,
should it?
> How about having the old process create a hard link to .oldbin,
> and having the new one override the pid if Process.ppid == pid file?
> The check is still racy, but that's what pid files are :<
If you decide to implement this, please make it optional. The current
behavior is correct IMO, and it will work much better if the above
issue is addressed.
--Michael
_______________________________________________
Unicorn mailing list - mongrel-unicorn@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying
next prev parent reply other threads:[~2013-11-26 1:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-26 1:00 Issues with PID file renaming Jimmy Soho
2013-11-26 1:20 ` Eric Wong
2013-11-26 1:40 ` Michael Fischer [this message]
2013-11-26 2:07 ` Eric Wong
2013-12-10 12:46 ` Petteri Räty
2013-12-10 19:52 ` Eric Wong
2013-12-10 22:44 ` Petteri Räty
2013-12-11 13:54 ` Michael Fischer
2013-12-12 19:15 ` Petteri Räty
2013-12-12 20:51 ` Eric Wong
2013-11-26 1:42 ` Michael Fischer
2013-11-26 4:55 ` Jimmy Soho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/unicorn/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABHxtY5PuY_CvgdEqRSsKo2V0n9gEL=MgTf6NQYsyz5-qv6XsA@mail.gmail.com' \
--to=mfischer@zendesk.com \
--cc=mongrel-unicorn@rubyforge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/unicorn.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).