From: Jimmy Soho <jimmy.soho@gmail.com>
To: mongrel-unicorn <mongrel-unicorn@rubyforge.org>
Subject: Issues with PID file renaming
Date: Tue, 26 Nov 2013 12:00:41 +1100 [thread overview]
Message-ID: <CAHStS5gFYcPBDxkVizAHrOeDKAkjT69kruFdgaY0CbB+vLbK8Q@mail.gmail.com> (raw)
Hi Eric,
Since we upgraded from 4.6.2 to 4.7.0 we're regularly having issues
where one or more unicorn master processes would not upgrade
correctly, resulting in an (old) master process.
What I notice is the following: when upgrading with 4.6.2 the file
unicorn.pid is copied to unicorn.pid.oldbin and the unicorn.pid file
is updated (the (new) master process). After a while the worker pid
files are updated and the unicorn.pid.oldbin file disappears, and all
is fine.
When upgrading with 4.7.0 though the file unicorn.pid.oldbin is
created, but there is no unicorn.pid file. After a while (when the new
master process has finished initialising, and is ready to fork the
workers) the worker pid files are updated and a unicorn.pid file
appears, and then the unicorn.pid.oldbin file disappears.
So there is a relatively long period where there is no unicorn.pid file.
I think the problem for us is caused by monit, our process monitor,
which monitors the unicorn.pid file:
check process unicorn with pidfile
/srv/app.itrp-staging.com/shared/pids/unicorn.pid
start program = "/etc/init.d/unicorn start"
stop program = "/etc/init.d/unicorn stop"
...
Because the unicorn.pid file is absent for a relatively long period
monit will try to start unicorn, while an upgrade is in progress.
(which might be another issue: the start action should recognise a
start or upgrade process is already underway; sadly this check too
relies on the existence of the unicorn.pid file)
I think the way 4.6.2 worked is better. There should be a pid file for
the new master process the moment it's created.
What do you think?
--
Jim
_______________________________________________
Unicorn mailing list - mongrel-unicorn@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying
next reply other threads:[~2013-11-26 1:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-26 1:00 Jimmy Soho [this message]
2013-11-26 1:20 ` Issues with PID file renaming Eric Wong
2013-11-26 1:40 ` Michael Fischer
2013-11-26 2:07 ` Eric Wong
2013-12-10 12:46 ` Petteri Räty
2013-12-10 19:52 ` Eric Wong
2013-12-10 22:44 ` Petteri Räty
2013-12-11 13:54 ` Michael Fischer
2013-12-12 19:15 ` Petteri Räty
2013-12-12 20:51 ` Eric Wong
2013-11-26 1:42 ` Michael Fischer
2013-11-26 4:55 ` Jimmy Soho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/unicorn/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHStS5gFYcPBDxkVizAHrOeDKAkjT69kruFdgaY0CbB+vLbK8Q@mail.gmail.com \
--to=jimmy.soho@gmail.com \
--cc=mongrel-unicorn@rubyforge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/unicorn.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).