From: chunfeng yun <chunfeng.yun@mediatek.com>
To: Roger Quadros <rogerq@ti.com>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
Felipe Balbi <balbi@ti.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-usb@vger.kernel.org>, <linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v2 2/5] dt-bindings: Add a binding for Mediatek xHCI host controller
Date: Tue, 14 Jul 2015 10:50:13 +0800 [thread overview]
Message-ID: <1436842213.11289.0.camel@mhfsdcap03> (raw)
In-Reply-To: <559F82C7.5010202@ti.com>
hi Roger,
On Fri, 2015-07-10 at 11:31 +0300, Roger Quadros wrote:
> Hi,
>
> On 08/07/15 12:41, Chunfeng Yun wrote:
> > add a DT binding documentation of xHCI host controller for the
> > MT8173 SoC from Mediatek.
> >
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> > .../devicetree/bindings/usb/mt8173-xhci.txt | 27 ++++++++++++++++++++++
> > 1 file changed, 27 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/usb/mt8173-xhci.txt
> >
> > diff --git a/Documentation/devicetree/bindings/usb/mt8173-xhci.txt b/Documentation/devicetree/bindings/usb/mt8173-xhci.txt
> > new file mode 100644
> > index 0000000..94cec94
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/usb/mt8173-xhci.txt
> > @@ -0,0 +1,27 @@
> > +MT65XX xhci
> > +
> > +The device node for Mediatek SOC usb3.0 host controller
> > +
> > +Required properties:
> > + - compatible : supports "mediatek,mt8173-xhci"
> > + - reg : Offset and length of registers
> > + - interrupts : Interrupt mode, number and trigger mode
> > + - reg-vusb33-supply: regulator of usb avdd3.3v
> > + - reg-vbus-supply : regulator of vbus;
>
> General trend is to use <supply-name>-supply.
> We already know it is a regulator so no need to add "reg-"
>
> So those two can be
>
> vusb33-supply:
> vbus-supply:
>
I will adjust it later, thanks a lot
>
> > + - usb-phy : the phy that xhci will bind
> > + - usb3-lpm-capable: supports USB3 LPM
> > + - clocks : must support all clocks that xhci needs
> > + - clock-names: should be "sys_mac" for sys and mac clocks
> > +
> > +Example:
> > +usb: usb30@11270000 {
> > + compatible = "mediatek,mt8173-xhci";
> > + reg = <0 0x11270000 0 0x1000>;
> > + interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_LOW>;
> > + reg-vusb33-supply = <&mt6397_vusb_reg>;
> > + reg-vbus-supply = <&usb_p1_vbus>;
> > + usb-phy = <&u3phy>;
> > + usb3-lpm-capable;
> > + clocks = <&topckgen CLK_TOP_USB30_SEL>;
> > + clock-names = "sys_mac";
> > +};
> >
>
> cheers,
> -roger
WARNING: multiple messages have this Message-ID (diff)
From: chunfeng yun <chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
To: Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org>
Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Mathias Nyman
<mathias.nyman-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Matthias Brugger
<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v2 2/5] dt-bindings: Add a binding for Mediatek xHCI host controller
Date: Tue, 14 Jul 2015 10:50:13 +0800 [thread overview]
Message-ID: <1436842213.11289.0.camel@mhfsdcap03> (raw)
In-Reply-To: <559F82C7.5010202-l0cyMroinI0@public.gmane.org>
hi Roger,
On Fri, 2015-07-10 at 11:31 +0300, Roger Quadros wrote:
> Hi,
>
> On 08/07/15 12:41, Chunfeng Yun wrote:
> > add a DT binding documentation of xHCI host controller for the
> > MT8173 SoC from Mediatek.
> >
> > Signed-off-by: Chunfeng Yun <chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> > ---
> > .../devicetree/bindings/usb/mt8173-xhci.txt | 27 ++++++++++++++++++++++
> > 1 file changed, 27 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/usb/mt8173-xhci.txt
> >
> > diff --git a/Documentation/devicetree/bindings/usb/mt8173-xhci.txt b/Documentation/devicetree/bindings/usb/mt8173-xhci.txt
> > new file mode 100644
> > index 0000000..94cec94
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/usb/mt8173-xhci.txt
> > @@ -0,0 +1,27 @@
> > +MT65XX xhci
> > +
> > +The device node for Mediatek SOC usb3.0 host controller
> > +
> > +Required properties:
> > + - compatible : supports "mediatek,mt8173-xhci"
> > + - reg : Offset and length of registers
> > + - interrupts : Interrupt mode, number and trigger mode
> > + - reg-vusb33-supply: regulator of usb avdd3.3v
> > + - reg-vbus-supply : regulator of vbus;
>
> General trend is to use <supply-name>-supply.
> We already know it is a regulator so no need to add "reg-"
>
> So those two can be
>
> vusb33-supply:
> vbus-supply:
>
I will adjust it later, thanks a lot
>
> > + - usb-phy : the phy that xhci will bind
> > + - usb3-lpm-capable: supports USB3 LPM
> > + - clocks : must support all clocks that xhci needs
> > + - clock-names: should be "sys_mac" for sys and mac clocks
> > +
> > +Example:
> > +usb: usb30@11270000 {
> > + compatible = "mediatek,mt8173-xhci";
> > + reg = <0 0x11270000 0 0x1000>;
> > + interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_LOW>;
> > + reg-vusb33-supply = <&mt6397_vusb_reg>;
> > + reg-vbus-supply = <&usb_p1_vbus>;
> > + usb-phy = <&u3phy>;
> > + usb3-lpm-capable;
> > + clocks = <&topckgen CLK_TOP_USB30_SEL>;
> > + clock-names = "sys_mac";
> > +};
> >
>
> cheers,
> -roger
WARNING: multiple messages have this Message-ID (diff)
From: chunfeng.yun@mediatek.com (chunfeng yun)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/5] dt-bindings: Add a binding for Mediatek xHCI host controller
Date: Tue, 14 Jul 2015 10:50:13 +0800 [thread overview]
Message-ID: <1436842213.11289.0.camel@mhfsdcap03> (raw)
In-Reply-To: <559F82C7.5010202@ti.com>
hi Roger,
On Fri, 2015-07-10 at 11:31 +0300, Roger Quadros wrote:
> Hi,
>
> On 08/07/15 12:41, Chunfeng Yun wrote:
> > add a DT binding documentation of xHCI host controller for the
> > MT8173 SoC from Mediatek.
> >
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> > .../devicetree/bindings/usb/mt8173-xhci.txt | 27 ++++++++++++++++++++++
> > 1 file changed, 27 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/usb/mt8173-xhci.txt
> >
> > diff --git a/Documentation/devicetree/bindings/usb/mt8173-xhci.txt b/Documentation/devicetree/bindings/usb/mt8173-xhci.txt
> > new file mode 100644
> > index 0000000..94cec94
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/usb/mt8173-xhci.txt
> > @@ -0,0 +1,27 @@
> > +MT65XX xhci
> > +
> > +The device node for Mediatek SOC usb3.0 host controller
> > +
> > +Required properties:
> > + - compatible : supports "mediatek,mt8173-xhci"
> > + - reg : Offset and length of registers
> > + - interrupts : Interrupt mode, number and trigger mode
> > + - reg-vusb33-supply: regulator of usb avdd3.3v
> > + - reg-vbus-supply : regulator of vbus;
>
> General trend is to use <supply-name>-supply.
> We already know it is a regulator so no need to add "reg-"
>
> So those two can be
>
> vusb33-supply:
> vbus-supply:
>
I will adjust it later, thanks a lot
>
> > + - usb-phy : the phy that xhci will bind
> > + - usb3-lpm-capable: supports USB3 LPM
> > + - clocks : must support all clocks that xhci needs
> > + - clock-names: should be "sys_mac" for sys and mac clocks
> > +
> > +Example:
> > +usb: usb30 at 11270000 {
> > + compatible = "mediatek,mt8173-xhci";
> > + reg = <0 0x11270000 0 0x1000>;
> > + interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_LOW>;
> > + reg-vusb33-supply = <&mt6397_vusb_reg>;
> > + reg-vbus-supply = <&usb_p1_vbus>;
> > + usb-phy = <&u3phy>;
> > + usb3-lpm-capable;
> > + clocks = <&topckgen CLK_TOP_USB30_SEL>;
> > + clock-names = "sys_mac";
> > +};
> >
>
> cheers,
> -roger
next prev parent reply other threads:[~2015-07-14 2:55 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 9:41 [PATCH v2 0/5] Mediatek xHCI support Chunfeng Yun
2015-07-08 9:41 ` Chunfeng Yun
2015-07-08 9:41 ` Chunfeng Yun
2015-07-08 9:41 ` [PATCH v2 1/5] dt-bindings: Add usb3.0 phy binding for MT65xx SoCs Chunfeng Yun
2015-07-08 9:41 ` Chunfeng Yun
2015-07-08 9:41 ` Chunfeng Yun
2015-07-10 5:10 ` Sascha Hauer
2015-07-10 5:10 ` Sascha Hauer
2015-07-10 5:10 ` Sascha Hauer
2015-07-14 6:19 ` chunfeng yun
2015-07-14 6:19 ` chunfeng yun
2015-07-14 6:19 ` chunfeng yun
2015-07-14 7:45 ` Sascha Hauer
2015-07-14 7:45 ` Sascha Hauer
2015-07-14 7:45 ` Sascha Hauer
2015-07-15 12:33 ` chunfeng yun
2015-07-15 12:33 ` chunfeng yun
2015-07-15 12:33 ` chunfeng yun
2015-07-08 9:41 ` [PATCH v2 2/5] dt-bindings: Add a binding for Mediatek xHCI host controller Chunfeng Yun
2015-07-08 9:41 ` Chunfeng Yun
2015-07-08 9:41 ` Chunfeng Yun
2015-07-10 8:31 ` Roger Quadros
2015-07-10 8:31 ` Roger Quadros
2015-07-10 8:31 ` Roger Quadros
2015-07-14 2:36 ` chunfeng yun
2015-07-14 2:36 ` chunfeng yun
2015-07-14 2:36 ` chunfeng yun
2015-07-14 2:50 ` chunfeng yun [this message]
2015-07-14 2:50 ` chunfeng yun
2015-07-14 2:50 ` chunfeng yun
2015-07-20 14:24 ` chunfeng yun
2015-07-20 14:24 ` chunfeng yun
2015-07-20 14:24 ` chunfeng yun
2015-07-08 9:41 ` [PATCH v2 3/5] usb: phy: add usb3.0 phy driver for mt65xx SoCs Chunfeng Yun
2015-07-08 9:41 ` Chunfeng Yun
2015-07-08 9:41 ` Chunfeng Yun
2015-07-10 6:42 ` Sascha Hauer
2015-07-10 6:42 ` Sascha Hauer
2015-07-10 6:42 ` Sascha Hauer
2015-07-20 15:41 ` chunfeng yun
2015-07-20 15:41 ` chunfeng yun
2015-07-20 15:41 ` chunfeng yun
2015-07-08 9:41 ` [PATCH v2 4/5] xhci: mediatek: support MTK xHCI host controller Chunfeng Yun
2015-07-08 9:41 ` Chunfeng Yun
2015-07-08 9:41 ` Chunfeng Yun
2015-07-13 14:52 ` John Crispin
2015-07-13 14:52 ` John Crispin
2015-07-13 14:52 ` John Crispin
2015-07-20 14:51 ` chunfeng yun
2015-07-20 14:51 ` chunfeng yun
2015-07-20 14:51 ` chunfeng yun
2015-07-08 9:41 ` [PATCH v2 5/5] arm64: dts: mediatek: add xHCI & usb phy for mt8173 Chunfeng Yun
2015-07-08 9:41 ` Chunfeng Yun
2015-07-08 9:41 ` Chunfeng Yun
2015-07-14 10:12 ` Daniel Kurtz
2015-07-14 10:12 ` Daniel Kurtz
2015-07-20 14:39 ` chunfeng yun
2015-07-20 14:39 ` chunfeng yun
2015-07-20 14:39 ` chunfeng yun
2015-07-20 14:51 ` Yingjoe Chen
2015-07-20 14:51 ` Yingjoe Chen
2015-07-20 14:51 ` Yingjoe Chen
2015-07-20 14:59 ` Daniel Kurtz
2015-07-20 14:59 ` Daniel Kurtz
2015-07-20 14:59 ` Daniel Kurtz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436842213.11289.0.camel@mhfsdcap03 \
--to=chunfeng.yun@mediatek.com \
--cc=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathias.nyman@intel.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=rogerq@ti.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.