From: Daniel Kurtz <djkurtz@chromium.org>
To: Yingjoe Chen <yingjoe.chen@mediatek.com>
Cc: chunfeng yun <chunfeng.yun@mediatek.com>,
Mark Rutland <mark.rutland@arm.com>,
"open list:OPEN FIRMWARE AND..." <devicetree@vger.kernel.org>,
Mathias Nyman <mathias.nyman@intel.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-usb@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Felipe Balbi <balbi@ti.com>, Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Roger Quadros <rogerq@ti.com>
Subject: Re: [PATCH v2 5/5] arm64: dts: mediatek: add xHCI & usb phy for mt8173
Date: Mon, 20 Jul 2015 22:59:38 +0800 [thread overview]
Message-ID: <CAGS+omBokK5MXSGny0LpH8KBZup-d7XB_0WF=5JEg1BGbsJpMA@mail.gmail.com> (raw)
In-Reply-To: <1437403873.15139.5.camel@mtksdaap41>
On Mon, Jul 20, 2015 at 10:51 PM, Yingjoe Chen
<yingjoe.chen@mediatek.com> wrote:
>
> Hi Daniel, Chunfeng,
>
>
> On Mon, 2015-07-20 at 22:39 +0800, chunfeng yun wrote:
>> Hi,
>>
>> On Tue, 2015-07-14 at 18:12 +0800, Daniel Kurtz wrote:
> <...>
>> > > +
>> > > + usb_p1_vbus: fixedregulator@0 {
>> >
>> > Why @0 ?
>> It is the first fixed regulator, so set it to 0 as a index.
>> I will remove it later
>
> Since this name should be unique, I think we should use gpio number as
> address for fixedregulator in case we need other fixedregulators. So
> this could be:
>
> usb_p1_vbus: fixedregulator@130 {
>
> Also, we should sort according to the address(gpio number) for these
> nodes. Does this make sense?
Yes - that makes some sense.
But, a quick check of other "fixedregulator@" nodes in
arch/arm/boot/dts/ shows that mostly they use @0 , @1.
So, I think the original patch is probably fine.
Sorry for the noise,
-Dan
>
> Joe.C
>
>> >
>> > > + compatible = "regulator-fixed";
>> > > + regulator-name = "usb_vbus";
>> > > + regulator-min-microvolt = <5000000>;
>> > > + regulator-max-microvolt = <5000000>;
>> > > + gpio = <&pio 130 GPIO_ACTIVE_HIGH>;
>> > > + enable-active-high;
>> > > + };
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Kurtz <djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
To: Yingjoe Chen <yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: chunfeng yun
<chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
"open list:OPEN FIRMWARE AND..."
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Mathias Nyman
<mathias.nyman-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Matthias Brugger
<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org>
Subject: Re: [PATCH v2 5/5] arm64: dts: mediatek: add xHCI & usb phy for mt8173
Date: Mon, 20 Jul 2015 22:59:38 +0800 [thread overview]
Message-ID: <CAGS+omBokK5MXSGny0LpH8KBZup-d7XB_0WF=5JEg1BGbsJpMA@mail.gmail.com> (raw)
In-Reply-To: <1437403873.15139.5.camel@mtksdaap41>
On Mon, Jul 20, 2015 at 10:51 PM, Yingjoe Chen
<yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> wrote:
>
> Hi Daniel, Chunfeng,
>
>
> On Mon, 2015-07-20 at 22:39 +0800, chunfeng yun wrote:
>> Hi,
>>
>> On Tue, 2015-07-14 at 18:12 +0800, Daniel Kurtz wrote:
> <...>
>> > > +
>> > > + usb_p1_vbus: fixedregulator@0 {
>> >
>> > Why @0 ?
>> It is the first fixed regulator, so set it to 0 as a index.
>> I will remove it later
>
> Since this name should be unique, I think we should use gpio number as
> address for fixedregulator in case we need other fixedregulators. So
> this could be:
>
> usb_p1_vbus: fixedregulator@130 {
>
> Also, we should sort according to the address(gpio number) for these
> nodes. Does this make sense?
Yes - that makes some sense.
But, a quick check of other "fixedregulator@" nodes in
arch/arm/boot/dts/ shows that mostly they use @0 , @1.
So, I think the original patch is probably fine.
Sorry for the noise,
-Dan
>
> Joe.C
>
>> >
>> > > + compatible = "regulator-fixed";
>> > > + regulator-name = "usb_vbus";
>> > > + regulator-min-microvolt = <5000000>;
>> > > + regulator-max-microvolt = <5000000>;
>> > > + gpio = <&pio 130 GPIO_ACTIVE_HIGH>;
>> > > + enable-active-high;
>> > > + };
>
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: djkurtz@chromium.org (Daniel Kurtz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 5/5] arm64: dts: mediatek: add xHCI & usb phy for mt8173
Date: Mon, 20 Jul 2015 22:59:38 +0800 [thread overview]
Message-ID: <CAGS+omBokK5MXSGny0LpH8KBZup-d7XB_0WF=5JEg1BGbsJpMA@mail.gmail.com> (raw)
In-Reply-To: <1437403873.15139.5.camel@mtksdaap41>
On Mon, Jul 20, 2015 at 10:51 PM, Yingjoe Chen
<yingjoe.chen@mediatek.com> wrote:
>
> Hi Daniel, Chunfeng,
>
>
> On Mon, 2015-07-20 at 22:39 +0800, chunfeng yun wrote:
>> Hi,
>>
>> On Tue, 2015-07-14 at 18:12 +0800, Daniel Kurtz wrote:
> <...>
>> > > +
>> > > + usb_p1_vbus: fixedregulator at 0 {
>> >
>> > Why @0 ?
>> It is the first fixed regulator, so set it to 0 as a index.
>> I will remove it later
>
> Since this name should be unique, I think we should use gpio number as
> address for fixedregulator in case we need other fixedregulators. So
> this could be:
>
> usb_p1_vbus: fixedregulator at 130 {
>
> Also, we should sort according to the address(gpio number) for these
> nodes. Does this make sense?
Yes - that makes some sense.
But, a quick check of other "fixedregulator@" nodes in
arch/arm/boot/dts/ shows that mostly they use @0 , @1.
So, I think the original patch is probably fine.
Sorry for the noise,
-Dan
>
> Joe.C
>
>> >
>> > > + compatible = "regulator-fixed";
>> > > + regulator-name = "usb_vbus";
>> > > + regulator-min-microvolt = <5000000>;
>> > > + regulator-max-microvolt = <5000000>;
>> > > + gpio = <&pio 130 GPIO_ACTIVE_HIGH>;
>> > > + enable-active-high;
>> > > + };
>
>
next prev parent reply other threads:[~2015-07-20 15:00 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 9:41 [PATCH v2 0/5] Mediatek xHCI support Chunfeng Yun
2015-07-08 9:41 ` Chunfeng Yun
2015-07-08 9:41 ` Chunfeng Yun
2015-07-08 9:41 ` [PATCH v2 1/5] dt-bindings: Add usb3.0 phy binding for MT65xx SoCs Chunfeng Yun
2015-07-08 9:41 ` Chunfeng Yun
2015-07-08 9:41 ` Chunfeng Yun
2015-07-10 5:10 ` Sascha Hauer
2015-07-10 5:10 ` Sascha Hauer
2015-07-10 5:10 ` Sascha Hauer
2015-07-14 6:19 ` chunfeng yun
2015-07-14 6:19 ` chunfeng yun
2015-07-14 6:19 ` chunfeng yun
2015-07-14 7:45 ` Sascha Hauer
2015-07-14 7:45 ` Sascha Hauer
2015-07-14 7:45 ` Sascha Hauer
2015-07-15 12:33 ` chunfeng yun
2015-07-15 12:33 ` chunfeng yun
2015-07-15 12:33 ` chunfeng yun
2015-07-08 9:41 ` [PATCH v2 2/5] dt-bindings: Add a binding for Mediatek xHCI host controller Chunfeng Yun
2015-07-08 9:41 ` Chunfeng Yun
2015-07-08 9:41 ` Chunfeng Yun
2015-07-10 8:31 ` Roger Quadros
2015-07-10 8:31 ` Roger Quadros
2015-07-10 8:31 ` Roger Quadros
2015-07-14 2:36 ` chunfeng yun
2015-07-14 2:36 ` chunfeng yun
2015-07-14 2:36 ` chunfeng yun
2015-07-14 2:50 ` chunfeng yun
2015-07-14 2:50 ` chunfeng yun
2015-07-14 2:50 ` chunfeng yun
2015-07-20 14:24 ` chunfeng yun
2015-07-20 14:24 ` chunfeng yun
2015-07-20 14:24 ` chunfeng yun
2015-07-08 9:41 ` [PATCH v2 3/5] usb: phy: add usb3.0 phy driver for mt65xx SoCs Chunfeng Yun
2015-07-08 9:41 ` Chunfeng Yun
2015-07-08 9:41 ` Chunfeng Yun
2015-07-10 6:42 ` Sascha Hauer
2015-07-10 6:42 ` Sascha Hauer
2015-07-10 6:42 ` Sascha Hauer
2015-07-20 15:41 ` chunfeng yun
2015-07-20 15:41 ` chunfeng yun
2015-07-20 15:41 ` chunfeng yun
2015-07-08 9:41 ` [PATCH v2 4/5] xhci: mediatek: support MTK xHCI host controller Chunfeng Yun
2015-07-08 9:41 ` Chunfeng Yun
2015-07-08 9:41 ` Chunfeng Yun
2015-07-13 14:52 ` John Crispin
2015-07-13 14:52 ` John Crispin
2015-07-13 14:52 ` John Crispin
2015-07-20 14:51 ` chunfeng yun
2015-07-20 14:51 ` chunfeng yun
2015-07-20 14:51 ` chunfeng yun
2015-07-08 9:41 ` [PATCH v2 5/5] arm64: dts: mediatek: add xHCI & usb phy for mt8173 Chunfeng Yun
2015-07-08 9:41 ` Chunfeng Yun
2015-07-08 9:41 ` Chunfeng Yun
2015-07-14 10:12 ` Daniel Kurtz
2015-07-14 10:12 ` Daniel Kurtz
2015-07-20 14:39 ` chunfeng yun
2015-07-20 14:39 ` chunfeng yun
2015-07-20 14:39 ` chunfeng yun
2015-07-20 14:51 ` Yingjoe Chen
2015-07-20 14:51 ` Yingjoe Chen
2015-07-20 14:51 ` Yingjoe Chen
2015-07-20 14:59 ` Daniel Kurtz [this message]
2015-07-20 14:59 ` Daniel Kurtz
2015-07-20 14:59 ` Daniel Kurtz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGS+omBokK5MXSGny0LpH8KBZup-d7XB_0WF=5JEg1BGbsJpMA@mail.gmail.com' \
--to=djkurtz@chromium.org \
--cc=balbi@ti.com \
--cc=chunfeng.yun@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathias.nyman@intel.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=rogerq@ti.com \
--cc=s.hauer@pengutronix.de \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.