From: Daniel Kurtz <djkurtz@chromium.org> To: Chunfeng Yun <chunfeng.yun@mediatek.com> Cc: Mathias Nyman <mathias.nyman@intel.com>, Mark Rutland <mark.rutland@arm.com>, "open list:OPEN FIRMWARE AND..." <devicetree@vger.kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, linux-usb@vger.kernel.org, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Felipe Balbi <balbi@ti.com>, Rob Herring <robh+dt@kernel.org>, linux-mediatek@lists.infradead.org, Matthias Brugger <matthias.bgg@gmail.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, Roger Quadros <rogerq@ti.com> Subject: Re: [PATCH v2 5/5] arm64: dts: mediatek: add xHCI & usb phy for mt8173 Date: Tue, 14 Jul 2015 18:12:22 +0800 [thread overview] Message-ID: <CAGS+omDfUv0KW8K45rLoN8qUV2Q_vgWFK_X4Ojb6K55G9tiehA@mail.gmail.com> (raw) In-Reply-To: <1436348468-4126-6-git-send-email-chunfeng.yun@mediatek.com> Hi Chunfeng, On Wed, Jul 8, 2015 at 5:41 PM, Chunfeng Yun <chunfeng.yun@mediatek.com> wrote: > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > --- > arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 15 +++++++++++++++ > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 27 +++++++++++++++++++++++++++ > 2 files changed, 42 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts > index f433c21..cb63dc3 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts > +++ b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts > @@ -13,6 +13,7 @@ > */ > > /dts-v1/; > +#include <dt-bindings/gpio/gpio.h> > #include "mt8173.dtsi" > > / { > @@ -32,6 +33,15 @@ > }; > > chosen { }; > + > + usb_p1_vbus: fixedregulator@0 { Why @0 ? > + compatible = "regulator-fixed"; > + regulator-name = "usb_vbus"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + gpio = <&pio 130 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + }; > }; > > &pwrap { > @@ -211,3 +221,8 @@ > &uart0 { > status = "okay"; > }; > + > +&usb { > + reg-vusb33-supply = <&mt6397_vusb_reg>; > + reg-vbus-supply = <&usb_p1_vbus>; > +}; > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > index 0696f8f..452bd0a 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > @@ -15,6 +15,7 @@ > #include <dt-bindings/interrupt-controller/irq.h> > #include <dt-bindings/interrupt-controller/arm-gic.h> > #include <dt-bindings/reset-controller/mt8173-resets.h> > +#include <dt-bindings/power/mt8173-power.h> Sort alphabetically, so: power before reset > #include "mt8173-pinfunc.h" > > / { > @@ -393,6 +394,32 @@ > #size-cells = <0>; > status = "disabled"; > }; > + > + usb: usb30@11270000 { > + compatible = "mediatek,mt8173-xhci"; > + reg = <0 0x11270000 0 0x1000>; > + interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_LOW>; > + usb-phy = <&u3phy>; > + usb3-lpm-capable; > + clocks = <&topckgen CLK_TOP_USB30_SEL>; > + clock-names = "sys_mac"; > + }; > + > + u3phy: usb-phy@11271000 { > + compatible = "mediatek,mt8173-u3phy"; > + reg = <0 0x11271000 0 0x3000>, > + <0 0x11280000 0 0x20000>; > + power-domains = <&scpsys MT8173_POWER_DOMAIN_USB>; > + usb-wakeup-ctrl = <&pericfg>; > + wakeup-src = <1>; > + u2port-num = <2>; Mediatek specific properties should be prefixed with "mediatek,". I also find it nicer if you put the standard properties first: (compatible, reg, clocks, clock-names, power-domains) then device specific properties: (usb-wakeup-ctrl, wakeup-src, u2port-num) and then the final: status="disabled"; This last is currently missing, so please add it, too. Also, is there some pinctrl settings that must be set for USB? Lastly, I could not quite figure out which patch this set was based on. Patch [0] mentions v4.2-rc1, however, the .dts changes in this patch did not apply cleanly. Perhaps it was based on a particular patch of Matthias tree? Thanks! -Dan > + clocks = <&pericfg CLK_PERI_USB0>, > + <&pericfg CLK_PERI_USB1>, > + <&apmixedsys CLK_APMIXED_REF2USB_TX>; > + clock-names = "wakeup_deb_p0", > + "wakeup_deb_p1", > + "u3phya_ref"; > + }; > }; > }; > > -- > 1.8.1.1.dirty > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: djkurtz@chromium.org (Daniel Kurtz) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 5/5] arm64: dts: mediatek: add xHCI & usb phy for mt8173 Date: Tue, 14 Jul 2015 18:12:22 +0800 [thread overview] Message-ID: <CAGS+omDfUv0KW8K45rLoN8qUV2Q_vgWFK_X4Ojb6K55G9tiehA@mail.gmail.com> (raw) In-Reply-To: <1436348468-4126-6-git-send-email-chunfeng.yun@mediatek.com> Hi Chunfeng, On Wed, Jul 8, 2015 at 5:41 PM, Chunfeng Yun <chunfeng.yun@mediatek.com> wrote: > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > --- > arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 15 +++++++++++++++ > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 27 +++++++++++++++++++++++++++ > 2 files changed, 42 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts > index f433c21..cb63dc3 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts > +++ b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts > @@ -13,6 +13,7 @@ > */ > > /dts-v1/; > +#include <dt-bindings/gpio/gpio.h> > #include "mt8173.dtsi" > > / { > @@ -32,6 +33,15 @@ > }; > > chosen { }; > + > + usb_p1_vbus: fixedregulator at 0 { Why @0 ? > + compatible = "regulator-fixed"; > + regulator-name = "usb_vbus"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + gpio = <&pio 130 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + }; > }; > > &pwrap { > @@ -211,3 +221,8 @@ > &uart0 { > status = "okay"; > }; > + > +&usb { > + reg-vusb33-supply = <&mt6397_vusb_reg>; > + reg-vbus-supply = <&usb_p1_vbus>; > +}; > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > index 0696f8f..452bd0a 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > @@ -15,6 +15,7 @@ > #include <dt-bindings/interrupt-controller/irq.h> > #include <dt-bindings/interrupt-controller/arm-gic.h> > #include <dt-bindings/reset-controller/mt8173-resets.h> > +#include <dt-bindings/power/mt8173-power.h> Sort alphabetically, so: power before reset > #include "mt8173-pinfunc.h" > > / { > @@ -393,6 +394,32 @@ > #size-cells = <0>; > status = "disabled"; > }; > + > + usb: usb30 at 11270000 { > + compatible = "mediatek,mt8173-xhci"; > + reg = <0 0x11270000 0 0x1000>; > + interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_LOW>; > + usb-phy = <&u3phy>; > + usb3-lpm-capable; > + clocks = <&topckgen CLK_TOP_USB30_SEL>; > + clock-names = "sys_mac"; > + }; > + > + u3phy: usb-phy at 11271000 { > + compatible = "mediatek,mt8173-u3phy"; > + reg = <0 0x11271000 0 0x3000>, > + <0 0x11280000 0 0x20000>; > + power-domains = <&scpsys MT8173_POWER_DOMAIN_USB>; > + usb-wakeup-ctrl = <&pericfg>; > + wakeup-src = <1>; > + u2port-num = <2>; Mediatek specific properties should be prefixed with "mediatek,". I also find it nicer if you put the standard properties first: (compatible, reg, clocks, clock-names, power-domains) then device specific properties: (usb-wakeup-ctrl, wakeup-src, u2port-num) and then the final: status="disabled"; This last is currently missing, so please add it, too. Also, is there some pinctrl settings that must be set for USB? Lastly, I could not quite figure out which patch this set was based on. Patch [0] mentions v4.2-rc1, however, the .dts changes in this patch did not apply cleanly. Perhaps it was based on a particular patch of Matthias tree? Thanks! -Dan > + clocks = <&pericfg CLK_PERI_USB0>, > + <&pericfg CLK_PERI_USB1>, > + <&apmixedsys CLK_APMIXED_REF2USB_TX>; > + clock-names = "wakeup_deb_p0", > + "wakeup_deb_p1", > + "u3phya_ref"; > + }; > }; > }; > > -- > 1.8.1.1.dirty > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2015-07-14 10:12 UTC|newest] Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-07-08 9:41 [PATCH v2 0/5] Mediatek xHCI support Chunfeng Yun 2015-07-08 9:41 ` Chunfeng Yun 2015-07-08 9:41 ` Chunfeng Yun 2015-07-08 9:41 ` [PATCH v2 1/5] dt-bindings: Add usb3.0 phy binding for MT65xx SoCs Chunfeng Yun 2015-07-08 9:41 ` Chunfeng Yun 2015-07-08 9:41 ` Chunfeng Yun 2015-07-10 5:10 ` Sascha Hauer 2015-07-10 5:10 ` Sascha Hauer 2015-07-10 5:10 ` Sascha Hauer 2015-07-14 6:19 ` chunfeng yun 2015-07-14 6:19 ` chunfeng yun 2015-07-14 6:19 ` chunfeng yun 2015-07-14 7:45 ` Sascha Hauer 2015-07-14 7:45 ` Sascha Hauer 2015-07-14 7:45 ` Sascha Hauer 2015-07-15 12:33 ` chunfeng yun 2015-07-15 12:33 ` chunfeng yun 2015-07-15 12:33 ` chunfeng yun 2015-07-08 9:41 ` [PATCH v2 2/5] dt-bindings: Add a binding for Mediatek xHCI host controller Chunfeng Yun 2015-07-08 9:41 ` Chunfeng Yun 2015-07-08 9:41 ` Chunfeng Yun 2015-07-10 8:31 ` Roger Quadros 2015-07-10 8:31 ` Roger Quadros 2015-07-10 8:31 ` Roger Quadros 2015-07-14 2:36 ` chunfeng yun 2015-07-14 2:36 ` chunfeng yun 2015-07-14 2:36 ` chunfeng yun 2015-07-14 2:50 ` chunfeng yun 2015-07-14 2:50 ` chunfeng yun 2015-07-14 2:50 ` chunfeng yun 2015-07-20 14:24 ` chunfeng yun 2015-07-20 14:24 ` chunfeng yun 2015-07-20 14:24 ` chunfeng yun 2015-07-08 9:41 ` [PATCH v2 3/5] usb: phy: add usb3.0 phy driver for mt65xx SoCs Chunfeng Yun 2015-07-08 9:41 ` Chunfeng Yun 2015-07-08 9:41 ` Chunfeng Yun 2015-07-10 6:42 ` Sascha Hauer 2015-07-10 6:42 ` Sascha Hauer 2015-07-10 6:42 ` Sascha Hauer 2015-07-20 15:41 ` chunfeng yun 2015-07-20 15:41 ` chunfeng yun 2015-07-20 15:41 ` chunfeng yun 2015-07-08 9:41 ` [PATCH v2 4/5] xhci: mediatek: support MTK xHCI host controller Chunfeng Yun 2015-07-08 9:41 ` Chunfeng Yun 2015-07-08 9:41 ` Chunfeng Yun 2015-07-13 14:52 ` John Crispin 2015-07-13 14:52 ` John Crispin 2015-07-13 14:52 ` John Crispin 2015-07-20 14:51 ` chunfeng yun 2015-07-20 14:51 ` chunfeng yun 2015-07-20 14:51 ` chunfeng yun 2015-07-08 9:41 ` [PATCH v2 5/5] arm64: dts: mediatek: add xHCI & usb phy for mt8173 Chunfeng Yun 2015-07-08 9:41 ` Chunfeng Yun 2015-07-08 9:41 ` Chunfeng Yun 2015-07-14 10:12 ` Daniel Kurtz [this message] 2015-07-14 10:12 ` Daniel Kurtz 2015-07-20 14:39 ` chunfeng yun 2015-07-20 14:39 ` chunfeng yun 2015-07-20 14:39 ` chunfeng yun 2015-07-20 14:51 ` Yingjoe Chen 2015-07-20 14:51 ` Yingjoe Chen 2015-07-20 14:51 ` Yingjoe Chen 2015-07-20 14:59 ` Daniel Kurtz 2015-07-20 14:59 ` Daniel Kurtz 2015-07-20 14:59 ` Daniel Kurtz
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAGS+omDfUv0KW8K45rLoN8qUV2Q_vgWFK_X4Ojb6K55G9tiehA@mail.gmail.com \ --to=djkurtz@chromium.org \ --cc=balbi@ti.com \ --cc=chunfeng.yun@mediatek.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-usb@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mathias.nyman@intel.com \ --cc=matthias.bgg@gmail.com \ --cc=robh+dt@kernel.org \ --cc=rogerq@ti.com \ --cc=s.hauer@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.