* [PATCH] ARM: Mark ret_fast_syscall as a function
@ 2015-07-14 12:45 ` Drew Richardson
0 siblings, 0 replies; 8+ messages in thread
From: Drew Richardson @ 2015-07-14 12:45 UTC (permalink / raw)
To: linux, Dave.Martin, christoffer.dall, nico, linux-arm-kernel,
linux-kernel
Cc: wade.cherry, Drew Richardson
ret_fast_syscall runs when user space makes a syscall. However it
needs to be marked as such so the ELF information is correct. Before
it was:
101: 8000f300 0 NOTYPE LOCAL DEFAULT 2 ret_fast_syscall
But with this change it correctly shows as:
101: 8000f300 96 FUNC LOCAL DEFAULT 2 ret_fast_syscall
I see this function when using perf to unwind call stacks from kernel
space to user space. Without this change I would need to add some
special case logic when using the vmlinux ELF information.
Signed-off-by: Drew Richardson <drew.richardson@arm.com>
---
arch/arm/kernel/entry-common.S | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/kernel/entry-common.S b/arch/arm/kernel/entry-common.S
index 92828a1dec80..b48dd4f37f80 100644
--- a/arch/arm/kernel/entry-common.S
+++ b/arch/arm/kernel/entry-common.S
@@ -61,6 +61,7 @@ work_pending:
movlt scno, #(__NR_restart_syscall - __NR_SYSCALL_BASE)
ldmia sp, {r0 - r6} @ have to reload r0 - r6
b local_restart @ ... and off we go
+ENDPROC(ret_fast_syscall)
/*
* "slow" syscall return path. "why" tells us if this was a real syscall.
--
2.1.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] ARM: Mark ret_fast_syscall as a function
@ 2015-07-14 12:45 ` Drew Richardson
0 siblings, 0 replies; 8+ messages in thread
From: Drew Richardson @ 2015-07-14 12:45 UTC (permalink / raw)
To: linux-arm-kernel
ret_fast_syscall runs when user space makes a syscall. However it
needs to be marked as such so the ELF information is correct. Before
it was:
101: 8000f300 0 NOTYPE LOCAL DEFAULT 2 ret_fast_syscall
But with this change it correctly shows as:
101: 8000f300 96 FUNC LOCAL DEFAULT 2 ret_fast_syscall
I see this function when using perf to unwind call stacks from kernel
space to user space. Without this change I would need to add some
special case logic when using the vmlinux ELF information.
Signed-off-by: Drew Richardson <drew.richardson@arm.com>
---
arch/arm/kernel/entry-common.S | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/kernel/entry-common.S b/arch/arm/kernel/entry-common.S
index 92828a1dec80..b48dd4f37f80 100644
--- a/arch/arm/kernel/entry-common.S
+++ b/arch/arm/kernel/entry-common.S
@@ -61,6 +61,7 @@ work_pending:
movlt scno, #(__NR_restart_syscall - __NR_SYSCALL_BASE)
ldmia sp, {r0 - r6} @ have to reload r0 - r6
b local_restart @ ... and off we go
+ENDPROC(ret_fast_syscall)
/*
* "slow" syscall return path. "why" tells us if this was a real syscall.
--
2.1.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: Mark ret_fast_syscall as a function
2015-07-14 12:45 ` Drew Richardson
@ 2015-08-06 17:08 ` Drew Richardson
-1 siblings, 0 replies; 8+ messages in thread
From: Drew Richardson @ 2015-08-06 17:08 UTC (permalink / raw)
To: linux@arm.linux.org.uk, Dave P Martin,
christoffer.dall@linaro.org, nico@linaro.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: Wade Cherry, pawel.moll
On Tue, Jul 14, 2015 at 01:45:57PM +0100, Drew Richardson wrote:
> ret_fast_syscall runs when user space makes a syscall. However it
> needs to be marked as such so the ELF information is correct. Before
> it was:
>
> 101: 8000f300 0 NOTYPE LOCAL DEFAULT 2 ret_fast_syscall
>
> But with this change it correctly shows as:
>
> 101: 8000f300 96 FUNC LOCAL DEFAULT 2 ret_fast_syscall
>
> I see this function when using perf to unwind call stacks from kernel
> space to user space. Without this change I would need to add some
> special case logic when using the vmlinux ELF information.
>
> Signed-off-by: Drew Richardson <drew.richardson@arm.com>
I haven't heard any further comments on this, did this get merged and
I just didn't notice? Or did I forget to add someone?
Thanks,
Drew
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: Mark ret_fast_syscall as a function
@ 2015-08-06 17:08 ` Drew Richardson
0 siblings, 0 replies; 8+ messages in thread
From: Drew Richardson @ 2015-08-06 17:08 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jul 14, 2015 at 01:45:57PM +0100, Drew Richardson wrote:
> ret_fast_syscall runs when user space makes a syscall. However it
> needs to be marked as such so the ELF information is correct. Before
> it was:
>
> 101: 8000f300 0 NOTYPE LOCAL DEFAULT 2 ret_fast_syscall
>
> But with this change it correctly shows as:
>
> 101: 8000f300 96 FUNC LOCAL DEFAULT 2 ret_fast_syscall
>
> I see this function when using perf to unwind call stacks from kernel
> space to user space. Without this change I would need to add some
> special case logic when using the vmlinux ELF information.
>
> Signed-off-by: Drew Richardson <drew.richardson@arm.com>
I haven't heard any further comments on this, did this get merged and
I just didn't notice? Or did I forget to add someone?
Thanks,
Drew
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: Mark ret_fast_syscall as a function
2015-08-06 17:08 ` Drew Richardson
@ 2015-08-06 17:30 ` Nicolas Pitre
-1 siblings, 0 replies; 8+ messages in thread
From: Nicolas Pitre @ 2015-08-06 17:30 UTC (permalink / raw)
To: Drew Richardson
Cc: linux@arm.linux.org.uk, Dave P Martin,
christoffer.dall@linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Wade Cherry, Pawel Moll
On Thu, 6 Aug 2015, Drew Richardson wrote:
> On Tue, Jul 14, 2015 at 01:45:57PM +0100, Drew Richardson wrote:
> > ret_fast_syscall runs when user space makes a syscall. However it
> > needs to be marked as such so the ELF information is correct. Before
> > it was:
> >
> > 101: 8000f300 0 NOTYPE LOCAL DEFAULT 2 ret_fast_syscall
> >
> > But with this change it correctly shows as:
> >
> > 101: 8000f300 96 FUNC LOCAL DEFAULT 2 ret_fast_syscall
> >
> > I see this function when using perf to unwind call stacks from kernel
> > space to user space. Without this change I would need to add some
> > special case logic when using the vmlinux ELF information.
> >
> > Signed-off-by: Drew Richardson <drew.richardson@arm.com>
>
> I haven't heard any further comments on this, did this get merged and
> I just didn't notice? Or did I forget to add someone?
Most likely that it is so trivial that nobody paid much attention.
FWIW, you can add
Acked-by: Nicolas Pitre <nico@linaro.org>
and submit it here: http://www.arm.linux.org.uk/developer/patches/
Nicolas
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: Mark ret_fast_syscall as a function
@ 2015-08-06 17:30 ` Nicolas Pitre
0 siblings, 0 replies; 8+ messages in thread
From: Nicolas Pitre @ 2015-08-06 17:30 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, 6 Aug 2015, Drew Richardson wrote:
> On Tue, Jul 14, 2015 at 01:45:57PM +0100, Drew Richardson wrote:
> > ret_fast_syscall runs when user space makes a syscall. However it
> > needs to be marked as such so the ELF information is correct. Before
> > it was:
> >
> > 101: 8000f300 0 NOTYPE LOCAL DEFAULT 2 ret_fast_syscall
> >
> > But with this change it correctly shows as:
> >
> > 101: 8000f300 96 FUNC LOCAL DEFAULT 2 ret_fast_syscall
> >
> > I see this function when using perf to unwind call stacks from kernel
> > space to user space. Without this change I would need to add some
> > special case logic when using the vmlinux ELF information.
> >
> > Signed-off-by: Drew Richardson <drew.richardson@arm.com>
>
> I haven't heard any further comments on this, did this get merged and
> I just didn't notice? Or did I forget to add someone?
Most likely that it is so trivial that nobody paid much attention.
FWIW, you can add
Acked-by: Nicolas Pitre <nico@linaro.org>
and submit it here: http://www.arm.linux.org.uk/developer/patches/
Nicolas
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: Mark ret_fast_syscall as a function
2015-08-06 17:30 ` Nicolas Pitre
@ 2015-08-06 17:52 ` Drew Richardson
-1 siblings, 0 replies; 8+ messages in thread
From: Drew Richardson @ 2015-08-06 17:52 UTC (permalink / raw)
To: Nicolas Pitre
Cc: linux@arm.linux.org.uk, Dave P Martin,
christoffer.dall@linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Wade Cherry, Pawel Moll
On Thu, Aug 06, 2015 at 06:30:40PM +0100, Nicolas Pitre wrote:
> On Thu, 6 Aug 2015, Drew Richardson wrote:
>
> > On Tue, Jul 14, 2015 at 01:45:57PM +0100, Drew Richardson wrote:
> > > ret_fast_syscall runs when user space makes a syscall. However it
> > > needs to be marked as such so the ELF information is correct. Before
> > > it was:
> > >
> > > 101: 8000f300 0 NOTYPE LOCAL DEFAULT 2 ret_fast_syscall
> > >
> > > But with this change it correctly shows as:
> > >
> > > 101: 8000f300 96 FUNC LOCAL DEFAULT 2 ret_fast_syscall
> > >
> > > I see this function when using perf to unwind call stacks from kernel
> > > space to user space. Without this change I would need to add some
> > > special case logic when using the vmlinux ELF information.
> > >
> > > Signed-off-by: Drew Richardson <drew.richardson@arm.com>
> >
> > I haven't heard any further comments on this, did this get merged and
> > I just didn't notice? Or did I forget to add someone?
>
> Most likely that it is so trivial that nobody paid much attention.
>
> FWIW, you can add
>
> Acked-by: Nicolas Pitre <nico@linaro.org>
>
> and submit it here: http://www.arm.linux.org.uk/developer/patches/
>
>
> Nicolas
>
Done, thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: Mark ret_fast_syscall as a function
@ 2015-08-06 17:52 ` Drew Richardson
0 siblings, 0 replies; 8+ messages in thread
From: Drew Richardson @ 2015-08-06 17:52 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Aug 06, 2015 at 06:30:40PM +0100, Nicolas Pitre wrote:
> On Thu, 6 Aug 2015, Drew Richardson wrote:
>
> > On Tue, Jul 14, 2015 at 01:45:57PM +0100, Drew Richardson wrote:
> > > ret_fast_syscall runs when user space makes a syscall. However it
> > > needs to be marked as such so the ELF information is correct. Before
> > > it was:
> > >
> > > 101: 8000f300 0 NOTYPE LOCAL DEFAULT 2 ret_fast_syscall
> > >
> > > But with this change it correctly shows as:
> > >
> > > 101: 8000f300 96 FUNC LOCAL DEFAULT 2 ret_fast_syscall
> > >
> > > I see this function when using perf to unwind call stacks from kernel
> > > space to user space. Without this change I would need to add some
> > > special case logic when using the vmlinux ELF information.
> > >
> > > Signed-off-by: Drew Richardson <drew.richardson@arm.com>
> >
> > I haven't heard any further comments on this, did this get merged and
> > I just didn't notice? Or did I forget to add someone?
>
> Most likely that it is so trivial that nobody paid much attention.
>
> FWIW, you can add
>
> Acked-by: Nicolas Pitre <nico@linaro.org>
>
> and submit it here: http://www.arm.linux.org.uk/developer/patches/
>
>
> Nicolas
>
Done, thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-08-06 17:54 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-14 12:45 [PATCH] ARM: Mark ret_fast_syscall as a function Drew Richardson
2015-07-14 12:45 ` Drew Richardson
2015-08-06 17:08 ` Drew Richardson
2015-08-06 17:08 ` Drew Richardson
2015-08-06 17:30 ` Nicolas Pitre
2015-08-06 17:30 ` Nicolas Pitre
2015-08-06 17:52 ` Drew Richardson
2015-08-06 17:52 ` Drew Richardson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.