Re: [PATCH v3 4/4] arm64: dts: add description for solidrun cn9131 solidwan board

From: Josua Mayer <josua@solid-run.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Gregory Clement <gregory.clement@bootlin.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Rob Herring <robh@kernel.org>,
	Yazan Shhady <yazan.shhady@solid-run.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 4/4] arm64: dts: add description for solidrun cn9131 solidwan board
Date: Fri, 26 Apr 2024 18:51:02 +0000	[thread overview]
Message-ID: <32ec3ef4-0ecc-4ae2-bf76-c7b10f54a583@solid-run.com> (raw)
In-Reply-To: <d0426bb3-1f40-48ed-9032-6ffdce455cd4@lunn.ch>

Am 26.04.24 um 20:18 schrieb Andrew Lunn:
>>>> Colours are similar to RJ45 connectors (yellow, green),
>>>> and are intended for the same purpose: link, activity.
>>> For the switch LEDs you used label = "LED10"; Does the silk screen
>>> have similar numbers for these LEDs?
>> Correct, on CN9130 Clearfog Pro DSA switch, all LEDs are labeled
>> individually on the silk screen.
>>
>> The SolidWAN SFP leds are dual-colour leds with 3 terminals:
>> anode to 3.3V, 2x cathode to gpio-controlled transistors.
>> They are labeled on the silk-screen as "LED9", "LED10".
>>
>> Duplicate labels are not great, is there a better way?
>> old style "LED9:green" e.g. ...?
> So you have copper LEDs and SFP LEDs, each with the same silk screen
> label? Maybe put 'copper' and 'sfp' as a prefix into the label?

No, not quite.

We have 2x SFP Connectors.
On the bottom side of PCB immediately below each connector is
a single LED (as in physical component), each with a silk-screen label.

"J28"/"SFP 0": "LED10"
"J42"/"SFP 1": "LED9"

The problem is that these leds are each two leds in single-package,
which is why I put 4 led nodes in dts, two labeled "sfp-0",
other two "sfp-1".
But I don't think this duplication of label in dts is a good idea.