Re: [PATCH v3 4/4] arm64: dts: add description for solidrun cn9131 solidwan board

From: Josua Mayer <josua@solid-run.com>
To: Andrew Lunn <andrew@lunn.ch>,
	Gregory Clement <gregory.clement@bootlin.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Rob Herring <robh@kernel.org>
Cc: Yazan Shhady <yazan.shhady@solid-run.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 4/4] arm64: dts: add description for solidrun cn9131 solidwan board
Date: Sun, 14 Apr 2024 13:18:56 +0000	[thread overview]
Message-ID: <3958052d-fc09-4c4c-a9e3-4923871cff44@solid-run.com> (raw)
In-Reply-To: <20240414-cn9130-som-v3-4-350a67d44e0a@solid-run.com>

Am 14.04.24 um 14:58 schrieb Josua Mayer:
> Add description for the SolidRun CN9131 SolidWAN, based on CN9130 SoM
> with an extra communication  processor on the carrier board.
>
> This board differentiates itself from CN9130 Clearfog by providing
> additional SoC native network interfaces and pci buses:
> 2x 10Gbps SFP+
> 4x 1Gbps RJ45
> 1x miniPCI-E
> 1x m.2 b-key with sata, usb-2.0 and usb-3.0
> 1x m.2 m-key with pcie and usb-2.0
> 1x m.2 b-key with pcie, usb-2.0, usb-3.0 and 2x sim slots
> 1x mpcie with pcie only
> 2x type-a usb-2.0/3.0
>
> Signed-off-by: Josua Mayer <josua@solid-run.com>
> ---
>  arch/arm64/boot/dts/marvell/Makefile               |   1 +
>  arch/arm64/boot/dts/marvell/cn9131-cf-solidwan.dts | 653 +++++++++++++++++++++
>  2 files changed, 654 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/Makefile b/arch/arm64/boot/dts/marvell/Makefile
> index 019f2251d696..16f9d7156d9f 100644
> --- a/arch/arm64/boot/dts/marvell/Makefile
> +++ b/arch/arm64/boot/dts/marvell/Makefile
> @@ -30,3 +30,4 @@ dtb-$(CONFIG_ARCH_MVEBU) += ac5x-rd-carrier-cn9131.dtb
>  dtb-$(CONFIG_ARCH_MVEBU) += ac5-98dx35xx-rd.dtb
>  dtb-$(CONFIG_ARCH_MVEBU) += cn9130-cf-base.dtb
>  dtb-$(CONFIG_ARCH_MVEBU) += cn9130-cf-pro.dtb
> +dtb-$(CONFIG_ARCH_MVEBU) += cn9131-cf-solidwan.dtb
> diff --git a/arch/arm64/boot/dts/marvell/cn9131-cf-solidwan.dts b/arch/arm64/boot/dts/marvell/cn9131-cf-solidwan.dts
cut
> +	leds {
> +		compatible = "gpio-leds";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&cp0_led_pins &cp1_led_pins>;
> +
> +		/* for sfp-1 (J42) */
> +		led-sfp1-activity {
> +			label = "sfp1";
> +			gpios = <&cp0_gpio1 7 GPIO_ACTIVE_HIGH>;
> +			color = <LED_COLOR_ID_GREEN>;
> +		};
> +
> +		/* for sfp-1 (J42) */
> +		led-sfp1-link {
> +			label = "sfp1";
> +			gpios = <&cp0_gpio1 4 GPIO_ACTIVE_HIGH>;
> +			color = <LED_COLOR_ID_YELLOW>;
> +		};
> +
> +		/* (J28) */
> +		led-sfp0-activity {
> +			label = "sfp0";
> +			gpios = <&cp1_gpio2 22 GPIO_ACTIVE_HIGH>;
> +			color = <LED_COLOR_ID_GREEN>;
> +		};
> +
> +		/* (J28) */
> +		led-sfp0-link {
> +			label = "sfp0";
> +			gpios = <&cp1_gpio2 23 GPIO_ACTIVE_HIGH>;
> +			color = <LED_COLOR_ID_YELLOW>;
> +		};
> +	};
> +
Here I am uncertain what to put in the label.
Each SFP has a single dual-color (3 terminals) LED,
with one gpio controlling each colour.

Colours are similar to RJ45 connectors (yellow, green),
and are intended for the same purpose: link, activity.