From: Josua Mayer <josua@solid-run.com> To: Andrew Lunn <andrew@lunn.ch>, Gregory Clement <gregory.clement@bootlin.com>, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Rob Herring <robh@kernel.org> Cc: Yazan Shhady <yazan.shhady@solid-run.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v3 3/4] arm64: dts: add description for solidrun cn9130 som and clearfog boards Date: Sun, 14 Apr 2024 13:02:13 +0000 [thread overview] Message-ID: <8d0cd34c-ca04-45db-a95b-3bf5e3800958@solid-run.com> (raw) In-Reply-To: <20240414-cn9130-som-v3-3-350a67d44e0a@solid-run.com> Am 14.04.24 um 14:58 schrieb Josua Mayer: > Add description for the SolidRun CN9130 SoM, and Clearfog Base / Pro > reference boards. > > The SoM has been designed as a pin-compatible replacement for the older > Armada 388 based SoM. Therefore it supports the same boards and a > similar feature set. > > Most notable upgrades: > - 4x Cortex-A72 > - 10Gbps SFP > - Both eMMC and SD supported at the same time > > The developer first supporting this product at SolidRun decided to use > different filenames for the DTBs: Armada 388 uses the full > "clearfog" string while cn9130 uses the abbreviation "cf". > This name is already hard-coded in pre-installed vendor u-boot and can > not be changed easily. > > NOTICE IN CASE ANYBODY WANTS TO SELF-UPGRADE: > CN9130 SoM has a different footprint from Armada 388 SoM. > Components on the carrier board below the SoM may collide causing > damage, such as on Clearfog Base. > > Signed-off-by: Josua Mayer <josua@solid-run.com> > --- Previous version had received an ack from Krzysztof Kozlowski, which I dropped because I made additional changes. To simplify review, please find below the incremental changes from v2 to v3: From 8e32db3d5b4feced98f26695780c5253b928bb14 Mon Sep 17 00:00:00 2001 From: Josua Mayer <josua@solid-run.com> Date: Fri, 5 Apr 2024 17:35:52 +0200 Subject: [PATCH] arm64: dts: cn9131-cf-solidwan: minor tweaks 1. move legacy armada-388 netdev aliases to carrier: Legacy port numbering is only useful for platforms previously using the armada-388 som, and can be achieved in carrier dts. SoM dts can follow soc port numbering. 2. Fix two status property mistakes: one duplicate and one not last property. 3. Add pinctrl for spi chip-select 1, which is exposed on carrier mikrobus header. 4. Specify spi bus max frequencies based on som limitations. Signed-off-by: Josua Mayer <josua@solid-run.com> --- arch/arm64/boot/dts/marvell/cn9130-cf-pro.dts | 10 ++++++++++ arch/arm64/boot/dts/marvell/cn9130-cf.dtsi | 4 ++++ arch/arm64/boot/dts/marvell/cn9130-sr-som.dtsi | 13 +++++++------ 3 files changed, 21 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/marvell/cn9130-cf-pro.dts b/arch/arm64/boot/dts/marvell/cn9130-cf-pro.dts index 0b95d5f7acfd..15c74d584dbd 100644 --- a/arch/arm64/boot/dts/marvell/cn9130-cf-pro.dts +++ b/arch/arm64/boot/dts/marvell/cn9130-cf-pro.dts @@ -336,6 +336,16 @@ rear_button_pins: cp0-rear-button-pins { marvell,pins = "mpp32"; marvell,function = "gpio"; }; + + cp0_spi1_cs1_pins: cp0-spi1-cs1-pins { + marvell,pins = "mpp12"; + marvell,function = "spi1"; + }; +}; + +&cp0_spi1 { + /* add pin for chip-select 1 on mikrobus */ + pinctrl-0 = <&cp0_spi1_pins &cp0_spi1_cs1_pins>; }; /* diff --git a/arch/arm64/boot/dts/marvell/cn9130-cf.dtsi b/arch/arm64/boot/dts/marvell/cn9130-cf.dtsi index 53aedddf0e26..dcbbdbb9b25a 100644 --- a/arch/arm64/boot/dts/marvell/cn9130-cf.dtsi +++ b/arch/arm64/boot/dts/marvell/cn9130-cf.dtsi @@ -8,6 +8,10 @@ / { aliases { + /* label nics same order as armada 388 clearfog */ + ethernet0 = &cp0_eth2; + ethernet1 = &cp0_eth1; + ethernet2 = &cp0_eth0; i2c1 = &cp0_i2c1; mmc1 = &cp0_sdhci0; }; diff --git a/arch/arm64/boot/dts/marvell/cn9130-sr-som.dtsi b/arch/arm64/boot/dts/marvell/cn9130-sr-som.dtsi index ec08066fb6e8..8f0238a45a58 100644 --- a/arch/arm64/boot/dts/marvell/cn9130-sr-som.dtsi +++ b/arch/arm64/boot/dts/marvell/cn9130-sr-som.dtsi @@ -11,10 +11,9 @@ / { compatible = "solidrun,cn9130-sr-som", "marvell,cn9130"; aliases { - /* label nics like armada-388 som */ - ethernet0 = &cp0_eth2; + ethernet0 = &cp0_eth0; ethernet1 = &cp0_eth1; - ethernet2 = &cp0_eth0; + ethernet2 = &cp0_eth2; i2c0 = &cp0_i2c0; mmc0 = &ap_sdhci0; rtc0 = &cp0_rtc; @@ -82,7 +81,6 @@ &cp0_eth2 { }; &cp0_i2c0 { - status = "okay"; pinctrl-names = "default"; pinctrl-0 = <&cp0_i2c0_pins>; clock-frequency = <100000>; @@ -96,8 +94,8 @@ som_eeprom: eeprom@53 { }; &cp0_mdio { - status = "okay"; pinctrl-0 = <&cp0_mdio_pins>; + status = "okay"; /* assembly option */ cp0_eth2_phy: ethernet-phy@0 { @@ -109,11 +107,14 @@ &cp0_spi1 { status = "okay"; pinctrl-names = "default"; pinctrl-0 = <&cp0_spi1_pins>; + /* max speed limited by a mux */ + spi-max-frequency = <1800000000>; flash@0 { compatible = "jedec,spi-nor"; reg = <0>; - spi-max-frequency = <10000000>; + /* read command supports max. 50MHz */ + spi-max-frequency = <50000000>; }; }; -- 2.35.3
WARNING: multiple messages have this Message-ID (diff)
From: Josua Mayer <josua@solid-run.com> To: Andrew Lunn <andrew@lunn.ch>, Gregory Clement <gregory.clement@bootlin.com>, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Rob Herring <robh@kernel.org> Cc: Yazan Shhady <yazan.shhady@solid-run.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v3 3/4] arm64: dts: add description for solidrun cn9130 som and clearfog boards Date: Sun, 14 Apr 2024 13:02:13 +0000 [thread overview] Message-ID: <8d0cd34c-ca04-45db-a95b-3bf5e3800958@solid-run.com> (raw) In-Reply-To: <20240414-cn9130-som-v3-3-350a67d44e0a@solid-run.com> Am 14.04.24 um 14:58 schrieb Josua Mayer: > Add description for the SolidRun CN9130 SoM, and Clearfog Base / Pro > reference boards. > > The SoM has been designed as a pin-compatible replacement for the older > Armada 388 based SoM. Therefore it supports the same boards and a > similar feature set. > > Most notable upgrades: > - 4x Cortex-A72 > - 10Gbps SFP > - Both eMMC and SD supported at the same time > > The developer first supporting this product at SolidRun decided to use > different filenames for the DTBs: Armada 388 uses the full > "clearfog" string while cn9130 uses the abbreviation "cf". > This name is already hard-coded in pre-installed vendor u-boot and can > not be changed easily. > > NOTICE IN CASE ANYBODY WANTS TO SELF-UPGRADE: > CN9130 SoM has a different footprint from Armada 388 SoM. > Components on the carrier board below the SoM may collide causing > damage, such as on Clearfog Base. > > Signed-off-by: Josua Mayer <josua@solid-run.com> > --- Previous version had received an ack from Krzysztof Kozlowski, which I dropped because I made additional changes. To simplify review, please find below the incremental changes from v2 to v3: From 8e32db3d5b4feced98f26695780c5253b928bb14 Mon Sep 17 00:00:00 2001 From: Josua Mayer <josua@solid-run.com> Date: Fri, 5 Apr 2024 17:35:52 +0200 Subject: [PATCH] arm64: dts: cn9131-cf-solidwan: minor tweaks 1. move legacy armada-388 netdev aliases to carrier: Legacy port numbering is only useful for platforms previously using the armada-388 som, and can be achieved in carrier dts. SoM dts can follow soc port numbering. 2. Fix two status property mistakes: one duplicate and one not last property. 3. Add pinctrl for spi chip-select 1, which is exposed on carrier mikrobus header. 4. Specify spi bus max frequencies based on som limitations. Signed-off-by: Josua Mayer <josua@solid-run.com> --- arch/arm64/boot/dts/marvell/cn9130-cf-pro.dts | 10 ++++++++++ arch/arm64/boot/dts/marvell/cn9130-cf.dtsi | 4 ++++ arch/arm64/boot/dts/marvell/cn9130-sr-som.dtsi | 13 +++++++------ 3 files changed, 21 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/marvell/cn9130-cf-pro.dts b/arch/arm64/boot/dts/marvell/cn9130-cf-pro.dts index 0b95d5f7acfd..15c74d584dbd 100644 --- a/arch/arm64/boot/dts/marvell/cn9130-cf-pro.dts +++ b/arch/arm64/boot/dts/marvell/cn9130-cf-pro.dts @@ -336,6 +336,16 @@ rear_button_pins: cp0-rear-button-pins { marvell,pins = "mpp32"; marvell,function = "gpio"; }; + + cp0_spi1_cs1_pins: cp0-spi1-cs1-pins { + marvell,pins = "mpp12"; + marvell,function = "spi1"; + }; +}; + +&cp0_spi1 { + /* add pin for chip-select 1 on mikrobus */ + pinctrl-0 = <&cp0_spi1_pins &cp0_spi1_cs1_pins>; }; /* diff --git a/arch/arm64/boot/dts/marvell/cn9130-cf.dtsi b/arch/arm64/boot/dts/marvell/cn9130-cf.dtsi index 53aedddf0e26..dcbbdbb9b25a 100644 --- a/arch/arm64/boot/dts/marvell/cn9130-cf.dtsi +++ b/arch/arm64/boot/dts/marvell/cn9130-cf.dtsi @@ -8,6 +8,10 @@ / { aliases { + /* label nics same order as armada 388 clearfog */ + ethernet0 = &cp0_eth2; + ethernet1 = &cp0_eth1; + ethernet2 = &cp0_eth0; i2c1 = &cp0_i2c1; mmc1 = &cp0_sdhci0; }; diff --git a/arch/arm64/boot/dts/marvell/cn9130-sr-som.dtsi b/arch/arm64/boot/dts/marvell/cn9130-sr-som.dtsi index ec08066fb6e8..8f0238a45a58 100644 --- a/arch/arm64/boot/dts/marvell/cn9130-sr-som.dtsi +++ b/arch/arm64/boot/dts/marvell/cn9130-sr-som.dtsi @@ -11,10 +11,9 @@ / { compatible = "solidrun,cn9130-sr-som", "marvell,cn9130"; aliases { - /* label nics like armada-388 som */ - ethernet0 = &cp0_eth2; + ethernet0 = &cp0_eth0; ethernet1 = &cp0_eth1; - ethernet2 = &cp0_eth0; + ethernet2 = &cp0_eth2; i2c0 = &cp0_i2c0; mmc0 = &ap_sdhci0; rtc0 = &cp0_rtc; @@ -82,7 +81,6 @@ &cp0_eth2 { }; &cp0_i2c0 { - status = "okay"; pinctrl-names = "default"; pinctrl-0 = <&cp0_i2c0_pins>; clock-frequency = <100000>; @@ -96,8 +94,8 @@ som_eeprom: eeprom@53 { }; &cp0_mdio { - status = "okay"; pinctrl-0 = <&cp0_mdio_pins>; + status = "okay"; /* assembly option */ cp0_eth2_phy: ethernet-phy@0 { @@ -109,11 +107,14 @@ &cp0_spi1 { status = "okay"; pinctrl-names = "default"; pinctrl-0 = <&cp0_spi1_pins>; + /* max speed limited by a mux */ + spi-max-frequency = <1800000000>; flash@0 { compatible = "jedec,spi-nor"; reg = <0>; - spi-max-frequency = <10000000>; + /* read command supports max. 50MHz */ + spi-max-frequency = <50000000>; }; }; -- 2.35.3 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-04-14 13:02 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-04-14 12:58 [PATCH v3 0/4] arm64: dts: add description for solidrun cn9130 som and clearfog boards Josua Mayer 2024-04-14 12:58 ` Josua Mayer 2024-04-14 12:58 ` [PATCH v3 1/4] dt-bindings: arm64: marvell: add solidrun cn9130 som based boards Josua Mayer 2024-04-14 12:58 ` Josua Mayer 2024-04-22 13:38 ` Andrew Lunn 2024-04-22 13:38 ` Andrew Lunn 2024-04-14 12:58 ` [PATCH v3 2/4] dt-bindings: arm64: marvell: add solidrun cn9132 CEX-7 evaluation board Josua Mayer 2024-04-14 12:58 ` Josua Mayer 2024-04-22 13:38 ` Andrew Lunn 2024-04-22 13:38 ` Andrew Lunn 2024-04-14 12:58 ` [PATCH v3 3/4] arm64: dts: add description for solidrun cn9130 som and clearfog boards Josua Mayer 2024-04-14 12:58 ` Josua Mayer 2024-04-14 13:02 ` Josua Mayer [this message] 2024-04-14 13:02 ` Josua Mayer 2024-04-14 13:30 ` Krzysztof Kozlowski 2024-04-14 13:30 ` Krzysztof Kozlowski 2024-04-22 13:38 ` Andrew Lunn 2024-04-22 13:38 ` Andrew Lunn 2024-04-14 12:58 ` [PATCH v3 4/4] arm64: dts: add description for solidrun cn9131 solidwan board Josua Mayer 2024-04-14 12:58 ` Josua Mayer 2024-04-14 13:07 ` Josua Mayer 2024-04-14 13:07 ` Josua Mayer 2024-04-14 13:18 ` Josua Mayer 2024-04-14 13:18 ` Josua Mayer 2024-04-22 13:37 ` Andrew Lunn 2024-04-22 13:37 ` Andrew Lunn 2024-04-22 13:47 ` Josua Mayer 2024-04-22 13:47 ` Josua Mayer 2024-04-26 18:18 ` Andrew Lunn 2024-04-26 18:18 ` Andrew Lunn 2024-04-26 18:51 ` Josua Mayer 2024-04-26 18:51 ` Josua Mayer 2024-04-26 19:43 ` Andrew Lunn 2024-04-26 19:43 ` Andrew Lunn 2024-04-15 18:47 ` [PATCH v3 0/4] arm64: dts: add description for solidrun cn9130 som and clearfog boards Rob Herring 2024-04-15 18:47 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8d0cd34c-ca04-45db-a95b-3bf5e3800958@solid-run.com \ --to=josua@solid-run.com \ --cc=andrew@lunn.ch \ --cc=conor+dt@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=gregory.clement@bootlin.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=robh@kernel.org \ --cc=sebastian.hesselbarth@gmail.com \ --cc=yazan.shhady@solid-run.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.