From: Paul Moore <paul@paul-moore.com> To: David Howells <dhowells@redhat.com> Cc: linux-unionfs@vger.kernel.org, selinux@tycho.nsa.gov, linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/7] Overlayfs: Use copy-up security hooks Date: Fri, 07 Nov 2014 16:39:21 -0500 [thread overview] Message-ID: <4109261.WfcAOoSvNG@sifl> (raw) In-Reply-To: <20141105154238.2555.85960.stgit@warthog.procyon.org.uk> On Wednesday, November 05, 2014 03:42:38 PM David Howells wrote: > Use the copy-up security hooks previously provided to allow an LSM to adjust > the security on a newly created copy and to filter the xattrs copied to > that file copy. > > Signed-off-by: David Howells <dhowells@redhat.com> > --- > > fs/overlayfs/copy_up.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/fs/overlayfs/copy_up.c b/fs/overlayfs/copy_up.c > index ea10a8719107..53a357d0a214 100644 > --- a/fs/overlayfs/copy_up.c > +++ b/fs/overlayfs/copy_up.c > @@ -58,6 +58,14 @@ int ovl_copy_xattr(struct dentry *old, struct dentry > *new) error = size; > goto out_free_value; > } > + error = security_inode_copy_up_xattr(old, new, > + name, value, &size); So the LSM must modify the xattr in place? I suppose that since the @value is allocated to the max size it shouldn't be a problem. Just checking ... > + if (error < 0) > + goto out_free_value; > + if (error == 1) { > + error = 0; > + continue; /* Discard */ > + } > error = vfs_setxattr(new, name, value, size, 0); > if (error) > goto out_free_value; -- paul moore www.paul-moore.com
WARNING: multiple messages have this Message-ID (diff)
From: Paul Moore <paul@paul-moore.com> To: David Howells <dhowells@redhat.com> Cc: linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-unionfs@vger.kernel.org, selinux@tycho.nsa.gov, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/7] Overlayfs: Use copy-up security hooks Date: Fri, 07 Nov 2014 16:39:21 -0500 [thread overview] Message-ID: <4109261.WfcAOoSvNG@sifl> (raw) In-Reply-To: <20141105154238.2555.85960.stgit@warthog.procyon.org.uk> On Wednesday, November 05, 2014 03:42:38 PM David Howells wrote: > Use the copy-up security hooks previously provided to allow an LSM to adjust > the security on a newly created copy and to filter the xattrs copied to > that file copy. > > Signed-off-by: David Howells <dhowells@redhat.com> > --- > > fs/overlayfs/copy_up.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/fs/overlayfs/copy_up.c b/fs/overlayfs/copy_up.c > index ea10a8719107..53a357d0a214 100644 > --- a/fs/overlayfs/copy_up.c > +++ b/fs/overlayfs/copy_up.c > @@ -58,6 +58,14 @@ int ovl_copy_xattr(struct dentry *old, struct dentry > *new) error = size; > goto out_free_value; > } > + error = security_inode_copy_up_xattr(old, new, > + name, value, &size); So the LSM must modify the xattr in place? I suppose that since the @value is allocated to the max size it shouldn't be a problem. Just checking ... > + if (error < 0) > + goto out_free_value; > + if (error == 1) { > + error = 0; > + continue; /* Discard */ > + } > error = vfs_setxattr(new, name, value, size, 0); > if (error) > goto out_free_value; -- paul moore www.paul-moore.com
next prev parent reply other threads:[~2014-11-07 21:39 UTC|newest] Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-11-05 15:42 [PATCH 0/7] Security: Provide unioned file support David Howells 2014-11-05 15:42 ` [PATCH 1/7] Security: Provide copy-up security hooks for unioned files David Howells 2014-11-06 17:46 ` Casey Schaufler 2014-11-07 14:49 ` David Howells 2014-11-07 14:49 ` David Howells 2014-11-07 21:22 ` Paul Moore 2014-11-07 21:22 ` Paul Moore 2014-11-07 22:10 ` David Howells 2014-11-07 22:10 ` David Howells 2014-11-10 15:28 ` Paul Moore 2014-11-10 15:28 ` Paul Moore 2014-11-05 15:42 ` [PATCH 2/7] Overlayfs: Use copy-up security hooks David Howells 2014-11-07 21:39 ` Paul Moore [this message] 2014-11-07 21:39 ` Paul Moore 2014-11-07 22:05 ` David Howells 2014-11-07 22:05 ` David Howells 2014-11-10 15:45 ` Paul Moore 2014-11-10 15:45 ` Paul Moore 2014-11-05 15:42 ` [PATCH 3/7] SELinux: Stub in copy-up handling David Howells 2014-11-07 21:44 ` Paul Moore 2014-11-07 21:44 ` Paul Moore 2014-11-07 22:08 ` David Howells 2014-11-07 22:08 ` David Howells 2014-11-10 15:47 ` Paul Moore 2014-11-10 15:47 ` Paul Moore 2014-11-05 15:42 ` [PATCH 4/7] Security: Pass the union-layer file path into security_file_open() David Howells 2014-11-05 15:43 ` [PATCH 5/7] SELinux: Handle opening of a unioned file David Howells 2014-11-05 16:35 ` Stephen Smalley 2014-11-06 12:03 ` David Howells 2014-11-06 12:03 ` David Howells 2014-11-06 13:13 ` Stephen Smalley 2014-11-06 13:13 ` Stephen Smalley 2014-11-06 13:34 ` David Howells 2014-11-06 13:34 ` David Howells 2014-11-27 14:15 ` David Howells 2014-11-27 14:15 ` David Howells 2014-11-06 12:27 ` David Howells 2014-11-06 12:27 ` David Howells 2014-11-06 12:27 ` David Howells 2014-11-27 17:25 ` David Howells 2014-11-27 17:25 ` David Howells 2015-06-12 15:30 ` David Howells 2015-06-12 15:30 ` David Howells 2015-06-15 12:57 ` Stephen Smalley 2015-06-15 12:57 ` Stephen Smalley 2015-06-16 9:41 ` David Howells 2015-06-16 9:41 ` David Howells 2015-06-16 16:49 ` David Howells 2015-06-16 16:49 ` David Howells 2015-06-16 17:20 ` Stephen Smalley 2015-06-16 17:20 ` Stephen Smalley 2015-06-16 21:34 ` David Howells 2015-06-16 21:34 ` David Howells 2015-06-17 14:44 ` Stephen Smalley 2015-06-17 14:44 ` Stephen Smalley 2015-06-18 10:15 ` David Howells 2015-06-18 10:15 ` David Howells 2015-06-18 12:48 ` Stephen Smalley 2015-06-18 12:48 ` Stephen Smalley 2015-06-18 15:26 ` David Howells 2015-06-18 15:26 ` David Howells 2015-06-18 10:32 ` David Howells 2015-06-18 10:32 ` David Howells 2015-06-18 12:16 ` Stephen Smalley 2015-06-18 12:16 ` Stephen Smalley 2014-11-05 15:43 ` [PATCH 6/7] SELinux: The copy-up operation must have read permission on the lower file David Howells 2014-11-05 16:43 ` Stephen Smalley 2014-11-05 17:54 ` Stephen Smalley 2014-11-06 13:39 ` Stephen Smalley 2014-11-27 14:17 ` David Howells 2014-11-27 14:17 ` David Howells 2014-11-27 14:21 ` David Howells 2014-11-27 14:21 ` David Howells 2014-11-27 14:21 ` David Howells 2014-11-05 15:43 ` [PATCH 7/7] SELinux: Check against union and lower labels for file ops on lower files David Howells 2014-11-06 17:35 ` [PATCH 0/7] Security: Provide unioned file support Casey Schaufler 2014-11-06 17:35 ` Casey Schaufler 2014-11-06 17:58 ` David Howells 2014-11-06 17:58 ` David Howells 2014-11-06 18:40 ` Casey Schaufler 2014-11-06 18:40 ` Casey Schaufler 2014-11-07 15:21 ` David Howells 2014-11-07 15:21 ` David Howells 2014-11-07 18:54 ` Daniel J Walsh 2014-11-07 18:54 ` Daniel J Walsh 2014-11-09 1:31 ` Casey Schaufler 2014-11-09 1:31 ` Casey Schaufler 2014-11-10 13:59 ` Daniel J Walsh 2014-11-10 13:59 ` Daniel J Walsh
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4109261.WfcAOoSvNG@sifl \ --to=paul@paul-moore.com \ --cc=dhowells@redhat.com \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-security-module@vger.kernel.org \ --cc=linux-unionfs@vger.kernel.org \ --cc=selinux@tycho.nsa.gov \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.