All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 05/22] KVM: ARM64: Add a helper for CP15 registers reset to UNKNOWN
Date: Fri, 11 Sep 2015 11:17:55 +0100	[thread overview]
Message-ID: <55F2AA53.40503@arm.com> (raw)
In-Reply-To: <1441961715-11688-6-git-send-email-zhaoshenglong@huawei.com>

On 11/09/15 09:54, Shannon Zhao wrote:
> From: Shannon Zhao <shannon.zhao@linaro.org>
> 
> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
> ---
>  arch/arm64/kvm/sys_regs.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm64/kvm/sys_regs.h b/arch/arm64/kvm/sys_regs.h
> index d411e25..a0b3811 100644
> --- a/arch/arm64/kvm/sys_regs.h
> +++ b/arch/arm64/kvm/sys_regs.h
> @@ -104,6 +104,14 @@ static inline void reset_unknown(struct kvm_vcpu *vcpu,
>  	vcpu_sys_reg(vcpu, r->reg) = 0x1de7ec7edbadc0deULL;
>  }
>  
> +static inline void reset_unknown_cp15(struct kvm_vcpu *vcpu,
> +				      const struct sys_reg_desc *r)
> +{

Oh, and given that you are using this as a function pointer in the next
patch, why is it an inline function?

Please merge this with patch #6.

	M.
-- 
Jazz is not dead. It just smells funny...

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <marc.zyngier@arm.com>
To: Shannon Zhao <zhaoshenglong@huawei.com>, kvmarm@lists.cs.columbia.edu
Cc: linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org,
	christoffer.dall@linaro.org, will.deacon@arm.com,
	alex.bennee@linaro.org, wei@redhat.com, shannon.zhao@linaro.org,
	peter.huangpeng@huawei.com
Subject: Re: [PATCH v2 05/22] KVM: ARM64: Add a helper for CP15 registers reset to UNKNOWN
Date: Fri, 11 Sep 2015 11:17:55 +0100	[thread overview]
Message-ID: <55F2AA53.40503@arm.com> (raw)
In-Reply-To: <1441961715-11688-6-git-send-email-zhaoshenglong@huawei.com>

On 11/09/15 09:54, Shannon Zhao wrote:
> From: Shannon Zhao <shannon.zhao@linaro.org>
> 
> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
> ---
>  arch/arm64/kvm/sys_regs.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm64/kvm/sys_regs.h b/arch/arm64/kvm/sys_regs.h
> index d411e25..a0b3811 100644
> --- a/arch/arm64/kvm/sys_regs.h
> +++ b/arch/arm64/kvm/sys_regs.h
> @@ -104,6 +104,14 @@ static inline void reset_unknown(struct kvm_vcpu *vcpu,
>  	vcpu_sys_reg(vcpu, r->reg) = 0x1de7ec7edbadc0deULL;
>  }
>  
> +static inline void reset_unknown_cp15(struct kvm_vcpu *vcpu,
> +				      const struct sys_reg_desc *r)
> +{

Oh, and given that you are using this as a function pointer in the next
patch, why is it an inline function?

Please merge this with patch #6.

	M.
-- 
Jazz is not dead. It just smells funny...

  parent reply	other threads:[~2015-09-11 10:17 UTC|newest]

Thread overview: 113+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-11  8:54 [PATCH v2 00/22] KVM: ARM64: Add guest PMU support Shannon Zhao
2015-09-11  8:54 ` Shannon Zhao
2015-09-11  8:54 ` Shannon Zhao
2015-09-11  8:54 ` [PATCH v2 01/22] ARM64: Move PMU register related defines to asm/pmu.h Shannon Zhao
2015-09-11  8:54   ` Shannon Zhao
2015-09-11  8:54   ` Shannon Zhao
2015-09-11  8:54 ` [PATCH v2 02/22] KVM: ARM64: Define PMU data structure for each vcpu Shannon Zhao
2015-09-11  8:54   ` Shannon Zhao
2015-09-11  8:54   ` Shannon Zhao
2015-09-11  9:10   ` Marc Zyngier
2015-09-11  9:10     ` Marc Zyngier
2015-09-11  9:58     ` Shannon Zhao
2015-09-11  9:58       ` Shannon Zhao
2015-09-11  9:58       ` Shannon Zhao
2015-09-11  8:54 ` [PATCH v2 03/22] KVM: ARM64: Add offset defines for PMU registers Shannon Zhao
2015-09-11  8:54   ` Shannon Zhao
2015-09-11  8:54   ` Shannon Zhao
2015-09-11  8:54 ` [PATCH v2 04/22] KVM: ARM64: Add reset and access handlers for PMCR_EL0 register Shannon Zhao
2015-09-11  8:54   ` Shannon Zhao
2015-09-11  8:54   ` Shannon Zhao
2015-09-11 10:07   ` Marc Zyngier
2015-09-11 10:07     ` Marc Zyngier
2015-09-14  3:14     ` Shannon Zhao
2015-09-14  3:14       ` Shannon Zhao
2015-09-14  3:14       ` Shannon Zhao
2015-09-14 12:11       ` Marc Zyngier
2015-09-14 12:11         ` Marc Zyngier
2015-09-11  8:54 ` [PATCH v2 05/22] KVM: ARM64: Add a helper for CP15 registers reset to UNKNOWN Shannon Zhao
2015-09-11  8:54   ` Shannon Zhao
2015-09-11  8:54   ` Shannon Zhao
2015-09-11 10:16   ` Marc Zyngier
2015-09-11 10:16     ` Marc Zyngier
2015-09-11 10:17   ` Marc Zyngier [this message]
2015-09-11 10:17     ` Marc Zyngier
2015-09-11  8:54 ` [PATCH v2 06/22] KVM: ARM64: Add reset and access handlers for PMSELR register Shannon Zhao
2015-09-11  8:54   ` Shannon Zhao
2015-09-11  8:54   ` Shannon Zhao
2015-09-11  8:55 ` [PATCH v2 07/22] KVM: ARM64: Add reset and access handlers for PMCEID0 and PMCEID1 register Shannon Zhao
2015-09-11  8:55   ` Shannon Zhao
2015-09-11  8:55   ` Shannon Zhao
2015-09-11 10:27   ` Marc Zyngier
2015-09-11 10:27     ` Marc Zyngier
2015-09-11  8:55 ` [PATCH v2 08/22] KVM: ARM64: PMU: Add perf event map and introduce perf event creating function Shannon Zhao
2015-09-11  8:55   ` Shannon Zhao
2015-09-11  8:55   ` Shannon Zhao
2015-09-11 11:04   ` Marc Zyngier
2015-09-11 11:04     ` Marc Zyngier
2015-09-11 13:35     ` Shannon Zhao
2015-09-11 13:35       ` Shannon Zhao
2015-09-11 14:14       ` Marc Zyngier
2015-09-11 14:14         ` Marc Zyngier
2015-09-11  8:55 ` [PATCH v2 09/22] KVM: ARM64: Add reset and access handlers for PMXEVTYPER register Shannon Zhao
2015-09-11  8:55   ` Shannon Zhao
2015-09-11  8:55   ` Shannon Zhao
2015-09-11  8:55 ` [PATCH v2 10/22] KVM: ARM64: Add reset and access handlers for PMXEVCNTR register Shannon Zhao
2015-09-11  8:55   ` Shannon Zhao
2015-09-11  8:55   ` Shannon Zhao
2015-09-11  8:55 ` [PATCH v2 11/22] KVM: ARM64: Add reset and access handlers for PMCCNTR register Shannon Zhao
2015-09-11  8:55   ` Shannon Zhao
2015-09-11  8:55   ` Shannon Zhao
2015-09-11  8:55 ` [PATCH v2 12/22] KVM: ARM64: Add reset and access handlers for PMCNTENSET and PMCNTENCLR register Shannon Zhao
2015-09-11  8:55   ` Shannon Zhao
2015-09-11  8:55   ` Shannon Zhao
2015-09-11  8:55 ` [PATCH v2 13/22] KVM: ARM64: Add reset and access handlers for PMINTENSET and PMINTENCLR register Shannon Zhao
2015-09-11  8:55   ` Shannon Zhao
2015-09-11  8:55   ` Shannon Zhao
2015-09-11  8:55 ` [PATCH v2 14/22] KVM: ARM64: Add reset and access handlers for PMOVSSET and PMOVSCLR register Shannon Zhao
2015-09-11  8:55   ` Shannon Zhao
2015-09-11  8:55   ` Shannon Zhao
2015-09-11  8:55 ` [PATCH v2 15/22] KVM: ARM64: Add a helper for CP15 registers reset to specified value Shannon Zhao
2015-09-11  8:55   ` Shannon Zhao
2015-09-11  8:55   ` Shannon Zhao
2015-09-11  8:55 ` [PATCH v2 16/22] KVM: ARM64: Add reset and access handlers for PMUSERENR register Shannon Zhao
2015-09-11  8:55   ` Shannon Zhao
2015-09-11  8:55   ` Shannon Zhao
2015-09-11  8:55 ` [PATCH v2 17/22] KVM: ARM64: Add reset and access handlers for PMSWINC register Shannon Zhao
2015-09-11  8:55   ` Shannon Zhao
2015-09-11  8:55   ` Shannon Zhao
2015-09-11  8:55 ` [PATCH v2 18/22] KVM: ARM64: Add access handlers for PMEVCNTRn and PMEVTYPERn register Shannon Zhao
2015-09-11  8:55   ` Shannon Zhao
2015-09-11  8:55   ` Shannon Zhao
2015-09-11  8:55 ` [PATCH v2 19/22] KVM: ARM64: Add PMU overflow interrupt routing Shannon Zhao
2015-09-11  8:55   ` Shannon Zhao
2015-09-11  8:55   ` Shannon Zhao
2015-09-11  8:55 ` [PATCH v2 20/22] KVM: ARM64: Reset PMU state when resetting vcpu Shannon Zhao
2015-09-11  8:55   ` Shannon Zhao
2015-09-11  8:55   ` Shannon Zhao
2015-09-11  8:55 ` [PATCH v2 21/22] KVM: ARM64: Free perf event of PMU when destroying vcpu Shannon Zhao
2015-09-11  8:55   ` Shannon Zhao
2015-09-11  8:55   ` Shannon Zhao
2015-09-11  8:55 ` [PATCH v2 22/22] KVM: ARM64: Add a new kvm ARM PMU device Shannon Zhao
2015-09-11  8:55   ` Shannon Zhao
2015-09-11  8:55   ` Shannon Zhao
2015-09-14 11:53 ` [PATCH v2 00/22] KVM: ARM64: Add guest PMU support Christoffer Dall
2015-09-14 11:53   ` Christoffer Dall
2015-09-14 12:58   ` Shannon Zhao
2015-09-14 12:58     ` Shannon Zhao
2015-09-14 13:24 ` Shannon Zhao
2015-09-14 13:24   ` Shannon Zhao
2015-09-16 21:07 ` Wei Huang
2015-09-16 21:07   ` Wei Huang
2015-09-17  1:32   ` Shannon Zhao
2015-09-17  1:32     ` Shannon Zhao
2015-09-17  5:56     ` Wei Huang
2015-09-17  5:56       ` Wei Huang
2015-09-17  6:47       ` Shannon Zhao
2015-09-17  6:47         ` Shannon Zhao
2015-09-17  6:47         ` Shannon Zhao
2015-09-17  9:30     ` Andrew Jones
2015-09-17  9:30       ` Andrew Jones
2015-09-17  9:35       ` Shannon Zhao
2015-09-17  9:35         ` Shannon Zhao
2015-09-17  9:35         ` Shannon Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F2AA53.40503@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.