From: marc.zyngier@arm.com (Marc Zyngier) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 08/22] KVM: ARM64: PMU: Add perf event map and introduce perf event creating function Date: Fri, 11 Sep 2015 15:14:27 +0100 [thread overview] Message-ID: <55F2E1C3.1060807@arm.com> (raw) In-Reply-To: <55F2D89A.5060907@linaro.org> On 11/09/15 14:35, Shannon Zhao wrote: > > > On 2015/9/11 19:04, Marc Zyngier wrote: [...] >> Having had a chat with Will, it appears that a much better solution >> would be to ask perf to use raw events instead of trying to map things >> to perf events (which the guest has already done). >> >> See drivers/oprofile/oprofile_perf.c::op_perf_setup(). >> >> Thoughts? >> > > Yeah, directly using PERF_TYPE_RAW event looks simpler. But should we > check whether the value of event number written to PMXEVTYPER_EL0 is > valid? Or That is guaranteed by guest? I don't think we need to check for anything. Userspace is allowed to request any event and the PMU will count it if this event exists, or won't if it doesn't. We shouldn't be doing more validation than that, if only because most events are microarchitectural, and they are mostly undocumented. Thanks, M. -- Jazz is not dead. It just smells funny...
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <marc.zyngier@arm.com> To: Shannon Zhao <shannon.zhao@linaro.org>, Shannon Zhao <zhaoshenglong@huawei.com>, kvmarm@lists.cs.columbia.edu Cc: linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, christoffer.dall@linaro.org, will.deacon@arm.com, alex.bennee@linaro.org, wei@redhat.com, peter.huangpeng@huawei.com Subject: Re: [PATCH v2 08/22] KVM: ARM64: PMU: Add perf event map and introduce perf event creating function Date: Fri, 11 Sep 2015 15:14:27 +0100 [thread overview] Message-ID: <55F2E1C3.1060807@arm.com> (raw) In-Reply-To: <55F2D89A.5060907@linaro.org> On 11/09/15 14:35, Shannon Zhao wrote: > > > On 2015/9/11 19:04, Marc Zyngier wrote: [...] >> Having had a chat with Will, it appears that a much better solution >> would be to ask perf to use raw events instead of trying to map things >> to perf events (which the guest has already done). >> >> See drivers/oprofile/oprofile_perf.c::op_perf_setup(). >> >> Thoughts? >> > > Yeah, directly using PERF_TYPE_RAW event looks simpler. But should we > check whether the value of event number written to PMXEVTYPER_EL0 is > valid? Or That is guaranteed by guest? I don't think we need to check for anything. Userspace is allowed to request any event and the PMU will count it if this event exists, or won't if it doesn't. We shouldn't be doing more validation than that, if only because most events are microarchitectural, and they are mostly undocumented. Thanks, M. -- Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2015-09-11 14:14 UTC|newest] Thread overview: 113+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-09-11 8:54 [PATCH v2 00/22] KVM: ARM64: Add guest PMU support Shannon Zhao 2015-09-11 8:54 ` Shannon Zhao 2015-09-11 8:54 ` Shannon Zhao 2015-09-11 8:54 ` [PATCH v2 01/22] ARM64: Move PMU register related defines to asm/pmu.h Shannon Zhao 2015-09-11 8:54 ` Shannon Zhao 2015-09-11 8:54 ` Shannon Zhao 2015-09-11 8:54 ` [PATCH v2 02/22] KVM: ARM64: Define PMU data structure for each vcpu Shannon Zhao 2015-09-11 8:54 ` Shannon Zhao 2015-09-11 8:54 ` Shannon Zhao 2015-09-11 9:10 ` Marc Zyngier 2015-09-11 9:10 ` Marc Zyngier 2015-09-11 9:58 ` Shannon Zhao 2015-09-11 9:58 ` Shannon Zhao 2015-09-11 9:58 ` Shannon Zhao 2015-09-11 8:54 ` [PATCH v2 03/22] KVM: ARM64: Add offset defines for PMU registers Shannon Zhao 2015-09-11 8:54 ` Shannon Zhao 2015-09-11 8:54 ` Shannon Zhao 2015-09-11 8:54 ` [PATCH v2 04/22] KVM: ARM64: Add reset and access handlers for PMCR_EL0 register Shannon Zhao 2015-09-11 8:54 ` Shannon Zhao 2015-09-11 8:54 ` Shannon Zhao 2015-09-11 10:07 ` Marc Zyngier 2015-09-11 10:07 ` Marc Zyngier 2015-09-14 3:14 ` Shannon Zhao 2015-09-14 3:14 ` Shannon Zhao 2015-09-14 3:14 ` Shannon Zhao 2015-09-14 12:11 ` Marc Zyngier 2015-09-14 12:11 ` Marc Zyngier 2015-09-11 8:54 ` [PATCH v2 05/22] KVM: ARM64: Add a helper for CP15 registers reset to UNKNOWN Shannon Zhao 2015-09-11 8:54 ` Shannon Zhao 2015-09-11 8:54 ` Shannon Zhao 2015-09-11 10:16 ` Marc Zyngier 2015-09-11 10:16 ` Marc Zyngier 2015-09-11 10:17 ` Marc Zyngier 2015-09-11 10:17 ` Marc Zyngier 2015-09-11 8:54 ` [PATCH v2 06/22] KVM: ARM64: Add reset and access handlers for PMSELR register Shannon Zhao 2015-09-11 8:54 ` Shannon Zhao 2015-09-11 8:54 ` Shannon Zhao 2015-09-11 8:55 ` [PATCH v2 07/22] KVM: ARM64: Add reset and access handlers for PMCEID0 and PMCEID1 register Shannon Zhao 2015-09-11 8:55 ` Shannon Zhao 2015-09-11 8:55 ` Shannon Zhao 2015-09-11 10:27 ` Marc Zyngier 2015-09-11 10:27 ` Marc Zyngier 2015-09-11 8:55 ` [PATCH v2 08/22] KVM: ARM64: PMU: Add perf event map and introduce perf event creating function Shannon Zhao 2015-09-11 8:55 ` Shannon Zhao 2015-09-11 8:55 ` Shannon Zhao 2015-09-11 11:04 ` Marc Zyngier 2015-09-11 11:04 ` Marc Zyngier 2015-09-11 13:35 ` Shannon Zhao 2015-09-11 13:35 ` Shannon Zhao 2015-09-11 14:14 ` Marc Zyngier [this message] 2015-09-11 14:14 ` Marc Zyngier 2015-09-11 8:55 ` [PATCH v2 09/22] KVM: ARM64: Add reset and access handlers for PMXEVTYPER register Shannon Zhao 2015-09-11 8:55 ` Shannon Zhao 2015-09-11 8:55 ` Shannon Zhao 2015-09-11 8:55 ` [PATCH v2 10/22] KVM: ARM64: Add reset and access handlers for PMXEVCNTR register Shannon Zhao 2015-09-11 8:55 ` Shannon Zhao 2015-09-11 8:55 ` Shannon Zhao 2015-09-11 8:55 ` [PATCH v2 11/22] KVM: ARM64: Add reset and access handlers for PMCCNTR register Shannon Zhao 2015-09-11 8:55 ` Shannon Zhao 2015-09-11 8:55 ` Shannon Zhao 2015-09-11 8:55 ` [PATCH v2 12/22] KVM: ARM64: Add reset and access handlers for PMCNTENSET and PMCNTENCLR register Shannon Zhao 2015-09-11 8:55 ` Shannon Zhao 2015-09-11 8:55 ` Shannon Zhao 2015-09-11 8:55 ` [PATCH v2 13/22] KVM: ARM64: Add reset and access handlers for PMINTENSET and PMINTENCLR register Shannon Zhao 2015-09-11 8:55 ` Shannon Zhao 2015-09-11 8:55 ` Shannon Zhao 2015-09-11 8:55 ` [PATCH v2 14/22] KVM: ARM64: Add reset and access handlers for PMOVSSET and PMOVSCLR register Shannon Zhao 2015-09-11 8:55 ` Shannon Zhao 2015-09-11 8:55 ` Shannon Zhao 2015-09-11 8:55 ` [PATCH v2 15/22] KVM: ARM64: Add a helper for CP15 registers reset to specified value Shannon Zhao 2015-09-11 8:55 ` Shannon Zhao 2015-09-11 8:55 ` Shannon Zhao 2015-09-11 8:55 ` [PATCH v2 16/22] KVM: ARM64: Add reset and access handlers for PMUSERENR register Shannon Zhao 2015-09-11 8:55 ` Shannon Zhao 2015-09-11 8:55 ` Shannon Zhao 2015-09-11 8:55 ` [PATCH v2 17/22] KVM: ARM64: Add reset and access handlers for PMSWINC register Shannon Zhao 2015-09-11 8:55 ` Shannon Zhao 2015-09-11 8:55 ` Shannon Zhao 2015-09-11 8:55 ` [PATCH v2 18/22] KVM: ARM64: Add access handlers for PMEVCNTRn and PMEVTYPERn register Shannon Zhao 2015-09-11 8:55 ` Shannon Zhao 2015-09-11 8:55 ` Shannon Zhao 2015-09-11 8:55 ` [PATCH v2 19/22] KVM: ARM64: Add PMU overflow interrupt routing Shannon Zhao 2015-09-11 8:55 ` Shannon Zhao 2015-09-11 8:55 ` Shannon Zhao 2015-09-11 8:55 ` [PATCH v2 20/22] KVM: ARM64: Reset PMU state when resetting vcpu Shannon Zhao 2015-09-11 8:55 ` Shannon Zhao 2015-09-11 8:55 ` Shannon Zhao 2015-09-11 8:55 ` [PATCH v2 21/22] KVM: ARM64: Free perf event of PMU when destroying vcpu Shannon Zhao 2015-09-11 8:55 ` Shannon Zhao 2015-09-11 8:55 ` Shannon Zhao 2015-09-11 8:55 ` [PATCH v2 22/22] KVM: ARM64: Add a new kvm ARM PMU device Shannon Zhao 2015-09-11 8:55 ` Shannon Zhao 2015-09-11 8:55 ` Shannon Zhao 2015-09-14 11:53 ` [PATCH v2 00/22] KVM: ARM64: Add guest PMU support Christoffer Dall 2015-09-14 11:53 ` Christoffer Dall 2015-09-14 12:58 ` Shannon Zhao 2015-09-14 12:58 ` Shannon Zhao 2015-09-14 13:24 ` Shannon Zhao 2015-09-14 13:24 ` Shannon Zhao 2015-09-16 21:07 ` Wei Huang 2015-09-16 21:07 ` Wei Huang 2015-09-17 1:32 ` Shannon Zhao 2015-09-17 1:32 ` Shannon Zhao 2015-09-17 5:56 ` Wei Huang 2015-09-17 5:56 ` Wei Huang 2015-09-17 6:47 ` Shannon Zhao 2015-09-17 6:47 ` Shannon Zhao 2015-09-17 6:47 ` Shannon Zhao 2015-09-17 9:30 ` Andrew Jones 2015-09-17 9:30 ` Andrew Jones 2015-09-17 9:35 ` Shannon Zhao 2015-09-17 9:35 ` Shannon Zhao 2015-09-17 9:35 ` Shannon Zhao
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=55F2E1C3.1060807@arm.com \ --to=marc.zyngier@arm.com \ --cc=linux-arm-kernel@lists.infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.