From: netdev@kapio-technology.com To: Vladimir Oltean <olteanv@gmail.com> Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>, Vivien Didelot <vivien.didelot@gmail.com>, Florian Fainelli <f.fainelli@gmail.com>, Eric Dumazet <edumazet@google.com>, Paolo Abeni <pabeni@redhat.com>, Jiri Pirko <jiri@resnulli.us>, Ivan Vecera <ivecera@redhat.com>, Roopa Prabhu <roopa@nvidia.com>, Nikolay Aleksandrov <razor@blackwall.org>, Shuah Khan <shuah@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>, Ido Schimmel <idosch@nvidia.com>, linux-kernel@vger.kernel.org, bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v4 net-next 3/6] drivers: net: dsa: add locked fdb entry flag to drivers Date: Fri, 08 Jul 2022 11:06:24 +0200 [thread overview] Message-ID: <e6f418705e19df370c8d644993aa9a6f@kapio-technology.com> (raw) In-Reply-To: <20220708084904.33otb6x256huddps@skbuf> On 2022-07-08 10:49, Vladimir Oltean wrote: > Hi Hans, > > On Thu, Jul 07, 2022 at 05:29:27PM +0200, Hans Schultz wrote: >> Ignore locked fdb entries coming in on all drivers. >> >> Signed-off-by: Hans Schultz <netdev@kapio-technology.com> >> --- > > A good patch should have a reason for the change in the commit message. > This has no reason because there is no reason. > > Think about it, you've said it yourself in patch 1: > > | Only the kernel can set this FDB entry flag, while userspace can read > | the flag and remove it by replacing or deleting the FDB entry. > > So if user space will never add locked FDB entries to the bridge, > then FDB entries with is_locked=true are never transported using > SWITCHDEV_FDB_ADD_TO_DEVICE to drivers, and so, there is no reason at > all to pass is_locked to drivers, just for them to ignore something > that > won't appear. Correct me if I am wrong, but since the bridge can add locked entries, and the ensuring fdb update will create a SWITCHDEV_FDB_ADD_TO_DEVICE, those entries should reach the driver. The policy to ignore those in the driver can be seen as either the right thing to do, or not yet implemented. I remember Ido wrote at a point that the scheme they use is to trap various packets to the CPU and let the bridge add the locked entry, which I then understand is sent to the driver with a SWITCHDEV_FDB_ADD_TO_DEVICE event. > > You just need this for SWITCHDEV_FDB_ADD_TO_BRIDGE, so please keep it > only in those code paths, and remove it from net/dsa/slave.c as well. > >> drivers/net/dsa/b53/b53_common.c | 5 +++++ >> drivers/net/dsa/b53/b53_priv.h | 1 + >> drivers/net/dsa/hirschmann/hellcreek.c | 5 +++++ >> drivers/net/dsa/lan9303-core.c | 5 +++++ >> drivers/net/dsa/lantiq_gswip.c | 5 +++++ >> drivers/net/dsa/microchip/ksz9477.c | 5 +++++ >> drivers/net/dsa/mt7530.c | 5 +++++ >> drivers/net/dsa/mv88e6xxx/chip.c | 5 +++++ >> drivers/net/dsa/ocelot/felix.c | 5 +++++ >> drivers/net/dsa/qca8k.c | 5 +++++ >> drivers/net/dsa/sja1105/sja1105_main.c | 5 +++++ >> include/net/dsa.h | 1 + >> net/dsa/switch.c | 4 ++-- >> 13 files changed, 54 insertions(+), 2 deletions(-)
WARNING: multiple messages have this Message-ID (diff)
From: netdev@kapio-technology.com To: Vladimir Oltean <olteanv@gmail.com> Cc: Ivan Vecera <ivecera@redhat.com>, Andrew Lunn <andrew@lunn.ch>, Florian Fainelli <f.fainelli@gmail.com>, Jiri Pirko <jiri@resnulli.us>, Daniel Borkmann <daniel@iogearbox.net>, netdev@vger.kernel.org, Nikolay Aleksandrov <razor@blackwall.org>, bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Ido Schimmel <idosch@nvidia.com>, Vivien Didelot <vivien.didelot@gmail.com>, Eric Dumazet <edumazet@google.com>, linux-kselftest@vger.kernel.org, Roopa Prabhu <roopa@nvidia.com>, kuba@kernel.org, Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>, davem@davemloft.net Subject: Re: [Bridge] [PATCH v4 net-next 3/6] drivers: net: dsa: add locked fdb entry flag to drivers Date: Fri, 08 Jul 2022 11:06:24 +0200 [thread overview] Message-ID: <e6f418705e19df370c8d644993aa9a6f@kapio-technology.com> (raw) In-Reply-To: <20220708084904.33otb6x256huddps@skbuf> On 2022-07-08 10:49, Vladimir Oltean wrote: > Hi Hans, > > On Thu, Jul 07, 2022 at 05:29:27PM +0200, Hans Schultz wrote: >> Ignore locked fdb entries coming in on all drivers. >> >> Signed-off-by: Hans Schultz <netdev@kapio-technology.com> >> --- > > A good patch should have a reason for the change in the commit message. > This has no reason because there is no reason. > > Think about it, you've said it yourself in patch 1: > > | Only the kernel can set this FDB entry flag, while userspace can read > | the flag and remove it by replacing or deleting the FDB entry. > > So if user space will never add locked FDB entries to the bridge, > then FDB entries with is_locked=true are never transported using > SWITCHDEV_FDB_ADD_TO_DEVICE to drivers, and so, there is no reason at > all to pass is_locked to drivers, just for them to ignore something > that > won't appear. Correct me if I am wrong, but since the bridge can add locked entries, and the ensuring fdb update will create a SWITCHDEV_FDB_ADD_TO_DEVICE, those entries should reach the driver. The policy to ignore those in the driver can be seen as either the right thing to do, or not yet implemented. I remember Ido wrote at a point that the scheme they use is to trap various packets to the CPU and let the bridge add the locked entry, which I then understand is sent to the driver with a SWITCHDEV_FDB_ADD_TO_DEVICE event. > > You just need this for SWITCHDEV_FDB_ADD_TO_BRIDGE, so please keep it > only in those code paths, and remove it from net/dsa/slave.c as well. > >> drivers/net/dsa/b53/b53_common.c | 5 +++++ >> drivers/net/dsa/b53/b53_priv.h | 1 + >> drivers/net/dsa/hirschmann/hellcreek.c | 5 +++++ >> drivers/net/dsa/lan9303-core.c | 5 +++++ >> drivers/net/dsa/lantiq_gswip.c | 5 +++++ >> drivers/net/dsa/microchip/ksz9477.c | 5 +++++ >> drivers/net/dsa/mt7530.c | 5 +++++ >> drivers/net/dsa/mv88e6xxx/chip.c | 5 +++++ >> drivers/net/dsa/ocelot/felix.c | 5 +++++ >> drivers/net/dsa/qca8k.c | 5 +++++ >> drivers/net/dsa/sja1105/sja1105_main.c | 5 +++++ >> include/net/dsa.h | 1 + >> net/dsa/switch.c | 4 ++-- >> 13 files changed, 54 insertions(+), 2 deletions(-)
next prev parent reply other threads:[~2022-07-08 9:06 UTC|newest] Thread overview: 137+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-07-07 15:29 [PATCH v4 net-next 0/6] Extend locked port feature with FDB locked flag (MAC-Auth/MAB) Hans Schultz 2022-07-07 15:29 ` [Bridge] " Hans Schultz 2022-07-07 15:29 ` [PATCH v4 net-next 1/6] net: bridge: add locked entry fdb flag to extend locked port feature Hans Schultz 2022-07-07 15:29 ` [Bridge] " Hans Schultz 2022-07-10 8:20 ` Ido Schimmel 2022-07-10 8:20 ` [Bridge] " Ido Schimmel 2022-07-07 15:29 ` [PATCH v4 net-next 2/6] net: switchdev: add support for offloading of fdb locked flag Hans Schultz 2022-07-07 15:29 ` [Bridge] " Hans Schultz 2022-07-08 8:54 ` Vladimir Oltean 2022-07-08 8:54 ` [Bridge] " Vladimir Oltean 2022-08-02 8:27 ` netdev 2022-08-02 8:27 ` [Bridge] " netdev 2022-08-02 10:13 ` netdev 2022-08-02 10:13 ` [Bridge] " netdev 2022-07-07 15:29 ` [PATCH v4 net-next 3/6] drivers: net: dsa: add locked fdb entry flag to drivers Hans Schultz 2022-07-07 15:29 ` [Bridge] " Hans Schultz 2022-07-08 7:12 ` kernel test robot 2022-07-08 8:49 ` Vladimir Oltean 2022-07-08 8:49 ` [Bridge] " Vladimir Oltean 2022-07-08 9:06 ` netdev [this message] 2022-07-08 9:06 ` netdev 2022-07-08 9:15 ` Vladimir Oltean 2022-07-08 9:15 ` [Bridge] " Vladimir Oltean 2022-07-08 9:27 ` netdev 2022-07-08 9:27 ` [Bridge] " netdev 2022-07-08 9:50 ` netdev 2022-07-08 9:50 ` [Bridge] " netdev 2022-07-08 11:56 ` Vladimir Oltean 2022-07-08 11:56 ` [Bridge] " Vladimir Oltean 2022-07-08 12:34 ` netdev 2022-07-08 12:34 ` [Bridge] " netdev 2022-07-10 8:35 ` Ido Schimmel 2022-07-10 8:35 ` [Bridge] " Ido Schimmel 2022-07-13 7:09 ` netdev 2022-07-13 7:09 ` [Bridge] " netdev 2022-07-13 12:39 ` Ido Schimmel 2022-07-13 12:39 ` [Bridge] " Ido Schimmel 2022-07-17 12:21 ` netdev 2022-07-17 12:21 ` [Bridge] " netdev 2022-07-17 12:57 ` Vladimir Oltean 2022-07-17 12:57 ` [Bridge] " Vladimir Oltean 2022-07-17 13:09 ` netdev 2022-07-17 13:09 ` [Bridge] " netdev 2022-07-17 13:59 ` Vladimir Oltean 2022-07-17 13:59 ` [Bridge] " Vladimir Oltean 2022-07-17 14:57 ` netdev 2022-07-17 14:57 ` [Bridge] " netdev 2022-07-17 15:08 ` Vladimir Oltean 2022-07-17 15:08 ` [Bridge] " Vladimir Oltean 2022-07-17 16:10 ` netdev 2022-07-17 16:10 ` [Bridge] " netdev 2022-07-21 11:54 ` Vladimir Oltean 2022-07-21 11:54 ` [Bridge] " Vladimir Oltean 2022-07-17 15:20 ` Ido Schimmel 2022-07-17 15:20 ` [Bridge] " Ido Schimmel 2022-07-17 15:53 ` netdev 2022-07-17 15:53 ` [Bridge] " netdev 2022-07-21 11:59 ` Vladimir Oltean 2022-07-21 11:59 ` [Bridge] " Vladimir Oltean 2022-07-21 13:27 ` Ido Schimmel 2022-07-21 13:27 ` [Bridge] " Ido Schimmel 2022-07-21 14:20 ` Vladimir Oltean 2022-07-21 14:20 ` [Bridge] " Vladimir Oltean 2022-07-24 11:10 ` Ido Schimmel 2022-07-24 11:10 ` [Bridge] " Ido Schimmel 2022-08-01 11:57 ` netdev 2022-08-01 11:57 ` [Bridge] " netdev 2022-08-01 13:14 ` netdev 2022-08-01 13:14 ` [Bridge] " netdev 2022-08-02 12:54 ` netdev 2022-08-02 12:54 ` [Bridge] " netdev 2022-08-01 15:33 ` netdev 2022-08-01 15:33 ` [Bridge] " netdev 2022-08-09 9:20 ` Ido Schimmel 2022-08-09 9:20 ` [Bridge] " Ido Schimmel 2022-08-09 20:00 ` netdev 2022-08-09 20:00 ` [Bridge] " netdev 2022-08-10 7:21 ` Ido Schimmel 2022-08-10 7:21 ` [Bridge] " Ido Schimmel 2022-08-10 8:40 ` netdev 2022-08-10 8:40 ` [Bridge] " netdev 2022-08-11 11:28 ` Ido Schimmel 2022-08-11 11:28 ` [Bridge] " Ido Schimmel 2022-08-12 15:33 ` netdev 2022-08-12 15:33 ` [Bridge] " netdev 2022-08-16 7:51 ` netdev 2022-08-16 7:51 ` [Bridge] " netdev 2022-08-17 6:21 ` Ido Schimmel 2022-08-17 6:21 ` [Bridge] " Ido Schimmel 2022-07-21 11:51 ` Vladimir Oltean 2022-07-21 11:51 ` [Bridge] " Vladimir Oltean 2022-07-08 20:39 ` kernel test robot 2022-07-07 15:29 ` [PATCH v4 net-next 4/6] net: dsa: mv88e6xxx: allow reading FID when handling ATU violations Hans Schultz 2022-07-07 15:29 ` [Bridge] " Hans Schultz 2022-07-07 15:29 ` [PATCH v4 net-next 5/6] net: dsa: mv88e6xxx: mac-auth/MAB implementation Hans Schultz 2022-07-07 15:29 ` [Bridge] " Hans Schultz 2022-07-08 9:46 ` kernel test robot 2022-07-17 0:47 ` Vladimir Oltean 2022-07-17 0:47 ` [Bridge] " Vladimir Oltean 2022-07-17 12:34 ` netdev 2022-07-17 12:34 ` [Bridge] " netdev 2022-07-21 12:04 ` Vladimir Oltean 2022-07-21 12:04 ` [Bridge] " Vladimir Oltean 2022-08-19 8:28 ` netdev 2022-08-19 8:28 ` [Bridge] " netdev 2022-07-07 15:29 ` [PATCH v4 net-next 6/6] selftests: forwarding: add test of MAC-Auth Bypass to locked port tests Hans Schultz 2022-07-07 15:29 ` [Bridge] " Hans Schultz 2022-07-10 7:29 ` Ido Schimmel 2022-07-10 7:29 ` [Bridge] " Ido Schimmel 2022-07-12 12:28 ` netdev 2022-07-12 12:28 ` [Bridge] " netdev 2022-07-08 1:00 ` [PATCH v4 net-next 0/6] Extend locked port feature with FDB locked flag (MAC-Auth/MAB) Jakub Kicinski 2022-07-08 1:00 ` [Bridge] " Jakub Kicinski 2022-08-11 5:09 ` Benjamin Poirier 2022-08-11 5:09 ` [Bridge] " Benjamin Poirier -- strict thread matches above, loose matches on Subject: below -- 2022-08-12 12:29 [PATCH v4 net-next 3/6] drivers: net: dsa: add locked fdb entry flag to drivers netdev 2022-08-14 14:55 ` Ido Schimmel 2022-08-19 9:51 ` netdev 2022-08-21 7:08 ` Ido Schimmel 2022-08-21 13:43 ` netdev 2022-08-22 5:40 ` Ido Schimmel 2022-08-22 7:49 ` netdev 2022-08-23 6:48 ` Ido Schimmel 2022-08-23 7:13 ` netdev 2022-08-23 7:24 ` Ido Schimmel 2022-08-23 7:37 ` netdev 2022-08-23 12:36 ` Ido Schimmel 2022-08-24 7:07 ` netdev 2022-08-23 11:41 ` netdev 2022-08-25 9:36 ` Ido Schimmel 2022-08-25 10:28 ` netdev 2022-08-25 15:14 ` netdev 2022-08-24 20:29 ` netdev 2022-08-25 9:23 ` Ido Schimmel 2022-08-25 10:27 ` netdev 2022-08-25 11:58 ` Ido Schimmel 2022-08-25 13:41 ` netdev
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e6f418705e19df370c8d644993aa9a6f@kapio-technology.com \ --to=netdev@kapio-technology.com \ --cc=andrew@lunn.ch \ --cc=bridge@lists.linux-foundation.org \ --cc=daniel@iogearbox.net \ --cc=davem@davemloft.net \ --cc=edumazet@google.com \ --cc=f.fainelli@gmail.com \ --cc=idosch@nvidia.com \ --cc=ivecera@redhat.com \ --cc=jiri@resnulli.us \ --cc=kuba@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-kselftest@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=olteanv@gmail.com \ --cc=pabeni@redhat.com \ --cc=razor@blackwall.org \ --cc=roopa@nvidia.com \ --cc=shuah@kernel.org \ --cc=vivien.didelot@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.