* [RFC] trace_irqsoff: remove redundant reset per-CPU buff
@ 2015-10-19 18:10 Dmitry Safonov
2015-11-03 18:25 ` Dmitry Safonov
2016-02-05 2:40 ` Steven Rostedt
0 siblings, 2 replies; 8+ messages in thread
From: Dmitry Safonov @ 2015-10-19 18:10 UTC (permalink / raw)
To: rostedt, mingo; +Cc: linux-kernel, Dmitry Safonov
There is no reason to do it twice: from commit b6f11df26fdc28
("trace: Call tracing_reset_online_cpus before tracer->init()")
resetting of per-CPU buffers done before tracer->init() call.
tracer->init() calls {irqs,preempt,preemptirqs}off_tracer_init() and it
calls __irqsoff_tracer_init(), which resets per-CPU ringbuffer second
time.
It's slowpath, but anyway.
Signed-off-by: Dmitry Safonov <0x7f454c46@gmail.com>
---
kernel/trace/trace_irqsoff.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/trace/trace_irqsoff.c b/kernel/trace/trace_irqsoff.c
index 8523ea345f2b1a..4ebcb8bfaced24 100644
--- a/kernel/trace/trace_irqsoff.c
+++ b/kernel/trace/trace_irqsoff.c
@@ -612,7 +612,6 @@ static int __irqsoff_tracer_init(struct trace_array *tr)
irqsoff_trace = tr;
/* make sure that the tracer is visible */
smp_wmb();
- tracing_reset_online_cpus(&tr->trace_buffer);
ftrace_init_array_ops(tr, irqsoff_tracer_call);
--
2.6.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [RFC] trace_irqsoff: remove redundant reset per-CPU buff
2015-10-19 18:10 [RFC] trace_irqsoff: remove redundant reset per-CPU buff Dmitry Safonov
@ 2015-11-03 18:25 ` Dmitry Safonov
2015-11-03 18:37 ` Steven Rostedt
2016-02-05 2:40 ` Steven Rostedt
1 sibling, 1 reply; 8+ messages in thread
From: Dmitry Safonov @ 2015-11-03 18:25 UTC (permalink / raw)
To: Steven Rostedt, mingo; +Cc: linux-kernel, Dmitry Safonov
Ping?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC] trace_irqsoff: remove redundant reset per-CPU buff
2015-11-03 18:25 ` Dmitry Safonov
@ 2015-11-03 18:37 ` Steven Rostedt
0 siblings, 0 replies; 8+ messages in thread
From: Steven Rostedt @ 2015-11-03 18:37 UTC (permalink / raw)
To: Dmitry Safonov; +Cc: mingo, linux-kernel
On Tue, 3 Nov 2015 21:25:44 +0300
Dmitry Safonov <0x7f454c46@gmail.com> wrote:
> Ping?
Thanks, this was lost in my INBOX. I'll take a look at it.
-- Steve
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC] trace_irqsoff: remove redundant reset per-CPU buff
2015-10-19 18:10 [RFC] trace_irqsoff: remove redundant reset per-CPU buff Dmitry Safonov
2015-11-03 18:25 ` Dmitry Safonov
@ 2016-02-05 2:40 ` Steven Rostedt
2016-02-05 11:52 ` Dmitry Safonov
1 sibling, 1 reply; 8+ messages in thread
From: Steven Rostedt @ 2016-02-05 2:40 UTC (permalink / raw)
To: Dmitry Safonov; +Cc: mingo, linux-kernel, rostedt
On Mon, 19 Oct 2015 21:10:26 +0300
Dmitry Safonov <0x7f454c46@gmail.com> wrote:
> There is no reason to do it twice: from commit b6f11df26fdc28
> ("trace: Call tracing_reset_online_cpus before tracer->init()")
> resetting of per-CPU buffers done before tracer->init() call.
>
> tracer->init() calls {irqs,preempt,preemptirqs}off_tracer_init() and it
> calls __irqsoff_tracer_init(), which resets per-CPU ringbuffer second
> time.
> It's slowpath, but anyway.
Bah, I said I'd look at this and I did. But never added it to my queue.
It's not a big deal as this is the slow path but it makes sense. I knew
there was a patch from you to get but saw the TP_ARGS redefining patch
and thought that was it.
I Cc'd myself on this to make sure I see it again.
-- Steve
>
> Signed-off-by: Dmitry Safonov <0x7f454c46@gmail.com>
> ---
> kernel/trace/trace_irqsoff.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/trace/trace_irqsoff.c b/kernel/trace/trace_irqsoff.c
> index 8523ea345f2b1a..4ebcb8bfaced24 100644
> --- a/kernel/trace/trace_irqsoff.c
> +++ b/kernel/trace/trace_irqsoff.c
> @@ -612,7 +612,6 @@ static int __irqsoff_tracer_init(struct trace_array *tr)
> irqsoff_trace = tr;
> /* make sure that the tracer is visible */
> smp_wmb();
> - tracing_reset_online_cpus(&tr->trace_buffer);
>
> ftrace_init_array_ops(tr, irqsoff_tracer_call);
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC] trace_irqsoff: remove redundant reset per-CPU buff
2016-02-05 2:40 ` Steven Rostedt
@ 2016-02-05 11:52 ` Dmitry Safonov
2016-02-05 14:40 ` Steven Rostedt
2016-02-05 15:04 ` Steven Rostedt
0 siblings, 2 replies; 8+ messages in thread
From: Dmitry Safonov @ 2016-02-05 11:52 UTC (permalink / raw)
To: Steven Rostedt; +Cc: mingo, linux-kernel
2016-02-05 5:40 GMT+03:00 Steven Rostedt <rostedt@goodmis.org>:
> On Mon, 19 Oct 2015 21:10:26 +0300
> Dmitry Safonov <0x7f454c46@gmail.com> wrote:
>
>> There is no reason to do it twice: from commit b6f11df26fdc28
>> ("trace: Call tracing_reset_online_cpus before tracer->init()")
>> resetting of per-CPU buffers done before tracer->init() call.
>>
>> tracer->init() calls {irqs,preempt,preemptirqs}off_tracer_init() and it
>> calls __irqsoff_tracer_init(), which resets per-CPU ringbuffer second
>> time.
>> It's slowpath, but anyway.
>
> Bah, I said I'd look at this and I did. But never added it to my queue.
> It's not a big deal as this is the slow path but it makes sense. I knew
> there was a patch from you to get but saw the TP_ARGS redefining patch
> and thought that was it.
Thanks, Steve!
Yeah, I know it may take time to get to unimportant patches
that are also mostly cleanups.
Don't worry, please, take a glance when you'll have time on these
small also not important cleanings (I'm fine if you'll drop them all):
https://lkml.org/lkml/2015/11/20/290
https://lkml.org/lkml/2015/11/20/291
https://lkml.org/lkml/2015/10/30/580
>
> I Cc'd myself on this to make sure I see it again.
>
> -- Steve
--
Regards,
Safonov Dmitry.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC] trace_irqsoff: remove redundant reset per-CPU buff
2016-02-05 11:52 ` Dmitry Safonov
@ 2016-02-05 14:40 ` Steven Rostedt
2016-02-05 15:04 ` Steven Rostedt
1 sibling, 0 replies; 8+ messages in thread
From: Steven Rostedt @ 2016-02-05 14:40 UTC (permalink / raw)
To: Dmitry Safonov; +Cc: mingo, linux-kernel
On Fri, 5 Feb 2016 14:52:53 +0300
Dmitry Safonov <0x7f454c46@gmail.com> wrote:
> 2016-02-05 5:40 GMT+03:00 Steven Rostedt <rostedt@goodmis.org>:
> > On Mon, 19 Oct 2015 21:10:26 +0300
> > Dmitry Safonov <0x7f454c46@gmail.com> wrote:
> >
> >> There is no reason to do it twice: from commit b6f11df26fdc28
> >> ("trace: Call tracing_reset_online_cpus before tracer->init()")
> >> resetting of per-CPU buffers done before tracer->init() call.
> >>
> >> tracer->init() calls {irqs,preempt,preemptirqs}off_tracer_init() and it
> >> calls __irqsoff_tracer_init(), which resets per-CPU ringbuffer second
> >> time.
> >> It's slowpath, but anyway.
> >
> > Bah, I said I'd look at this and I did. But never added it to my queue.
> > It's not a big deal as this is the slow path but it makes sense. I knew
> > there was a patch from you to get but saw the TP_ARGS redefining patch
> > and thought that was it.
>
> Thanks, Steve!
> Yeah, I know it may take time to get to unimportant patches
> that are also mostly cleanups.
> Don't worry, please, take a glance when you'll have time on these
> small also not important cleanings (I'm fine if you'll drop them all):
> https://lkml.org/lkml/2015/11/20/290
> https://lkml.org/lkml/2015/11/20/291
> https://lkml.org/lkml/2015/10/30/580
I'm slowing going through my INBOX (doing clean up to see what I
missed). I'm currently at 11/10. I marked your 10/30 one already as a
"go back and look at later".
-- Steve
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC] trace_irqsoff: remove redundant reset per-CPU buff
2016-02-05 11:52 ` Dmitry Safonov
2016-02-05 14:40 ` Steven Rostedt
@ 2016-02-05 15:04 ` Steven Rostedt
2016-02-05 15:56 ` Dmitry Safonov
1 sibling, 1 reply; 8+ messages in thread
From: Steven Rostedt @ 2016-02-05 15:04 UTC (permalink / raw)
To: Dmitry Safonov; +Cc: mingo, linux-kernel
On Fri, 5 Feb 2016 14:52:53 +0300
Dmitry Safonov <0x7f454c46@gmail.com> wrote:
> Thanks, Steve!
> Yeah, I know it may take time to get to unimportant patches
> that are also mostly cleanups.
>
Also, FYI, even if you do an RFC, include "PATCH" in the brackets as
well. I usually have "[RFC][PATCH]". Because when I'm looking for
patches in my inbox, I will filter for PATCH. If a patch is out there
without that in the subject, it is much more likely to be missed (and
most likely will).
-- Steve
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC] trace_irqsoff: remove redundant reset per-CPU buff
2016-02-05 15:04 ` Steven Rostedt
@ 2016-02-05 15:56 ` Dmitry Safonov
0 siblings, 0 replies; 8+ messages in thread
From: Dmitry Safonov @ 2016-02-05 15:56 UTC (permalink / raw)
To: Steven Rostedt; +Cc: mingo, linux-kernel
2016-02-05 18:04 GMT+03:00 Steven Rostedt <rostedt@goodmis.org>:
> Also, FYI, even if you do an RFC, include "PATCH" in the brackets as
> well. I usually have "[RFC][PATCH]". Because when I'm looking for
> patches in my inbox, I will filter for PATCH. If a patch is out there
> without that in the subject, it is much more likely to be missed (and
> most likely will).
Will do.
And I added RFC mostly because, I didn't see the reason for reseting
second time, but if it has been (I wasn't sure), I wanted to add a comment,
why.
--
Regards,
Safonov Dmitry.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-02-05 15:57 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-19 18:10 [RFC] trace_irqsoff: remove redundant reset per-CPU buff Dmitry Safonov
2015-11-03 18:25 ` Dmitry Safonov
2015-11-03 18:37 ` Steven Rostedt
2016-02-05 2:40 ` Steven Rostedt
2016-02-05 11:52 ` Dmitry Safonov
2016-02-05 14:40 ` Steven Rostedt
2016-02-05 15:04 ` Steven Rostedt
2016-02-05 15:56 ` Dmitry Safonov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).