From: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org,
lee.jones@linaro.org, devicetree@vger.kernel.org,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
Chao Xie <chao.xie@marvell.com>
Subject: Re: [rtc-linux] [PATCH-v2] rtc: 88pm80x: add device tree support
Date: Thu, 25 Jun 2015 13:16:09 +0530 [thread overview]
Message-ID: <558BB1C1.2090400@linaro.org> (raw)
In-Reply-To: <20150620004354.GY27492@piout.net>
On Saturday 20 June 2015 06:13 AM, Alexandre Belloni wrote:
> Hi,
>
Sorry I missed this email.
Just wanted to send reminder email and saw this :)
> On 18/06/2015 at 00:28:06 +0530, Vaibhav Hiremath wrote :
>> - pdata = dev_get_platdata(&pdev->dev);
>> - if (pdata == NULL)
>> - dev_warn(&pdev->dev, "No platform data!\n");
>> + if (!pdata && !node) {
>> + dev_err(&pdev->dev,
>> + "pm80x-rtc requires platform data or of_node\n");
>> + return -EINVAL;
>> + }
>> +
>> + if (!pdata) {
>> + pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL);
>
> I had troubles to follow the rtc_wakeup initialization cleanup but it
> seems OK.
Probably, once we have complete PM support ready then it would be
easier to understand. I think as of now lets have this minimal code for
rtc_wakeup.
> However, I'm wondering why you are adding DT support as this
> will always be probed from the MFD driver which pass the platform_data
> and avoids that allocation.
>
You are right.
Originally, it was cleanup patch,
- remove pm80x_pdata
- Add check for pdata and np
- and around rtc_wakeup
While doing that I added this nice to have allocation.
Thanks,
Vaibhav
WARNING: multiple messages have this Message-ID (diff)
From: Vaibhav Hiremath <vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Alexandre Belloni
<alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Chao Xie <chao.xie-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [rtc-linux] [PATCH-v2] rtc: 88pm80x: add device tree support
Date: Thu, 25 Jun 2015 13:16:09 +0530 [thread overview]
Message-ID: <558BB1C1.2090400@linaro.org> (raw)
In-Reply-To: <20150620004354.GY27492-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org>
On Saturday 20 June 2015 06:13 AM, Alexandre Belloni wrote:
> Hi,
>
Sorry I missed this email.
Just wanted to send reminder email and saw this :)
> On 18/06/2015 at 00:28:06 +0530, Vaibhav Hiremath wrote :
>> - pdata = dev_get_platdata(&pdev->dev);
>> - if (pdata == NULL)
>> - dev_warn(&pdev->dev, "No platform data!\n");
>> + if (!pdata && !node) {
>> + dev_err(&pdev->dev,
>> + "pm80x-rtc requires platform data or of_node\n");
>> + return -EINVAL;
>> + }
>> +
>> + if (!pdata) {
>> + pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL);
>
> I had troubles to follow the rtc_wakeup initialization cleanup but it
> seems OK.
Probably, once we have complete PM support ready then it would be
easier to understand. I think as of now lets have this minimal code for
rtc_wakeup.
> However, I'm wondering why you are adding DT support as this
> will always be probed from the MFD driver which pass the platform_data
> and avoids that allocation.
>
You are right.
Originally, it was cleanup patch,
- remove pm80x_pdata
- Add check for pdata and np
- and around rtc_wakeup
While doing that I added this nice to have allocation.
Thanks,
Vaibhav
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org,
lee.jones@linaro.org, devicetree@vger.kernel.org,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
Chao Xie <chao.xie@marvell.com>
Subject: Re: [rtc-linux] [PATCH-v2] rtc: 88pm80x: add device tree support
Date: Thu, 25 Jun 2015 13:16:09 +0530 [thread overview]
Message-ID: <558BB1C1.2090400@linaro.org> (raw)
In-Reply-To: <20150620004354.GY27492@piout.net>
On Saturday 20 June 2015 06:13 AM, Alexandre Belloni wrote:
> Hi,
>
Sorry I missed this email.
Just wanted to send reminder email and saw this :)
> On 18/06/2015 at 00:28:06 +0530, Vaibhav Hiremath wrote :
>> - pdata = dev_get_platdata(&pdev->dev);
>> - if (pdata == NULL)
>> - dev_warn(&pdev->dev, "No platform data!\n");
>> + if (!pdata && !node) {
>> + dev_err(&pdev->dev,
>> + "pm80x-rtc requires platform data or of_node\n");
>> + return -EINVAL;
>> + }
>> +
>> + if (!pdata) {
>> + pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL);
>
> I had troubles to follow the rtc_wakeup initialization cleanup but it
> seems OK.
Probably, once we have complete PM support ready then it would be
easier to understand. I think as of now lets have this minimal code for
rtc_wakeup.
> However, I'm wondering why you are adding DT support as this
> will always be probed from the MFD driver which pass the platform_data
> and avoids that allocation.
>
You are right.
Originally, it was cleanup patch,
- remove pm80x_pdata
- Add check for pdata and np
- and around rtc_wakeup
While doing that I added this nice to have allocation.
Thanks,
Vaibhav
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
WARNING: multiple messages have this Message-ID (diff)
From: vaibhav.hiremath@linaro.org (Vaibhav Hiremath)
To: linux-arm-kernel@lists.infradead.org
Subject: [rtc-linux] [PATCH-v2] rtc: 88pm80x: add device tree support
Date: Thu, 25 Jun 2015 13:16:09 +0530 [thread overview]
Message-ID: <558BB1C1.2090400@linaro.org> (raw)
In-Reply-To: <20150620004354.GY27492@piout.net>
On Saturday 20 June 2015 06:13 AM, Alexandre Belloni wrote:
> Hi,
>
Sorry I missed this email.
Just wanted to send reminder email and saw this :)
> On 18/06/2015 at 00:28:06 +0530, Vaibhav Hiremath wrote :
>> - pdata = dev_get_platdata(&pdev->dev);
>> - if (pdata == NULL)
>> - dev_warn(&pdev->dev, "No platform data!\n");
>> + if (!pdata && !node) {
>> + dev_err(&pdev->dev,
>> + "pm80x-rtc requires platform data or of_node\n");
>> + return -EINVAL;
>> + }
>> +
>> + if (!pdata) {
>> + pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL);
>
> I had troubles to follow the rtc_wakeup initialization cleanup but it
> seems OK.
Probably, once we have complete PM support ready then it would be
easier to understand. I think as of now lets have this minimal code for
rtc_wakeup.
> However, I'm wondering why you are adding DT support as this
> will always be probed from the MFD driver which pass the platform_data
> and avoids that allocation.
>
You are right.
Originally, it was cleanup patch,
- remove pm80x_pdata
- Add check for pdata and np
- and around rtc_wakeup
While doing that I added this nice to have allocation.
Thanks,
Vaibhav
next prev parent reply other threads:[~2015-06-25 7:46 UTC|newest]
Thread overview: 125+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 18:58 [PATCH-v2 0/3] mfd: 88pm800: Add Device tree support Vaibhav Hiremath
2015-06-17 18:58 ` Vaibhav Hiremath
2015-06-17 18:58 ` [rtc-linux] " Vaibhav Hiremath
2015-06-17 18:58 ` [PATCH-v2 1/3] mfd: 88pm800: Add device " Vaibhav Hiremath
2015-06-17 18:58 ` Vaibhav Hiremath
2015-06-17 18:58 ` [rtc-linux] " Vaibhav Hiremath
2015-06-17 18:58 ` Vaibhav Hiremath
2015-06-17 18:58 ` [PATCH-v2] rtc: 88pm80x: add " Vaibhav Hiremath
2015-06-17 18:58 ` Vaibhav Hiremath
2015-06-17 18:58 ` [rtc-linux] " Vaibhav Hiremath
2015-06-20 0:43 ` Alexandre Belloni
2015-06-20 0:43 ` Alexandre Belloni
2015-06-20 0:43 ` Alexandre Belloni
2015-06-20 0:43 ` Alexandre Belloni
2015-06-25 7:46 ` Vaibhav Hiremath [this message]
2015-06-25 7:46 ` Vaibhav Hiremath
2015-06-25 7:46 ` Vaibhav Hiremath
2015-06-25 7:46 ` Vaibhav Hiremath
2015-07-07 6:37 ` Vaibhav Hiremath
2015-07-07 6:37 ` Vaibhav Hiremath
2015-07-07 6:37 ` Vaibhav Hiremath
2015-07-07 6:37 ` Vaibhav Hiremath
2015-06-17 18:58 ` [PATCH-v2 2/3] mfd: 88pm800: Allow configuration of interrupt clear method Vaibhav Hiremath
2015-06-17 18:58 ` Vaibhav Hiremath
2015-06-17 18:58 ` [rtc-linux] " Vaibhav Hiremath
2015-06-17 18:58 ` Vaibhav Hiremath
2015-06-17 18:58 ` [PATCH-v2 3/3] mfd: devicetree: bindings: Add new 88pm800 mfd binding Vaibhav Hiremath
2015-06-17 18:58 ` Vaibhav Hiremath
2015-06-17 18:58 ` [rtc-linux] " Vaibhav Hiremath
2015-06-17 18:58 ` Vaibhav Hiremath
2015-06-23 15:37 ` Rob Herring
2015-06-23 15:37 ` Rob Herring
2015-06-23 15:37 ` [rtc-linux] " Rob Herring
2015-06-23 15:37 ` Rob Herring
2015-06-23 17:02 ` Vaibhav Hiremath
2015-06-23 17:02 ` Vaibhav Hiremath
2015-06-23 17:02 ` [rtc-linux] " Vaibhav Hiremath
2015-06-24 0:29 ` Krzysztof Kozlowski
2015-06-24 0:29 ` Krzysztof Kozlowski
2015-06-24 0:29 ` [rtc-linux] " Krzysztof Kozlowski
2015-06-24 0:29 ` Krzysztof Kozlowski
2015-06-24 5:19 ` Vaibhav Hiremath
2015-06-24 5:19 ` Vaibhav Hiremath
2015-06-24 5:19 ` [rtc-linux] " Vaibhav Hiremath
2015-06-24 5:19 ` Vaibhav Hiremath
2015-06-23 5:07 ` [PATCH-v2 0/3] mfd: 88pm800: Add Device tree support Vaibhav Hiremath
2015-06-23 5:07 ` Vaibhav Hiremath
2015-06-23 5:07 ` [rtc-linux] " Vaibhav Hiremath
2015-06-23 5:07 ` Vaibhav Hiremath
[not found] <vaibhav.hiremath@linaro.org>
2015-06-02 18:45 ` [PATCH-RESEND 0/3] i2c: core/pxa: Add support for hardware lock Vaibhav Hiremath
2015-06-02 18:45 ` Vaibhav Hiremath
2015-06-02 18:45 ` [PATCH-RESEND 1/3] i2c: core: append hardware lock with bus lock Vaibhav Hiremath
2015-06-02 18:45 ` Vaibhav Hiremath
2015-06-02 18:45 ` [PATCH-RESEND 2/3] i2c: pxa: Add support for hardware lock Vaibhav Hiremath
2015-06-02 18:45 ` Vaibhav Hiremath
2015-06-02 18:45 ` [PATCH-RESEND 3/3] i2c: pxa: Add pin ctrl support for CP core access Vaibhav Hiremath
2015-06-02 18:45 ` Vaibhav Hiremath
2015-06-16 8:28 ` [PATCH-RESEND 0/3] i2c: core/pxa: Add support for hardware lock Vaibhav Hiremath
2015-06-16 8:28 ` Vaibhav Hiremath
2015-07-07 6:43 ` Vaibhav Hiremath
2015-07-07 6:43 ` Vaibhav Hiremath
2015-10-25 9:52 ` Wolfram Sang
2015-10-25 9:52 ` Wolfram Sang
2015-06-15 15:49 ` [PATCH-V2 00/12] i2c: pxa: Fixes, cleanup and support for pxa910 family Vaibhav Hiremath
2015-06-15 15:49 ` Vaibhav Hiremath
2015-06-15 15:49 ` [PATCH-V2 01/12] i2c: pxa: keep i2c irq ON in suspend Vaibhav Hiremath
2015-06-15 15:49 ` Vaibhav Hiremath
2015-06-15 15:49 ` [PATCH-V2 02/12] i2c: pxa: No need to set slave addr for i2c master mode reset Vaibhav Hiremath
2015-06-15 15:49 ` Vaibhav Hiremath
2015-07-03 20:58 ` Robert Jarzmik
2015-07-03 20:58 ` Robert Jarzmik
2015-06-15 15:49 ` [PATCH-V2 03/12] i2c: pxa: Return I2C_RETRY when timeout in pio mode Vaibhav Hiremath
2015-06-15 15:49 ` Vaibhav Hiremath
2015-06-16 5:31 ` Shubhrajyoti Datta
2015-06-16 5:31 ` Shubhrajyoti Datta
2015-06-16 7:41 ` Vaibhav Hiremath
2015-06-16 7:41 ` Vaibhav Hiremath
2015-07-03 21:07 ` Robert Jarzmik
2015-07-03 21:07 ` Robert Jarzmik
2015-06-15 15:49 ` [PATCH-V2 04/12] i2c: pxa: Reset i2c controller on timeout in interrupt and " Vaibhav Hiremath
2015-06-15 15:49 ` Vaibhav Hiremath
2015-07-03 15:27 ` Robert Jarzmik
2015-07-03 15:27 ` Robert Jarzmik
2015-07-03 18:13 ` Vaibhav Hiremath
2015-07-03 18:13 ` Vaibhav Hiremath
2015-06-15 15:49 ` [PATCH-V2 05/12] i2c: pxa: Remove compile warnning in 64bit mode Vaibhav Hiremath
2015-06-15 15:49 ` Vaibhav Hiremath
2015-06-15 15:49 ` [PATCH-V2 06/12] i2c: pxa: Update debug function to dump more info on error Vaibhav Hiremath
2015-06-15 15:49 ` Vaibhav Hiremath
2015-06-15 15:49 ` [PATCH-V2 07/12] i2c:pxa: Use devm_ variants in probe function Vaibhav Hiremath
2015-06-15 15:49 ` Vaibhav Hiremath
2015-07-03 15:28 ` Robert Jarzmik
2015-07-03 15:28 ` Robert Jarzmik
2015-07-03 18:14 ` Vaibhav Hiremath
2015-07-03 18:14 ` Vaibhav Hiremath
2015-06-15 15:49 ` [PATCH-V2 08/12] i2c: pxa: enable/disable i2c module across msg xfer Vaibhav Hiremath
2015-06-15 15:49 ` Vaibhav Hiremath
2015-07-03 15:28 ` Robert Jarzmik
2015-07-03 15:28 ` Robert Jarzmik
2015-07-03 18:23 ` Vaibhav Hiremath
2015-07-03 18:23 ` Vaibhav Hiremath
2015-07-03 18:48 ` Vaibhav Hiremath
2015-07-03 18:48 ` Vaibhav Hiremath
2015-07-03 19:44 ` Robert Jarzmik
2015-07-03 19:44 ` Robert Jarzmik
2015-06-15 15:49 ` [PATCH-V2 09/12] Documentation: binding: add new property 'disable_after_xfer' to i2c-pxa Vaibhav Hiremath
2015-06-15 15:49 ` Vaibhav Hiremath
2015-06-15 15:49 ` [PATCH-V2 10/12] i2c: pxa: Add support for pxa910/988 & new configuration features Vaibhav Hiremath
2015-06-15 15:49 ` Vaibhav Hiremath
2015-06-15 15:49 ` [PATCH-V2 11/12] i2c: pxa: Add ILCR (tLow & tHigh) configuration support Vaibhav Hiremath
2015-06-15 15:49 ` Vaibhav Hiremath
2015-07-03 15:28 ` Robert Jarzmik
2015-07-03 15:28 ` Robert Jarzmik
2015-07-03 18:17 ` Vaibhav Hiremath
2015-07-03 18:17 ` Vaibhav Hiremath
2015-06-15 15:49 ` [PATCH-V2 12/12] Documentation: binding: add sclk adjustment properties to i2c-pxa Vaibhav Hiremath
2015-06-15 15:49 ` Vaibhav Hiremath
2015-06-16 13:22 ` Rob Herring
2015-06-16 13:22 ` Rob Herring
2015-06-16 14:25 ` Vaibhav Hiremath
2015-06-16 14:25 ` Vaibhav Hiremath
2015-06-29 8:52 ` [PATCH-V2 00/12] i2c: pxa: Fixes, cleanup and support for pxa910 family Vaibhav Hiremath
2015-06-29 8:52 ` Vaibhav Hiremath
2015-07-02 16:54 ` Vaibhav Hiremath
2015-07-02 16:54 ` Vaibhav Hiremath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558BB1C1.2090400@linaro.org \
--to=vaibhav.hiremath@linaro.org \
--cc=alexandre.belloni@free-electrons.com \
--cc=chao.xie@marvell.com \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.