unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Jean Boussier <jean.boussier@shopify.com>
To: unicorn-public@yhbt.net
Subject: [PATCH] Update ruby_version requirement to allow ruby 3.0
Date: Tue, 1 Sep 2020 14:17:12 +0200	[thread overview]
Message-ID: <03DE8105-749D-46E8-A163-3AAEA72E6087@shopify.com> (raw)

Ruby just recently bump the master version to 3.0 and this version requirement in unicorn breaks our ruby-head CI.

I don't really see any reason to protect against newer Ruby version.

From d1c43dd70b06543727ac88e3930caa0482558a6b Mon Sep 17 00:00:00 2001
From: Jean Boussier <jean.boussier@gmail.com>
Date: Tue, 1 Sep 2020 14:14:07 +0200
Subject: [PATCH] Update ruby_version requirement to allow ruby 3.0

---
 unicorn.gemspec | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/unicorn.gemspec b/unicorn.gemspec
index cbe855d..9a79055 100644
--- a/unicorn.gemspec
+++ b/unicorn.gemspec
@@ -25,10 +25,7 @@
   s.homepage = 'https://yhbt.net/unicorn/'
   s.test_files = test_files
 
-  # technically we need ">= 1.9.3", too, but avoid the array here since
-  # old rubygems versions (1.8.23.2 at least) do not support multiple
-  # version requirements here.
-  s.required_ruby_version = '< 3.0'
+  s.required_ruby_version = '>= 1.9.3'
 
   # We do not have a hard dependency on rack, it's possible to load
   # things which respond to #call.  HTTP status lines in responses
-- 
2.26.2

             reply	other threads:[~2020-09-01 12:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-01 12:17 Jean Boussier [this message]
2020-09-01 14:48 ` [PATCH] Update ruby_version requirement to allow ruby 3.0 Eric Wong
2020-09-01 15:04   ` Jean Boussier
2020-09-01 15:41     ` Eric Wong
2020-09-03  7:52       ` Jean Boussier
2020-09-03  8:25         ` Eric Wong
2020-09-03  8:29           ` Jean Boussier
2020-09-03  9:31             ` Eric Wong
2020-09-03 11:23               ` Jean Boussier
2020-09-04 12:34                 ` Jean Boussier
2020-09-06  9:30                   ` Eric Wong
2020-09-07  7:13                     ` Jean Boussier
2020-09-08  2:24                       ` Eric Wong
2020-09-08  8:00                         ` Jean Boussier
2020-09-08  8:50                           ` Eric Wong
2020-09-08  8:56                             ` Jean Boussier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/unicorn/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=03DE8105-749D-46E8-A163-3AAEA72E6087@shopify.com \
    --to=jean.boussier@shopify.com \
    --cc=unicorn-public@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/unicorn.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).