From: Jean Boussier <jean.boussier@shopify.com>
To: Eric Wong <e@80x24.org>
Cc: unicorn-public@yhbt.net
Subject: Re: [PATCH] Update ruby_version requirement to allow ruby 3.0
Date: Thu, 3 Sep 2020 10:29:01 +0200 [thread overview]
Message-ID: <A1DFE7EF-FA2F-4D89-9A56-DD47BA5EB5E2@shopify.com> (raw)
In-Reply-To: <20200903082513.GA21482@dcvr>
>> That could work yes. Something akin to:
>> "This ruby version wasn't tested, blah blah".
>
> OK, can you send a patch for that?
I will once I have something working on 3.0.
>> I'm trying to figure out why the symbol isn't exported,
>> I might come back with another patch. But just in case
>> you might have an idea what's going on.
>
> I haven't built+tested ruby.git in ages (my computers are too slow).
> It could be a failure to completely clean out the old 2.8 stuff
> (either in the Ruby worktree, install paths, or unicorn worktree).
I don't think so, I'm building from a fresh docker image + fresh unicorn
clone.
I also tested other similar gems (e.g. puma) and they export the functions
just fine.
I have to admit that I don't understand enough about the build process
to figure out what's going on, so I'm not very confident I'll find a fix.
next prev parent reply other threads:[~2020-09-03 8:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 12:17 [PATCH] Update ruby_version requirement to allow ruby 3.0 Jean Boussier
2020-09-01 14:48 ` Eric Wong
2020-09-01 15:04 ` Jean Boussier
2020-09-01 15:41 ` Eric Wong
2020-09-03 7:52 ` Jean Boussier
2020-09-03 8:25 ` Eric Wong
2020-09-03 8:29 ` Jean Boussier [this message]
2020-09-03 9:31 ` Eric Wong
2020-09-03 11:23 ` Jean Boussier
2020-09-04 12:34 ` Jean Boussier
2020-09-06 9:30 ` Eric Wong
2020-09-07 7:13 ` Jean Boussier
2020-09-08 2:24 ` Eric Wong
2020-09-08 8:00 ` Jean Boussier
2020-09-08 8:50 ` Eric Wong
2020-09-08 8:56 ` Jean Boussier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/unicorn/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A1DFE7EF-FA2F-4D89-9A56-DD47BA5EB5E2@shopify.com \
--to=jean.boussier@shopify.com \
--cc=e@80x24.org \
--cc=unicorn-public@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/unicorn.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).